Home » Mailing list archives » git » 2007 » July » 23

[PATCH] Fix problematic ']'

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Johannes Sixt <johannes.sixt@...>
To: <git@...>
Cc: Johannes Schindelin <Johannes.Schindelin@...>
Subject: [PATCH] Fix problematic ']'
Date: Monday, July 23, 2007 - 4:36 pm

Not all shells grok a closing ']' of the shell '[' command without
surrounding space.

Signed-off-by: Johannes Sixt <johannes.sixt@telecom.at>
---

I didn't go the long way to change all `[ ... ]` into `test ...`

 git-rebase--interactive.sh |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/git-rebase--interactive.sh b/git-rebase--interactive.sh
index 579a45e..e0d1326 100755
--- a/git-rebase--interactive.sh
+++ b/git-rebase--interactive.sh
@@ -385,7 +385,7 @@ do
 
 		require_clean_work_tree
 
-		if [ ! -z "$2"]
+		if [ ! -z "$2" ]
 		then
 			git show-ref --verify --quiet "refs/heads/$2" ||
 				die "Invalid branchname: $2"
-- 
1.5.3.rc0

-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH] Fix problematic ']', Johannes Sixt, (Mon Jul 23, 4:36 pm)
Re: [PATCH] Fix problematic ']', Timo Hirvonen, (Mon Jul 23, 4:58 pm)
Re: [PATCH] Fix problematic ']', Johannes Schindelin, (Mon Jul 23, 4:51 pm)