Re: [PATCH (REVISED)] Add core.editor configuration variable

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

To: <git@...>

Cc: Adam Roben <aroben@...>, Junio C Hamano <gitster@...>

Subject: Re: [PATCH (REVISED)] Add core.editor configuration variable

Date: Thursday, July 19, 2007 - 3:48 am

On Thursday 2007 July 19, Adam Roben wrote:

quoted text>    Well, it turns out we already do launch an editor in other places,
> namely "git am -i" and "git send-email --compose". So, this patch takes
> care of those cases as well.

Perhaps I'm being overly pedantic, but it seems odd to put options that are 
relevant only to porcelain under the "core" section.

core.pager is in the same category - but that's already in.

Would porcelain.editor be a better name for this variable?

Andy

-- 
Dr Andy Parkins, M Eng (hons), MIET
andyparkins@gmail.com
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:

[PATCH (REVISED)] Add core.editor configuration variable, Adam Roben, (Thu Jul 19, 2:55 am)

Re: [PATCH (REVISED)] Add core.editor configuration variable, Andy Parkins, (Thu Jul 19, 3:48 am)

Re: [PATCH (REVISED)] Add core.editor configuration variable, Brian Gernhardt, (Thu Jul 19, 10:24 am)

Re: [PATCH (REVISED)] Add core.editor configuration variable, Nicolas Pitre, (Thu Jul 19, 3:32 pm)

Re: [PATCH (REVISED)] Add core.editor configuration variable, Junio C Hamano, (Thu Jul 19, 8:20 pm)

Re: [PATCH (REVISED)] Add core.editor configuration variable, Andy Parkins, (Thu Jul 19, 10:52 am)

Re: [PATCH (REVISED)] Add core.editor configuration variable, Johannes Schindelin, (Thu Jul 19, 6:00 am)

Re: [PATCH (REVISED)] Add core.editor configuration variable, Andy Parkins, (Thu Jul 19, 6:48 am)

Re: [PATCH (REVISED)] Add core.editor configuration variable, Johannes Schindelin, (Thu Jul 19, 7:15 am)

Re: [PATCH (REVISED)] Add core.editor configuration variable, Andy Parkins, (Thu Jul 19, 10:23 am)

Re: [PATCH (REVISED)] Add core.editor configuration variable, Nicolas Pitre, (Thu Jul 19, 3:28 pm)


linux-kernel:
Greg KH	[GIT PATCH] driver core patches against 2.6.24
Tarkan Erimer	Re: Dual-Licensing Linux Kernel with GPL V2 and GPL V3
Amit K. Arora	[RFC] Heads up on sys_fallocate()
Chuck Ebbert	Why do so many machines need "noapic"?
git:

linux-netdev:
Jarek Poplawski	[PATCH] pkt_sched: Destroy gen estimators under rtnl_lock().
David Miller	[GIT]: Networking
Gerrit Renker	[PATCH 27/37] dccp: Integration of dynamic feature activation - part 2 (server side)
Natalie Protasevich	[BUG] New Kernel Bugs
openbsd-misc: