git mailing list

FromSubjectsort iconDate
Junio C Hamano
Re: Empty directories...
I did not imply any such thing, by the way. These are off the top of my head technical issues and there probably are more, but I limited the list to technical side of the things. You of course have social side to take care of. If you are breaking everybody else's index, you would need to tell everybody: "I am sorry but if you upgrade your git to this version that does what I want, you have to nuke your index and start over, so commit all changes first, and then update the git. Sorry for causi...
Jul 18, 7:34 pm 2007
David Kastrup
Re: Proposal about --help options and man calls
If I call command --help, I don't want a pager barfing at me. Never. I have scrollback for that. It is my choice when I page and when I page not. There are manual pages who go through 50 pages or so, however. There are commands that fundamentally are connected with a pager. man is, for example. But most cases where git calls a pager (and that includes his way of calling man without getting asked for it explicitly) utterly surprise me. So I set GIT_PAGER to cat and hoped that it would get git...
Jul 18, 7:28 pm 2007
Benoit SIGOURE
[PATCH] Proposal for git-svn
Hello, I'm importing many SVN repositories in Git and I ran across a problem: ufloat.h has mode 120000but is not a link I've read the code and checked-out the revision where the problem occured and it turns out that some stupid user commited a broken symlink and I think that's where the problem came from. I'm proposing the following trivial change to let git-svn clone continue its work: diff --git a/git-svn.perl b/git-svn.perl index 01c3904..a82baf4 100755 --- a/git-svn.perl +++ b/...
Jul 18, 5:07 pm 2007
David Kastrup
Proposal about --help options and man calls
Frequently, git somecommand --help will call the man command to display help pages. I think that when it does so, it should pass the value of the GIT_PAGER variable copied into the PAGER variable: the paging happens on behalf of git here. -- David Kastrup, Kriemhildstr. 15, 44793 Bochum -
Jul 18, 5:50 pm 2007
Junio C Hamano
Re: Proposal about --help options and man calls
Hmph. Is that to help people who uses GIT_PAGER but no PAGER, or have both but set it differently (setting both and in the same way does not make much sense). But what it means is that "git command --help" and "man git-command" would be paged differently. I highly doubt it is really desirable. What's the reason to set GIT_PAGER and PAGER differently to begin with? Can people give examples of the reason why? By the way, I would understand if there is a request to honor GIT_LESS environment ...
Jul 18, 7:16 pm 2007
Brian Gernhardt
Re: Proposal about --help options and man calls
I currently have GIT_PAGER (actually, core.pager) set to tig. Tig has lots of useful features for visualizing history and jumping between patches and logs. But for everything that isn't git, less is far better. ~~ Brian -
Jul 18, 11:49 pm 2007
Daniel Barkalow
USE_CURL_MULTI and http.h in general
The changes I made to the commit-walker fetch code turn out not to work with USE_CURL_MULTI, and I'm not at all clear on how to deal with it. I think the current code for USE_CURL_MULTI also can't work for having multiple things in the same executable using http.h, which will be a problem for having both ls-remote and http-fetch as part of builtin-fetch, as well as eventually calling http-push without an exec from builtin-push. Is there anyone around who understands it? -Daniel *This .sig l...
Jul 18, 5:19 pm 2007
Fredrik Tolf
Re: Manpage rendering faults
Well, if it were a "pure" manpage, I'd try to use pic(1) to do it for the PS version, but I don't suspect asciidoc has a similar feature. I don't actually know, though -- again, I know virtually nothing about asciidoc. Fredrik Tolf -
Jul 18, 4:06 pm 2007
Julian Phillips
[PATCH] Force listingblocks to be monospaced in manpages
For the html output we can use a stylesheet to make sure that the listingblocks are presented in a monospaced font. For the manpages do it manually by inserting a ".ft C" before and ".ft" after the block in question. In order for these roff commands to get through to the manpage they have to be element encoded to prevent quoting. Signed-off-by: Julian Phillips <julian@quantumfyre.co.uk> --- How about this? Seems to work for me - but I'm not an asciidoc/docbook/roff expert ... D...
Jul 18, 5:33 pm 2007
Junio C Hamano
Re: [PATCH] Force listingblocks to be monospaced in manpages
I tried with your patch, both with asciidoc7 and asciidoc8. Did you really mean "⌂" above? Replacing them with "." gave me a series of these changes (diff between output before and after your patch with the "s/\⌂/./g" fixup): @@ -83,10 +83,13 @@ .sp .RS 3n .nf +.ft C *** Commands *** 1: status 2: update 3: revert 4: add untracked 5: patch 6: diff 7: q...
Jul 18, 7:56 pm 2007
Julian Phillips
Re: [PATCH] Force listingblocks to be monospaced in manpages
I did mean it. I originally just had .ft, but I was getting \&.ft in the manpage, which then just came out as .ft in the console. I got the ⌂ from http://docbook.sourceforge.net/release/xsl/current/manpages/utility.xsl, so I assumed it was the "correct" thing to use ... ⌂ (or U+2302) seems to be a character from the unicode "Misc. Technical" section ... looks a bit like a house. See sixth bullet from [ message continues ]
" title="http://docbook.sourceforge.net/release/xsl/current/RELEASE...">http://docbook.sourceforge.net/release/xsl/current/RELEASE...
Jul 18, 9:21 pm 2007
Julian Phillips
[PATCH] Force listingblocks to be monospaced in manpages
For the html output we can use a stylesheet to make sure that the listingblocks are presented in a monospaced font. For the manpages do it manually by inserting a ".ft C" before and ".ft" after the block in question. This makes the ascii-art diagrams readable in PS output. In order for these roff commands to get through to the manpage they have to be element encoded to prevent quoting. In particular with docbook xsl 1.72.0 and newer we have to use U+2302 instead of . to prevent the roff command ...
Jul 18, 5:33 pm 2007
krh
[PATCH] Implement git commit as a builtin.
--- Here's another update on the work in progress. At this point, the C version is almost complete, there's only a few issues left (look for FIXME in builtin-commit.c). I've added a commit test case which should be split out in a patch on its own, but the good news is that it successfully exercises most of the command line options and the C version passes. My plan for the remainder of the work is still to wrap up the last few pieces of functionality and then start taking this big patch apart in ...
Jul 18, 3:19 pm 2007
Carlos Rica Jul 18, 5:27 pm 2007
Nicolas Pitre
Re: [PATCH] Implement git commit as a builtin.
On Wed, 18 Jul 2007, Kristian H
Jul 18, 3:43 pm 2007
Fredrik Tolf
Manpage rendering faults
I often read manpages using a `man -t whatever | ggv -' command, since I like how it is rendered in PostScript. However, it turns out that some things in the Git manpages don't really render very well using that method. For example, in the git-rebase manpage, there are two history graphs that look like this when reading the manpages normally in a terminal: A---B---C topic / D---E---F---G master and then A'--B'--C' topic / D---E---F---G master Howeve...
Jul 18, 2:47 pm 2007
Julian Phillips
Re: Manpage rendering faults
It's a proportional font issue ... Running "groff -Tps -f C -man $(man -w git-rebase) | ggv -" should display it correctly. (The "-f C" being the part the man doesn't do) No idea how to make it use that font by default though ... not even sure if you can put that kind of information into a man page? -- Julian --- Dinner suggestion #302 (Hacker's De-lite): 1 tin imported Brisling sardines in tomato sauce 1 pouch Chocolate Malt Carnation Instant Breakfast 1 carton milk -
Jul 18, 3:29 pm 2007
Perrin Meyer
Re: git svn dcommit seg fault
[perrin@whisper TESTGIT]$ git svn --version git-svn version 1.5.3.rc2.4.g726f9 (svn 1.2.3) I get the "post commit" email from our SVN central server, so it appears that on the SVN side the commit worked? I tried running git svn with --verbose, but that did not print out any more error messages (besides the seg fault). Thanks, Perrin ----- Original Message ---- From: Eric Wong <eric@petta-tech.com> To: Perrin Meyer <perrinmeyer@yahoo.com> Cc: git@vger.kernel.org Sent: W...
Jul 18, 2:33 pm 2007
Carlos Rica
[PATCH] Rename read_pipe() with read_fd() and make its buffe...
The new name is closer to the purpose of the function. A NUL-terminated buffer makes things easier when callers need that. Since the function returns only the memory written with data, almost always allocating more space than needed because final size is unknown, an extra NUL terminating the buffer is harmless. It is not included in the returned size, so the function remains working as before. Also, now the function allows the buffer passed to be NULL at first, and alloc_nr is now used for growi...
Jul 18, 2:31 pm 2007
Daniel Barkalow
Rsync fetch?
The only thing that's totally missing at this point from my builtin-fetch is rsync. Do we still care? Any takers for actually implementing it? -Daniel *This .sig left intentionally blank* -
Jul 18, 12:37 pm 2007
Johannes Schindelin
Re: Rsync fetch?
Hi, I'll have a go at it, but I will probably have time for that only on the weekend. Ciao, Dscho -
Jul 18, 8:21 pm 2007
Alex Riesen
Re: Rsync fetch?
Maybe pull the rsync parts from the old fetch, put them into a script and call it? Not very simple, as it looks. Maybe not worth the effort. -
Jul 18, 4:53 pm 2007
Johannes Schindelin
[PATCH 2/2] filter-branch: introduce convenience function "s...
With this function, a commit filter can leave out unwanted commits (such as temporary commits). It does _not_ undo the changeset corresponding to that commit, but it _skips_ the revision. IOW its childrens' tree objects remain the same. If you like to commit early and often, but want to filter out all intermediate commits, marked by "@@@" in the commit message, you can now do this with git filter-branch --commit-filter ' if git cat-file commit $GIT_COMMIT | grep '@@@' > /dev/null; t...
Jul 18, 11:54 am 2007
Johannes Schindelin
[PATCH 1/2] filter-branch: provide the convenience functions...
By sourcing git-filter-branch and stopping after the function definitions, the commit filter can now access the convenience functions like "map". This is done automatically if you specify a commit filter. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de> --- git-filter-branch.sh | 12 ++++++++---- 1 files changed, 8 insertions(+), 4 deletions(-) diff --git a/git-filter-branch.sh b/git-filter-branch.sh index 0d000ed..b574612 100755 --- a/git-filter-branch.sh +++ b/git...
Jul 18, 11:52 am 2007
Junio C Hamano
Re: [PATCH 1/2] filter-branch: provide the convenience funct...
Hmmmmmm. Care to enlighten why this is not just: filter_commit="SOURCE_FUNCTIONS=1 . \"$0\"; $OPTARG" Is it because you cd(1) around in the script, and it can be relative to where you started? In either case, are you quoting potential funnies (such as '"' or '\\') in "$0" sufficiently? Exporting this_script variable, and changing the above to filter_commit='SOURCE_FUNCTIONS=1 . "$this_script";'" $OPTARG" to arrange the shell that is invoked with 'sh -c' to expand its value would m...
Jul 18, 8:19 pm 2007
Johannes Schindelin
[REVISED PATCH 1/2] filter-branch: provide the convenience f...
By sourcing git-filter-branch and stopping after the function definitions, the commit filter can now access the convenience functions like "map". Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de> --- On Wed, 18 Jul 2007, Junio C Hamano wrote: > Exporting this_script variable, and changing the above to > > filter_commit='SOURCE_FUNCTIONS=1 . "$this_script";'" $OPTARG" > > to arrange the shell that is invoked with 'sh -c' to expand its > value...
Jul 18, 9:25 pm 2007
Johannes Schindelin
Re: [PATCH 1/2] filter-branch: provide the convenience funct...
Hi, Will do. You know, I do have my problems with correct quoting, and the way I did it in this patch was always good enough for me. Which does not mean much... Ciao, Dscho -
Jul 18, 9:16 pm 2007
Peter Hartlich
Wrong time in git-log when using right/ timezone
Hi, My timezone is set to right/Europe/Berlin. git-log 1.5.2.2 gives me output such as: | Date: Wed Jul 18 16:17:31 2007 +0159 Note the timezone, which should be +0200. I'm using tzcode/tzdata 2007f from <ftp://elsie.nci.nih.gov/pub/>. A small test script is attached. Regards, Peter Hartlich
Jul 18, 11:36 am 2007
Linus Torvalds
Re: Wrong time in git-log when using right/ timezone
Wow. I just tried: git show --raw --date=local with TZ=CET and TZ=right/Europe/Berlin respectively. Trippy. I get: commit 9dfdf14b3805e89aa2782458bda15b3dfae24c09 Author: Junio C Hamano <gitster@pobox.com> Date: Mon Jul 16 01:41:17 2007 for the CET case, but for right/Europe/Berlin I get: commit 9dfdf14b3805e89aa2782458bda15b3dfae24c09 Author: Junio C Hamano <gitster@pobox.com> Date: Mon Jul 16 01:39:54 2007 ie apparently Berlin is in a timezone of it...
Jul 18, 1:01 pm 2007
Junio C Hamano
Re: Wrong time in git-log when using right/ timezone
No, I do not think the wackiness is from Germans. Using right/ perhaps without realizing the differences between TZ=right/Europe/Berlin and TZ=Europe/Berlin is probably the source of confusion. I do not offhand know what role "leap second adjustment" should play in the context of converting from Unix time we store in git commit objects to human readable role. As far as I understand, the returned timestamp from time(2), which we record in commit objects, is already "leap second adjusted". ...
Jul 18, 4:57 pm 2007
Alex Riesen Jul 18, 4:29 pm 2007
Julian Phillips
Re: Wrong time in git-log when using right/ timezone
Well ... not if you compare right/Europe/Berlin vs right/CET jp3@neutron: ~>TZ=right/CET date '+%H:%M:%S %z'; TZ=right/Europe/Berlin date '+%H:%M:%S %z' 19:49:45 +0200 19:49:45 +0200 but, I suspect that the following is the underlying cause of the problem? jp3@neutron: ~>TZ=right/UTC date '+%H:%M:%S %z'; TZ=UTC date '+%H:%M:%S %z' 17:51:32 +0000 17:51:55 +0000 Is git working internally in TZ=UTC? -- Julian --- Homer: We always have one good kid and one lousy kid. Wh...
Jul 18, 1:55 pm 2007
Linus Torvalds
Re: Wrong time in git-log when using right/ timezone
Yes. The TZ in git terms has no meaning what-so-ever, it's purely for "decoration", so that people can see what the local time was. But a git time really *is* the UTC seconds-since-1970, and the timezone is saved so that it can be shown, but not for anything else. So git always stores times in UTC, but then when showing them, it shows them as relative to the timezone they were done in. You can see this by doing git cat-file commit HEAD which shows something like author Juni...
Jul 18, 2:19 pm 2007
Peter Hartlich
Re: Wrong time in git-log when using right/ timezone
Forgot to add that the bug is present in the current dev version. Regards, Peter Hartlich -
Jul 18, 12:04 pm 2007
Simon Hausmann
git-p4 pull request
The following changes since commit a5e407988b35b7353bd03c770afc647670c25981: Jim Meyering (1): git-cvsserver: detect/diagnose write failure, etc. are available in the git repository at: git://people.freedesktop.org/~hausmann/git-p4 master Scott Lamb (2): git-p4: use subprocess in p4CmdList git-p4: input to "p4 files" by stdin instead of arguments Simon Hausmann (3): git-p4: Cleanup, make listExistingP4Branches a global function for later use. git-p4: Fix...
Jul 18, 11:42 am 2007
Junio C Hamano
Re: git-p4 pull request
Thanks, pulled (but not pushed out yet). -
Jul 18, 8:25 pm 2007
David Kastrup
[PATCH 1/2] Makefile: create an install-symlinks target
This target allows you to have git installed in one location, and have symbolic links to all of the programs installed in another location. For example, if git was installed to /opt/git with make prefix=/opt/git install you can install symbolic links in /usr/local/bin with make symlinkprefix=/usr/local prefix=/opt/git \ install-symlinks This makes it reasonably easy to remove such a package, by doing rm -rf /opt/git and then removing stale links with find /usr/local -xtype ...
Jul 18, 6:41 am 2007
David Kastrup
[PATCH 2/2] Makefile: use $(FIND) instead of find
Some people might prefer to be able to specify the find utility to use, in particular for the more complicated usage in the install-symlinks target. Signed-off-by: David Kastrup <dak@gnu.org> --- Makefile | 13 +++++++------ 1 files changed, 7 insertions(+), 6 deletions(-) diff --git a/Makefile b/Makefile index 7e53378..cf72327 100644 --- a/Makefile +++ b/Makefile @@ -178,6 +178,7 @@ AR = ar RM = rm -f TAR = tar INSTALL = install +FIND = find RPMBUILD = rpmbuild TCL_PATH...
Jul 18, 10:45 am 2007
David Kastrup
Re: [PATCH] Makefile: create an install-symlinks target
I think that the install-symlinks target is rather more specialized than the tags and TAGS targets, yet those use just "find". I think I'll be able to throw out the -mindepth, however. It was necessary in a version that used find $(prefix), since /opt/git matched -type d -name git* but with find . this should not be relevant. I'll amend that patch and prepare a separate one that uses $(FIND) everywhere. -- David Kastrup -
Jul 18, 10:06 am 2007
David Kastrup
Re: [PATCH] filter-branch: get rid of "set -e"
Not in bash. Just tried it. But there are Bourne shells that do get I'd rather write [ "X$CDPATH" = "X" ] || unset CDPATH With regard to shells, there is an interesting document (info "(autoconf) Portable Shell") which is rather disillusioning. A real horror show is (info "(autoconf) Limitations of Builtins") where one learns that using if without else can lead to bad exit status, too. -- David Kastrup -
Jul 18, 9:27 am 2007
Johannes Schindelin
Re: [PATCH] filter-branch: get rid of "set -e"
Hi, [please Cc me] The mail I was replying to _explicitely_ stated that it _was_ with bash. We would write that as "test", not "[". But it is much cleaner to get rid of "set -e" anyway. Ciao, Dscho -
Jul 18, 10:05 am 2007
David Kastrup
Re: [PATCH] Makefile: create an install-symlinks target
Oh, by the way: I got _crazy_ when I first committed this, then found a mistake and corrected it, and then repeatedly did git add config/emacs/Makefile git-commit --amend message again and again, while nothing at all changed. Of course, this was because I added the wrong Makefile. I am not sure how git could be more helpful here. Just wanted to report it. Maybe it could have noticed that my "amendment" was empty? On the other hand, I might have wanted to amend the commit message. Sigh. ...
Jul 18, 8:41 am 2007
David Kastrup
[PATCH] Makefile: create an install-symlinks target
Use this, for example, to do rm -rf /opt/git make prefix=/opt/git install make symlinkprefix=/usr/local prefix=/opt/git install-symlinks --- Makefile | 9 ++++++++- 1 files changed, 8 insertions(+), 1 deletions(-) diff --git a/Makefile b/Makefile index 73b487f..df2fe8d 100644 --- a/Makefile +++ b/Makefile @@ -142,6 +142,7 @@ ALL_LDFLAGS = $(LDFLAGS) STRIP ?= strip prefix = $(HOME) +symlinkprefix = /usr/local bindir = $(prefix)/bin gitexecdir = $(bindir) sharedir = $(prefix)/...
Jul 18, 6:41 am 2007
Alex Riesen
Re: [PATCH] Makefile: create an install-symlinks target
Sometime about now you'll need to define $(FIND) or even $(GNUFIND) for find. There are proprietary systems where find is not available or does not do what you want it to. There is often a gfind installed somewhere on these systems. -
Jul 18, 9:08 am 2007
Johannes Schindelin
Re: [PATCH] Makefile: create an install-symlinks target
Hi, You mean This target allows you to have git installed in one location, and have symbolic links to all of the programs installed in another location. For example, if git was installed to /opt/git with make prefix=/opt/git install you can install symbolic links in /usr/local/bin with make symlinkprefix=/usr/local prefix=/opt/git \ install-symlinks Hmm. Why not install it with a proper package manager in the correct place to begin with? Somehow I find so many symbo...
Jul 18, 8:48 am 2007
Peter Baumann
Re: [PATCH] Makefile: create an install-symlinks target
Seeing this excellent explantion from Dscho, this sound exactly like a perfect use case for xstow [1]. It allows you to install your application into e.g. /usr/local/stow/git and by running 'xstow git' in /usr/local/stow it would create all the necessary links in /usr/local/{bin,share,doc} or any other place you want. -Peter [1]: http://xstow.sourceforge.net/ -
Jul 18, 10:33 am 2007
David Kastrup
Re: Empty directories...
I am not sure about "definitely", but there certainly are applications Please spare us the sophistry. Probably the most flexible approach would be to be able to specify a checkout umask, defaulting to 700 (the other bits are then filled in from the normal user umask). For archival purposes, one would then set it to 777 instead. There is the question how to deal with checkins. While there is no harm in checking in the full permissions in case one would need them, it would likely be a nuisance...
Jul 18, 8:12 am 2007
Johannes Schindelin
Re: Empty directories...
Hi, No, no, no. It should not be tracked. It is the responsibility of the _user_ to set it to something sane, be that by a umask or by sticky groups, or by setting the permissions of the parent directory. It is _nothing_ we want to put into the repository. That is the _wrong_ This question is invalid. Git only tracks the _executable_ bit. And again, it is the users' responsibility, by setting the umask, to have the I have. But that does not apply here, because I used the term "...
Jul 18, 7:24 am 2007
Matthieu Moy
Re: Empty directories...
I'm not sure it's wrong to be able to track permissions, but it's definitely wrong to track them by default. GNU Arch had some permission tracking, and I got hit by it several times. You have several things you might have wanted to track: * read/write for the user. But I can't imagine a case where you wouldn't want to be able to read and write your own files. * permissions for group. But that doesn't make any sense when several persons work on the same project, and don't share the same ...
Jul 18, 7:40 am 2007
Junio C Hamano
Re: [PATCH] unpack-trees.c: assume submodules are clean duri...
Passing of ce instead of path in the unpack-trees callchain looks like the right thing to do. Good job. Thanks. -
Jul 18, 3:29 am 2007
previous daytodaynext day
July 17, 2007July 18, 2007July 19, 2007