Home » Mailing list archives » git » 2007 » July » 18

Re: [PATCH 1/2] filter-branch: provide the convenience functions also for commit filters

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Junio C Hamano <gitster@...>
To: Johannes Schindelin <Johannes.Schindelin@...>
Cc: <git@...>, <gitster@...>
Subject: Re: [PATCH 1/2] filter-branch: provide the convenience functions also for commit filters
Date: Wednesday, July 18, 2007 - 8:19 pm

Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:


Hmmmmmm.

Care to enlighten why this is not just:

	filter_commit="SOURCE_FUNCTIONS=1 . \"$0\"; $OPTARG"

Is it because you cd(1) around in the script, and it can be
relative to where you started?

In either case, are you quoting potential funnies (such as '"'
or '\\') in "$0" sufficiently?  Exporting this_script variable,
and changing the above to

	filter_commit='SOURCE_FUNCTIONS=1 . "$this_script";'" $OPTARG"

to arrange the shell that is invoked with 'sh -c' to expand its
value would make it smaller problem, I suspect.


-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH 1/2] filter-branch: provide the convenience functions..., Johannes Schindelin, (Wed Jul 18, 11:52 am)
Re: [PATCH 1/2] filter-branch: provide the convenience funct..., Junio C Hamano, (Wed Jul 18, 8:19 pm)
[REVISED PATCH 1/2] filter-branch: provide the convenience f..., Johannes Schindelin, (Wed Jul 18, 9:25 pm)
Re: [PATCH 1/2] filter-branch: provide the convenience funct..., Johannes Schindelin, (Wed Jul 18, 9:16 pm)