Re: [PATCH 1/3] Move bundle specific stuff into bundle.[ch]

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Shawn O. Pearce <spearce@...>
Cc: Daniel Barkalow <barkalow@...>, Johannes Schindelin <Johannes.Schindelin@...>, <git@...>
Date: Wednesday, July 18, 2007 - 2:13 am

"Shawn O. Pearce" <spearce@spearce.org> writes:


Gaah, my eyes, my *eyes*!!

	runs, stays in bathroom for 10 minutes and washes, and
        comes back...

It might not be actually so bad.  But I wonder if it would be
more obvious if you do not show the whole "a-" lines but leave
just a marker there.  That is (ugliness of "a@@" and "a-" that
made me wash my eyes needs to be fixed, though -- but that is
only the syntax):

a@@ -1598,43 +1635,6 a@@ apply_config
  
  ######################################################################
  ##
a-<<< Block a was originally here >>>
  ## ui construction
  
  set ui_comm {}

You are coming up with a new output format that is only used
when it is a straight move and nothing else, so by definition
there is really no need to show both removal and addition.

-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH 1/3] Move bundle specific stuff into bundle.[ch], Johannes Schindelin, (Tue Jul 17, 6:49 pm)
Re: [PATCH 1/3] Move bundle specific stuff into bundle.[ch], Daniel Barkalow, (Tue Jul 17, 10:48 pm)
Re: [PATCH 1/3] Move bundle specific stuff into bundle.[ch], Johannes Schindelin, (Wed Jul 18, 5:56 am)
Re: [PATCH 1/3] Move bundle specific stuff into bundle.[ch], Daniel Barkalow, (Wed Jul 18, 12:25 pm)
Re: [PATCH 1/3] Move bundle specific stuff into bundle.[ch], Johannes Schindelin, (Wed Jul 18, 12:33 pm)
Re: [PATCH 1/3] Move bundle specific stuff into bundle.[ch], Daniel Barkalow, (Tue Jul 17, 11:23 pm)
Re: [PATCH 1/3] Move bundle specific stuff into bundle.[ch], Johannes Schindelin, (Wed Jul 18, 6:09 am)
Re: [PATCH 1/3] Move bundle specific stuff into bundle.[ch], Shawn O. Pearce, (Tue Jul 17, 11:29 pm)
Re: [PATCH 1/3] Move bundle specific stuff into bundle.[ch], Junio C Hamano, (Wed Jul 18, 2:13 am)
Re: [PATCH 1/3] Move bundle specific stuff into bundle.[ch], Shawn O. Pearce, (Wed Jul 18, 2:19 am)