Home » Mailing list archives » git » 2007 » July » 17

Re: [PATCH] git-gui: Handle git versions of the form n.n.n.GIT

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Martin Langhoff <martin.langhoff@...>
To: Shawn O. Pearce <spearce@...>
Cc: Julian Phillips <julian@...>, <git@...>
Subject: Re: [PATCH] git-gui: Handle git versions of the form n.n.n.GIT
Date: Tuesday, July 17, 2007 - 10:32 pm

On 7/17/07, Shawn O. Pearce <spearce@spearce.org> wrote:

I'm far from an authority on things TCL, but I don't think this patch
should be merged as is. Julian is reporting it as a "fixes my symptom"
patch, and that's barely what it does.

The regex should be more liberal, imho. With this superficial fix:

 - Builds from a dirty tree have a broken git gui

 - Builds from a repo with a nonstandard (local) tagname tagname  have
a broken git gui

cheers,


martin
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
Problem running git-gui, Julian Phillips, (Tue Jul 17, 7:48 am)
[PATCH] git-gui: Handle git versions of the form n.n.n.GIT, Julian Phillips, (Tue Jul 17, 5:14 pm)
Re: [PATCH] git-gui: Handle git versions of the form n.n.n.GIT, Shawn O. Pearce, (Tue Jul 17, 9:51 pm)
Re: [PATCH] git-gui: Handle git versions of the form n.n.n.GIT, Martin Langhoff, (Tue Jul 17, 10:32 pm)
Re: [PATCH] git-gui: Handle git versions of the form n.n.n.GIT, Shawn O. Pearce, (Tue Jul 17, 10:54 pm)
Re: [PATCH] git-gui: Handle git versions of the form n.n.n.GIT, Julian Phillips, (Wed Jul 18, 6:10 am)
Re: [PATCH] git-gui: Handle git versions of the form n.n.n.GIT, Brian Downing, (Tue Jul 17, 5:40 pm)
Re: [PATCH] git-gui: Handle git versions of the form n.n.n.GIT, Shawn O. Pearce, (Tue Jul 17, 9:52 pm)
Re: [PATCH] git-gui: Handle git versions of the form n.n.n.GIT, Brian Downing, (Tue Jul 17, 5:45 pm)
Re: [PATCH] git-gui: Handle git versions of the form n.n.n.GIT, Linus Torvalds, (Tue Jul 17, 6:34 pm)
Re: [PATCH] git-gui: Handle git versions of the form n.n.n.GIT, Jason Sewall, (Tue Jul 17, 5:49 pm)
Re: [PATCH] git-gui: Handle git versions of the form n.n.n.GIT, Shawn O. Pearce, (Tue Jul 17, 9:48 pm)
Re: Problem running git-gui, Thomas Glanzmann, (Tue Jul 17, 8:04 am)