login
Header Space

 
 

Re: [PATCH 0/6] Introduce commit notes

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Andy Parkins <andyparkins@...>
Cc: <git@...>, Johannes Schindelin <Johannes.Schindelin@...>, Alberto Bertogli <albertito@...>, Johan Herland <johan@...>
Date: Monday, July 16, 2007 - 4:11 am

Andy Parkins <andyparkins@gmail.com> writes:


Hmph, you are right.  In this sequence:

	hex = sha1_to_hex(commit->object.sha1);
	snprintf(name, sizeof(name), "%s:%.*s/%.*s",
			notes_ref_name, 2, hex, 38, hex + 2);
	if (get_sha1(name, sha1))
		return;

Instead, we could read the tree object by hand in the commit
that is referenced by notes_ref_name, which has uniform two
letter names for subtrees which can be binary searched, open the
tree for that entry, again by hand, and do another binary search
because that tree has uniform 38-letter names.  That certainly
could be done.

Sounds like a "fun" project for some definition of the word.

-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH 0/6] Introduce commit notes, Johannes Schindelin, (Sun Jul 15, 7:19 pm)
Re: [PATCH 0/6] Introduce commit notes, Andy Parkins, (Mon Jul 16, 3:57 am)
Re: [PATCH 0/6] Introduce commit notes, Junio C Hamano, (Mon Jul 16, 4:11 am)
Re: [PATCH 0/6] Introduce commit notes, Johannes Schindelin, (Mon Jul 16, 12:26 pm)
Re: [PATCH 0/6] Introduce commit notes, Junio C Hamano, (Mon Jul 16, 1:56 pm)
Re: [PATCH 0/6] Introduce commit notes, Johannes Schindelin, (Wed Jul 18, 9:34 pm)
[WIP PATCH 6/6] notes: add notes-index for a substantial spe..., Johannes Schindelin, (Sun Jul 15, 7:26 pm)
Re: [WIP PATCH 6/6] notes: add notes-index for a substantial..., Johannes Schindelin, (Mon Jul 16, 12:29 pm)
Re: [WIP PATCH 6/6] notes: add notes-index for a substantial..., Johannes Schindelin, (Sun Jul 15, 7:33 pm)
[PATCH 5/6] Document git-notes, Johannes Schindelin, (Sun Jul 15, 7:24 pm)
[PATCH 4/6] Add a test script for "git notes", Johannes Schindelin, (Sun Jul 15, 7:24 pm)
[PATCH 3/6] Add git-notes, Johannes Schindelin, (Sun Jul 15, 7:23 pm)
[PATCH 2/6] Introduce commit notes, Johannes Schindelin, (Sun Jul 15, 7:23 pm)
Re: [PATCH 2/6] Introduce commit notes, Junio C Hamano, (Sun Jul 15, 7:36 pm)
Re: [PATCH 2/6] Introduce commit notes, Junio C Hamano, (Sun Jul 15, 8:05 pm)
Re: [PATCH 2/6] Introduce commit notes, Johannes Schindelin, (Sun Jul 15, 7:52 pm)
[PATCH 1/6] Rename git_one_line() to git_line_length() and e..., Johannes Schindelin, (Sun Jul 15, 7:22 pm)
speck-geostationary