Re: [PATCH 2/2] Teach rebase an interactive mode

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Johannes Schindelin <Johannes.Schindelin@...>
Cc: <git@...>, <gitster@...>
Date: Saturday, June 23, 2007 - 11:39 pm

On Jun 23, 2007, at 7:01 PM, Johannes Schindelin wrote:


It's not at all obvious from your commit message or the documentation  
where this list comes from.  At first look I thought I would have had  
to type it in.  It took digging into the code to be sure how it  
worked.  You probably want to mention in the documentation that the  
list is generated from the arguments and given in a text editor.

Is there a way to say "Oops, that's the wrong list.  Don't do  
anything."?

Perhaps starting the list with a header like the following would make  
it more user-friendly (Obviously requires s/#.*$//):

# Rebasing $from..$to onto $commit
#
# Commands:
#  pick = use commit
#  squash = meld commit into previous
# <<More useful information here>>

However, those are nits to take a good idea to a great one.  I like  
it very much.

~~ Brian
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH 2/2] Teach rebase an interactive mode, Johannes Schindelin, (Sat Jun 23, 7:01 pm)
Re: [PATCH 2/2] Teach rebase an interactive mode, Junio C Hamano, (Sun Jun 24, 4:15 am)
Re: [PATCH 2/2] Teach rebase an interactive mode, Johannes Schindelin, (Sun Jun 24, 10:33 am)
Re: [PATCH 2/2] Teach rebase an interactive mode, Johannes Schindelin, (Sun Jun 24, 7:09 am)
[PATCH 2/2] Teach rebase an interactive mode, Johannes Schindelin, (Sun Jun 24, 8:11 pm)
[PATCH 1/2] Move the pick_author code to git-sh-setup, Johannes Schindelin, (Sun Jun 24, 8:04 pm)
Re: [PATCH 2/2] Teach rebase an interactive mode, Brian Gernhardt, (Sat Jun 23, 11:39 pm)
Re: [PATCH 2/2] Teach rebase an interactive mode, Johannes Schindelin, (Sun Jun 24, 6:12 am)
Re: [PATCH 2/2] Teach rebase an interactive mode, Alex Riesen, (Sat Jun 23, 7:33 pm)
Re: [PATCH 2/2] Teach rebase an interactive mode, Johannes Schindelin, (Sat Jun 23, 7:36 pm)