git mailing list

FromSubjectsort iconDate
Jakub Narebski
Re: [PATCH v3] Support ent:relative_path
Dana How wrote: > Most commands accept relative paths,
May 4, 9:11 pm 2007
Dana How
[PATCH v3] Support ent:relative_path
Most commands accept relative paths, but this is not true of arguments in ent:path format. This patch makes all of the following git-show commands work in the git source tree (not just the first): % cd xdiff % git-show v1.5.2-rc0:xdiff/xemit.h % git-show v1.5.2-rc0:./xemit.h % git-show v1.5.2-rc0:../sha1_name.c It also adds ent:?string as a synonym for ent:/string . This makes the following changes possible later: ent:/path is an absolute path and ent:path is relative. Signed-off-by: ...
May 4, 8:47 pm 2007
Johannes Schindelin
Re: [PATCH v3] Support ent:relative_path
Hi, NACK. The "?" thing is highly unintuitive, and I still do not think that it is worth the confusion to make Git behave funny on <tree>:<file-name>. Think of the "todo" branch, for example. And this is not even far fetched. In many repositories I have to have separate related, but non-branch HEADs. For example, I track some projects with custom scripts. These scripts do _not_ belong into that branch. However, they are related, so I store them in the same repository. Pl...
May 4, 9:29 pm 2007
Junio C Hamano
Re: [PATCH v3] Support ent:relative_path
I said I won't talk about it until 1.5.2 final, but you forced I am not sure if there is anything to answer on this one. When you are talking to a bare-repository, your place relative to the root of the working tree is clearly undefined, and it is natural that "<tree-ish>:./<path>", "<tree-ish>:/<path>" and "<tree-ish>:<path>" cannot mean anything but relative to the root of the tree-ish. "<tree-ish>:../<path>" is obviously nonsense. So it does ...
May 4, 11:38 pm 2007
Shawn O. Pearce
Re: [PATCH v3] Support ent:relative_path
Double ACK. I'm in complete agreement with every point Dscho has made in this thread, even if I haven't quoted it. ;-) I *really* do not want to see "<tree-ish>:<path>" to mean include the current prefix, *especially* when a bare repository is involved. I often either do ad-hoc git-show lines against bare repositories, or have scripts that depend on this existing absolute path behavior. I'd like to see those not break. ;-) Since "." and ".." should not be valid names in any tre...
May 4, 11:30 pm 2007
Yann Dirson
[StGIT RFC PATCH] Activate rename detection by default.
This patch uses -M when generating diffs, which then looks fine, just like any other git-generated diff. While I was at it, I also added -M when calling "stg files" or "stg status". While we need that for completeness, we currently just display the raw git-diff-tree output, and it may break some scripts. We may also want to make it more human-readable (not sure how, esp. if we want to remain machine-parsable). It also raises the issue of whether to activate this by default or not (mostly in s...
May 4, 7:54 pm 2007
Jakub Narebski May 4, 7:36 pm 2007
Junio C Hamano
Re: [PATCH] Support ent:relative_path
That's right (and Dscho is also). "v1.5.1:git.c" IS "git.c that appears at the toplevel of v1.5.1's tree." Ok, for now let's forget about this relative stuff. -
May 4, 8:04 pm 2007
Dana How
Re: [PATCH] Support ent:relative_path
Hmm, most of the work I do in the parts of our perforce repository I want to convert to git is far enough down that the paths have 6 in-repo path components. I don't want to type all those when I want to fetch an older version with git-show. Everything I do is relative. In fact, I think perforce supports typing absolute paths, (using an 8-character prefix!) but I have never used it, nor would I if it were shorter. -- Dana L. How danahow@gmail.com +1 650 804 5991 cell -
May 4, 8:52 pm 2007
Junio C Hamano
Re: [PATCH] Support ent:relative_path
The key word in my statement is "for now". I simply declared that I do not want to think about it further until 1.5.2 final, that's all. I am not opposed to give an escape hatch for your problem; I am quite in favor of that, and I think Alex/J6t's "./" syntax is a reasonable compromise. -
May 4, 9:15 pm 2007
Jakub Narebski
Re: [PATCH] Support ent:relative_path
I think the consensus is to use <tree-ish>:./<relative-path> for relative paths, and <tree-ish>:<path> for absolute (well, in the meaning that it counts from top of _tree-ish_, and tree-ish needs not to be top tree / commit tree). And I think 6 in-repo path components means not very well thought directory hierarchy, I think... -- Jakub Narebski Poland -
May 4, 9:06 pm 2007
Jakub Narebski May 4, 7:22 pm 2007
Yann Dirson
[RFC PATCH] Rename "bury" back to "sink".
Signed-off-by: Yann Dirson <ydirson@altern.org> --- Well, it looks like the voices we heard on this naming issue were quite equally cast towards each of the 2 name. Let my vote be to get back to "sink", so the user can easily pair the command with "float". I expect that any previously-silent majoity prefering "bury" will talk now, before Catalin decides if he wants this patch in the next release :) Oh, this patch reminds me we still have to activate rename detection... Documentat...
May 4, 6:53 pm 2007
Jakub Narebski
[PATCH] diff format documentation: describe raw combined dif...
Add description of raw combined diff format to diff-formats.txt, as "diff format for merges" section, before "Generating patches..." section. Signed-off-by: Jakub Narebski <jnareb@gmail.com> --- The description of raw combined diff format is based testing the output, and on what I remember on discussion regarding raw format: the lack of "score" number (although it should be fairly easy to add it), and path only for "dst". See for example: $ git diff-tree -M -c --raw c182ec90d824168cfb704...
May 4, 6:48 pm 2007
Alex Riesen
[PATCH] Small correction in reading of commit headers
Check if a line of the header has enough characters to possibly contain the requested prefix. Signed-off-by: Alex Riesen <raa.lkml@gmail.com> --- Noticed by debugging git-log crash in broken repos with missing packs. It happened to be up in backtrace. At the moment the optimization is actually a slow down: no line in the header is shorter than the only key this function is ever asked for: encoding. But, in case the function ever gets asked for something longer, the old condition is just ...
May 4, 5:51 pm 2007
Carl Worth
[PATCH] Mention version 1.5.1 in tutorial and user-manual
Most other documentation will frequently be read from an installation of git so will naturally be associated with the installed version. But these two documents in particular are often read from web pages while users are still exploring git. It's important to mention version 1.5.1 since these documents provide example commands that won't work with previous versions of git. --- This really tripped up a recent friend who tried to go through the tutorial on the web page while following along with...
May 4, 2:27 pm 2007
Junio C Hamano
Re: [PATCH] Support ent:relative_path
I think these feel more or less natural (except that we do not say ":/fullpath" and instead say ":fullpath" which is unfortunate). In the hindsight, if we had the perfect vision into the future, we would have made <path> relative to where you are when we initially did "<something>:<path>", with obvious semantics for things like "<something>:../<path>" and "<something>:/<path>". We didn't. Further, we made a mistake to make :/ to mean something complet...
May 4, 1:17 pm 2007
Alex Riesen
Re: [PATCH] Support ent:relative_path
Still don't like the feature. It makes things special: suddenly we have to be careful about not having files with a "?" as their first symbol (well, scripts always can prepend "./" or "/") And it is hard to use: only prefix, must be unambiguous and is I like the plan. -
May 4, 4:21 pm 2007
Johannes Schindelin
Re: [PATCH] Support ent:relative_path
Hi, FWIW I still find that unintuitive. I know "<something>:<path>" from ssh, and there it does not change meaning depending on where I am. IMHO in most cases you want to use git-diff anyway, which _does_ honour the current relative path. Ciao, Dscho -
May 4, 3:06 pm 2007
Junio C Hamano
Re: [PATCH] Support ent:relative_path
There, its meaning is relative to where you are, namely "$HOME". -
May 4, 3:22 pm 2007
Johannes Schindelin
Re: [PATCH] Support ent:relative_path
Hi, No, it is relative to where I am _at the other end_. If I "cd /tmp", it still is relative to $HOME. Now, what you want to do is changing the meaning of v1.5.1:Makefile, depending if you "cd Documentation/"ed or not. For me, "v1.5.1:" means something similar to ssh: it is a distant revision. It is not a complete filesystem. I think of revisions as something more general than a directory, but less general than a filesystem. And thus, it makes perfect sense to me that "v1.5.1:Makefile"...
May 4, 3:31 pm 2007
Junio C Hamano
Re: [PATCH] Support ent:relative_path
I see merits in both sides' arguments. Saying "path out of THIS version" anchors your mindset at the top of that version, so in that sense v1.5.1:Makefile should ... don't you expect "git show HEAD@{yesterday}:git.txt" while in Documentation/ subdirectory to work? I wonder if the current alternative "git show HEAD@{yesterday}:Documentation/git.txt" a bit unintuitive. -
May 4, 3:38 pm 2007
Johannes Schindelin
Re: [PATCH] Support ent:relative_path
Hi, Actually, no. I expect "git diff HEAD@{yesterday} git.txt" to work fine, and "git show HEAD@{yesterday}:git.c" also, both when in Documentation/, because I expect "git show HEAD@{yesterday}:git.c" to work _also_ when I set GIT_DIR=/path/to/my/bare-repo.git/ before that, while I do not expect the call to git-diff to work (for obvious reasons). Ciao, Dscho -
May 4, 3:42 pm 2007
Dana How
Re: [PATCH] Support ent:relative_path
I will resubmit the patch following Junio's plan. It will include the "1.6.0" features but disabled. I would just request that we expedite, if possible, at least the later switch from "<something>:/<string>" to "<something>:/<fullpath>", since with the patch _and_ the latter behavior enabled, scripts can be updated to always insert "./" or "/" and their intent will always be clear. Thanks, -- Dana L. How danahow@gmail.com +1 650 804 5991 cell -
May 4, 2:23 pm 2007
Johannes Sixt
Re: FFmpeg considering GIT
In the history? Yes. With svn cp you actually create this "blame" history: * -- * -- G -- B \ ----- G* -- 1 -- 2 -- 3 where G* is a new revision, but since it is otherwise identical to G, it does not introduce new blame-able lines. -- Hannes -
May 4, 12:09 pm 2007
Florian Weimer
Re: FFmpeg considering GIT
With GIT, you could create: * -- * -- G --- B \ \ ---- 1 -- 2 -- 3 Or perhaps : * -- * -- G --- B \ \ ---- G* -- 1 -- 2 -- 3 How do the history viewers handle this situation? -
May 4, 1:23 pm 2007
Gerrit Pape
[PATCH] git-commit -f <file>: take message from file, ...
Change (undocumented) git commit -f option from a synonym for git-commit -F to "Take the commit message from the given file, and remove the file upon successful commit". git-revert and git-cherry-pick should make use of this to properly cleanup the automatically created ./.msg file. Signed-off-by: Gerrit Pape <pape@smarden.org> --- Documentation/git-commit.txt | 7 ++++--- git-commit.sh | 25 +++++++++++++++++++++++-- 2 files changed, 27 insertions(+), 5 deletions(-) ...
May 4, 10:30 am 2007
Gerrit Pape
[PATCH] Have git-revert, git-cherry-pick cleanup ./.msg upon...
git-revert and git-cherry-pick left behind the commit message file ./.msg, have them use the -f option to git-commit to properly cleanup the automatically created file. Signed-off-by: Gerrit Pape <pape@smarden.org> --- builtin-revert.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/builtin-revert.c b/builtin-revert.c index 4ba0ee6..9acdf47 100644 --- a/builtin-revert.c +++ b/builtin-revert.c @@ -376,10 +376,10 @@ static int revert_or_cherry_pick(int argc, co...
May 4, 10:32 am 2007
Shawn O. Pearce
Re: [PATCH] Have git-revert, git-cherry-pick cleanup ./.msg ...
I'm actually sort of against changing the behavior of git-commit -f to mean "delete the file". We never did that before. Users might get surprised when their file goes away! What about this change instead? We make cherry-pick/revert use the same temporary file as merge, which is under .git/ (something Alex mentioned he wanted). I think the use of ".msg" in cherry-pick/revert has always just been a bug, and not a feature, so I'm really not against changing things around like this. diff --...
May 4, 11:46 pm 2007
Alex Riesen
Re: [PATCH] Have git-revert, git-cherry-pick cleanup ./.msg ...
Could we also have the files in $GIT_DIR instead of in working directory? -
May 4, 11:28 am 2007
Michael Niedermayer
Re: FFmpeg considering GIT
Petr Baudis <pasky <at> suse.cz> writes: well, my example above was exagerated, noone ever reindented the whole ffmpeg or checked in a old version over HEAD. what did and does occasionally happen is that people check in several things at once (like a 100k reindenton mixed with various functional changes) for these we currently copy the last good version of the affected files over the current one with svn cp and then apply the changes in nicely split manner. (possibly without the reinden...
May 4, 9:46 am 2007
Carl Worth
Re: FFmpeg considering GIT
That sounds like an opportunity to educate your contributors a bit on what good commits should look like. So I think this is more a social issue than a technical issue, (but git has some technical means that make it much easier to address the social issues). Your description above makes an assumption that there is a single central repository that multiple people push changes into, (which is really the only way to organize a project with svn or cvs). And with those systems all you get is a bit tha...
May 4, 2:17 pm 2007
Michael Niedermayer
Re: FFmpeg considering GIT
Hi we have a nice svn policy which explains that, also people wont receive write access without having submitted a few clean patches first so i dont know if more education would really help, the problems are IMHO rather caused by a mix of lazyness, arrogance and plain oversight but please dont missunderstand, these problems are not that common, its yes i think so too, the added push after commit wont stop a bad commit yes, id like to switch ffmpeg to git or mercurial as that seems like a goo...
May 4, 4:24 pm 2007
Johan Herland
Re: FFmpeg considering GIT
It's also used in an example in the User Manual (Chapter 1. Git Quick=20 Start -- Exploring history). I was also surprised that it wasn't=20 mentioned in the git-log manual page. =2E..Johan =2D-=20 Johan Herland, <johan@herland.net> www.herland.net
May 4, 2:25 pm 2007
Nicolas Pitre
Re: FFmpeg considering GIT
A big difference between git and svn is that git allows you to commit your changes individually to your local repository before pushing them out to the world. With svn you make your changes visible to the world as soon as you commit something, including the commit screwups. With Git you always have the opportunity to look at your commits and test them all together before pushing which should make commit mistakes obvious before they leave your machine. If a mistake happened in one of those...
May 4, 12:40 pm 2007
Andy Parkins
Re: FFmpeg considering GIT
I might be misunderstanding, but doesn't that leave the "bad" commit in the history? * -- * -- G -- B -- !B -- 1 -- 2 -- 3 B is the bad commit; !B would be the result of the svn cp from the previous known-good revision, "G"; then 1, 2, and 3 would be the correctly split version of "B". Have I correctly understood? If so - git would have no trouble at all emulating that. !B would actually be easier to create because you could use git-revert to automatically create the inverse of B. I...
May 4, 11:53 am 2007
Sven Verdoolaege
Initial support for cloning submodules
From: Sven Verdoolaege <skimo@kotnet.org> This patch series implements a mechanism for cloning submodules. Each submodule is specified by a 'submodule.<submodule>.url' configuration option, e.g., bash-3.00$ ./git-config --remote=http://www.liacs.nl/~sverdool/isa.git --get-regexp 'submodule\..*\.url' submodule.cloog.url /home/sverdool/public_html/cloog.git submodule.cloog.url http://www.liacs.nl/~sverdool/cloog.git git-clone will use the first url that works. E.g., a git clone -...
May 4, 6:49 am 2007
Sven Verdoolaege
[PATCH] git-config: add --remote option for reading config f...
From: Sven Verdoolaege <skimo@kotnet.org> Signed-off-by: Sven Verdoolaege <skimo@kotnet.org> --- Documentation/git-config.txt | 33 +++++++++++++++++++++--------- builtin-config.c | 44 ++++++++++++++++++++++++++++++++--------- cache.h | 1 + config.c | 26 ++++++++++++++++++++++++ 4 files changed, 84 insertions(+), 20 deletions(-) diff --git a/Documentation/git-config.txt b/Documentation/git-config.txt index 280ef20..76...
May 4, 6:49 am 2007
Sven Verdoolaege
[PATCH] git-config: read remote config files over HTTP
From: Sven Verdoolaege <skimo@kotnet.org> Signed-off-by: Sven Verdoolaege <skimo@kotnet.org> --- Makefile | 6 +++++- config.c | 14 ++++++++++++++ http.c | 10 ++++++++-- http_config.h | 1 + http_config_curl.c | 49 +++++++++++++++++++++++++++++++++++++++++++++++++ http_config_none.c | 6 ++++++ 6 files changed, 83 insertions(+), 3 deletions(-) create mode 100644 http_config.h create mode 100644 http_config_curl.c create mod...
May 4, 6:49 am 2007
Sven Verdoolaege
[PATCH] git-clone: add --submodules for cloning submodules
From: Sven Verdoolaege <skimo@kotnet.org> When the --submodules option is specified, git-clone will search for submodule.<submodule>.url options in the remote configuration and clone each submodule using the first url that it can use from the local site. The submodules are currently not checked out. Signed-off-by: Sven Verdoolaege <skimo@kotnet.org> --- Documentation/config.txt | 3 ++ Documentation/git-clone.txt | 6 +++- git-clone.sh | 68 ++++++...
May 4, 6:49 am 2007
Sven Verdoolaege
[PATCH] Add dump-config
From: Sven Verdoolaege <skimo@kotnet.org> This command dumps the config of a repository and will be used to read config options from a remote site. Signed-off-by: Sven Verdoolaege <skimo@kotnet.org> --- .gitignore | 1 + Documentation/cmd-list.perl | 1 + Documentation/git-dump-config.txt | 37 +++++++++++++++++++++++++++++++++++++ Makefile | 1 + daemon.c | 7 +++++++ dump-config.c ...
May 4, 6:49 am 2007
Sven Verdoolaege
[PATCH] http.h: make fill_active_slots a function pointer
From: Sven Verdoolaege <skimo@kotnet.org> This allows us to use the methods provided by http.c from within libgit, in particular config.c. Signed-off-by: Sven Verdoolaege <skimo@kotnet.org> --- http-fetch.c | 5 ++++- http-push.c | 5 ++++- http.h | 2 +- 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/http-fetch.c b/http-fetch.c index 09baedc..53fb2a9 100644 --- a/http-fetch.c +++ b/http-fetch.c @@ -317,7 +317,7 @@ static void release_object_req...
May 4, 6:49 am 2007
davidk
Re: [git-svn PATCH] Add --no-rebase option to git-svn dcommit
One thing I haven't figured out, although I haven't looked at the code much, is this: When does git-svn do a merge rather than a rebase? How can there ever be a diff? Is this perhaps something that can happen if you use set-tree, because I don't see how it happens with dcommit. -- David Kågedal -
May 4, 5:08 am 2007
Sven Verdoolaege
Initial support for cloning submodules
From: Sven Verdoolaege <skimo@kotnet.org> This patch series implements a mechanism for cloning submodules. Each submodule is specified by a 'submodule.<submodule>.url' configuration option, e.g., bash-3.00$ ./git-config --remote=http://www.liacs.nl/~sverdool/isa.git --get-regexp 'submodule\..*\.url' submodule.cloog.url /home/sverdool/public_html/cloog.git submodule.cloog.url http://www.liacs.nl/~sverdool/cloog.git git-clone will use the first url that works. E.g., a git clone -...
May 4, 6:56 am 2007
Junio C Hamano
Re: Initial support for cloning submodules
The plumbing part looks very good, although I sensed a slight slop toward the end (will comment on individual patches later). I do not like the Porcelain part very much, though. I do not think we would want to add anything new to git-clone. We should lose as much code from git-clone that is common with git-fetch as we can first, and add new features to git-fetch, with possibly passthru options added to git-clone as needed (e.g. a new --submodule option). If you --submodule cloned a remote repo...
May 4, 6:52 pm 2007
Sven Verdoolaege
[PATCH 3/5] http.h: make fill_active_slots a function pointer
From: Sven Verdoolaege <skimo@kotnet.org> This allows us to use the methods provided by http.c from within libgit, in particular config.c. Signed-off-by: Sven Verdoolaege <skimo@kotnet.org> --- http-fetch.c | 5 ++++- http-push.c | 5 ++++- http.h | 2 +- 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/http-fetch.c b/http-fetch.c index 09baedc..53fb2a9 100644 --- a/http-fetch.c +++ b/http-fetch.c @@ -317,7 +317,7 @@ static void release_object_req...
May 4, 6:56 am 2007
Sven Verdoolaege
[PATCH 1/5] Add dump-config
From: Sven Verdoolaege <skimo@kotnet.org> This command dumps the config of a repository and will be used to read config options from a remote site. Signed-off-by: Sven Verdoolaege <skimo@kotnet.org> --- .gitignore | 1 + Documentation/cmd-list.perl | 1 + Documentation/git-dump-config.txt | 37 +++++++++++++++++++++++++++++++++++++ Makefile | 1 + daemon.c | 7 +++++++ dump-config.c ...
May 4, 6:56 am 2007
Sven Verdoolaege
[PATCH 4/5] git-config: read remote config files over HTTP
From: Sven Verdoolaege <skimo@kotnet.org> Signed-off-by: Sven Verdoolaege <skimo@kotnet.org> --- Makefile | 6 +++++- config.c | 14 ++++++++++++++ http.c | 10 ++++++++-- http_config.h | 1 + http_config_curl.c | 49 +++++++++++++++++++++++++++++++++++++++++++++++++ http_config_none.c | 6 ++++++ 6 files changed, 83 insertions(+), 3 deletions(-) create mode 100644 http_config.h create mode 100644 http_config_curl.c create mod...
May 4, 6:56 am 2007
Sven Verdoolaege
[PATCH 5/5] git-clone: add --submodules for cloning submodules
From: Sven Verdoolaege <skimo@kotnet.org> When the --submodules option is specified, git-clone will search for submodule.<submodule>.url options in the remote configuration and clone each submodule using the first url that it can use from the local site. The submodules are currently not checked out. Signed-off-by: Sven Verdoolaege <skimo@kotnet.org> --- Documentation/config.txt | 3 ++ Documentation/git-clone.txt | 6 +++- git-clone.sh | 68 ++++++...
May 4, 6:56 am 2007
Sven Verdoolaege
[PATCH 2/5] git-config: add --remote option for reading conf...
From: Sven Verdoolaege <skimo@kotnet.org> Signed-off-by: Sven Verdoolaege <skimo@kotnet.org> --- Documentation/git-config.txt | 33 +++++++++++++++++++++--------- builtin-config.c | 44 ++++++++++++++++++++++++++++++++--------- cache.h | 1 + config.c | 26 ++++++++++++++++++++++++ 4 files changed, 84 insertions(+), 20 deletions(-) diff --git a/Documentation/git-config.txt b/Documentation/git-config.txt index 280ef20..76...
May 4, 6:56 am 2007
previous daytodaynext day
May 3, 2007May 4, 2007May 5, 2007