Home » Mailing list archives » git » 2007 » April » 6

[PATCH] gitk doesn't handle filenames with space correctly

Previous thread: Re: [PATCH] rename_ref(): only print a warning when config-file update fails by Junio C Hamano on Friday, April 6, 2007 - 5:14 pm. (1 message)

Next thread: [RFC] git pull and importers by Daniel Barkalow on Friday, April 6, 2007 - 7:48 pm. (7 messages)
[view original message]
From: gmane
Subject: [PATCH] gitk doesn't handle filenames with space correctly
Date: Friday, April 6, 2007 - 6:22 pm

Hi,

Here is an attempt to fix gitk such that it can display filenames with
space correctly, in the right column (Patch/Tree). I don't know TCL, so
probably that a better solution exists.

--- gitk.orig	2007-04-07 02:36:05.000000000 +0200
+++ gitk	2007-04-07 03:13:16.000000000 +0200
@@ -4114,8 +4114,7 @@
 
     while {[gets $gtf line] >= 0} {
 	if {[lindex $line 1] ne "blob"} continue
-	set sha1 [lindex $line 2]
-	set fname [lindex $line 3]
+	regexp {^[^ ]+ [^ ]+ ([^ ]+)\t(.*)} $line -> sha1 fname
 	lappend treefilelist($id) $fname
 	lappend treeidlist($id) $sha1
     }
@@ -4324,7 +4323,7 @@
 	}
 	return
     }
-    set file [lindex $line 5]
+    regexp {^[^ ]+ [^ ]+ [^ ]+ [^ ]+ [^ ]+\t(.*)} $line -> file
     lappend treediff $file
 }

-- 
Fr
[ message continues ]
Previous thread: Re: [PATCH] rename_ref(): only print a warning when config-file update fails by Junio C Hamano on Friday, April 6, 2007 - 5:14 pm. (1 message)

Next thread: [RFC] git pull and importers by Daniel Barkalow on Friday, April 6, 2007 - 7:48 pm. (7 messages)