[PATCH 1/5] Introduces for_each_revision() helper

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Luiz Fernando N Capitulino
Date: Thursday, April 26, 2007 - 12:46 pm

This macro may be used to iterate over revisions, so, instead of
doing:

	struct commit *commit;

	...

	prepare_revision_walk(rev);
	while ((commit = get_revision(rev)) != NULL) {
		...
	}

New code should use:

	struct commit *commit;

	...

	for_each_revision(commit, rev) {
		...
	}

 The only disadvantage is that it's something magical, and the fact that
it returns a struct commit is not obvious.

 On the other hand it's documented, has the advantage of making the walking
through revisions easier and can save some lines of code.

Signed-off-by: Luiz Fernando N Capitulino <lcapitulino@mandriva.com.br>
---
 revision.h |   11 +++++++++++
 1 files changed, 11 insertions(+), 0 deletions(-)

diff --git a/revision.h b/revision.h
index cdf94ad..bb6f475 100644
--- a/revision.h
+++ b/revision.h
@@ -133,4 +133,15 @@ extern void add_object(struct object *obj,
 extern void add_pending_object(struct rev_info *revs, struct object *obj, const char *name);
 extern void add_pending_object_with_mode(struct rev_info *revs, struct object *obj, const char *name, unsigned mode);
 
+/* helpers */
+
+/**
+ * for_each_revision	-	iterate over revisions
+ * @commit:	pointer to a commit object returned for each iteration
+ * @rev:	revision pointer
+ */
+#define for_each_revision(commit, rev) \
+	prepare_revision_walk(rev);    \
+	while ((commit = get_revision(rev)) != NULL)
+
 #endif
-- 
1.5.1.1.320.g1cf2

-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH 0/5] RFC: for_each_revision() helper, Luiz Fernando N Capi ..., (Thu Apr 26, 12:46 pm)
[PATCH 1/5] Introduces for_each_revision() helper, Luiz Fernando N Capi ..., (Thu Apr 26, 12:46 pm)
[PATCH 2/5] builtin-fmt-merge-msg.c: Use for_each_revision ..., Luiz Fernando N Capi ..., (Thu Apr 26, 12:46 pm)
[PATCH 3/5] reachable.c: Use for_each_revision() helper, Luiz Fernando N Capi ..., (Thu Apr 26, 12:46 pm)
[PATCH 4/5] builtin-shortlog.c: Use for_each_revision() h ..., Luiz Fernando N Capi ..., (Thu Apr 26, 12:46 pm)
[PATCH 5/5] builtin-log.c: Use for_each_revision() helper, Luiz Fernando N Capi ..., (Thu Apr 26, 12:46 pm)
Re: [PATCH 1/5] Introduces for_each_revision() helper, Andy Whitcroft, (Thu Apr 26, 12:59 pm)
Re: [PATCH 0/5] RFC: for_each_revision() helper, Hermes Trismegisto, (Thu Apr 26, 1:57 pm)
Re: [PATCH 0/5] RFC: for_each_revision() helper, Sam Ravnborg, (Thu Apr 26, 2:05 pm)
Re: [PATCH 1/5] Introduces for_each_revision() helper, Luiz Fernando N. Cap ..., (Thu Apr 26, 2:12 pm)
Re: [PATCH 0/5] RFC: for_each_revision() helper, Luiz Fernando N. Cap ..., (Thu Apr 26, 2:14 pm)
Re: [PATCH 0/5] RFC: for_each_revision() helper, Luiz Fernando N. Cap ..., (Thu Apr 26, 2:17 pm)
Re: [PATCH 0/5] RFC: for_each_revision() helper, Junio C Hamano, (Thu Apr 26, 2:21 pm)
Re: [PATCH 0/5] RFC: for_each_revision() helper, Luiz Fernando N. Cap ..., (Fri Apr 27, 6:21 am)
Re: [PATCH 0/5] RFC: for_each_revision() helper, Junio C Hamano, (Fri Apr 27, 10:13 am)