Re: [PATCH 5/6] Teach "fsck" not to follow subproject links

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Linus Torvalds
Date: Wednesday, April 11, 2007 - 4:53 pm

On Wed, 11 Apr 2007, David Lang wrote:

Well, the thing is, sharing object directories actually makes things 
*harder* to check, rather than easier.

It can be a nice space optimization, and yes, if there really is a lot of 
shared state, it can make it much cheaper to do some of the checks, but 
right now we have absolutely *no* way for fsck to then do the reachability 
check, because there is no way to tell fsck where all the refs are (since 
now the refs come in from multiple repositories!)

So the individual objects get cheaper to fsck (no need to fsck shared 
objects over and over again), but the reachability gets much harder to 
fsck.

It's not an insurmountable problem, or even necessarily a very large one, 
but it boils down to one very basic issue:

 - nobody seems to actually *use* the shared object directory model!

The thing is, with pack-files and alternates directories, a lot of the 
original reasons for shared object directories simply don't exist..

		Linus
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH 0/6] Initial subproject support (RFC?), Linus Torvalds, (Mon Apr 9, 9:12 pm)
[PATCH 3/6] Add 'resolve_gitlink_ref()' helper function, Linus Torvalds, (Mon Apr 9, 9:14 pm)
Re: [PATCH 0/6] Initial subproject support (RFC?), Linus Torvalds, (Mon Apr 9, 9:46 pm)
Re: [PATCH 6/6] Teach core object handling functions about ..., Frank Lichtenheld, (Tue Apr 10, 1:40 am)
Re: [PATCH 0/6] Initial subproject support (RFC?), Alex Riesen, (Tue Apr 10, 6:04 am)
Re: [PATCH 0/6] Initial subproject support (RFC?), Linus Torvalds, (Tue Apr 10, 8:13 am)
Re: [PATCH 0/6] Initial subproject support (RFC?), Alex Riesen, (Tue Apr 10, 8:48 am)
Re: [PATCH 3/6] Add 'resolve_gitlink_ref()' helper function, Josef Weidendorfer, (Tue Apr 10, 8:54 am)
Re: [PATCH 0/6] Initial subproject support (RFC?), Linus Torvalds, (Tue Apr 10, 9:07 am)
Re: [PATCH 6/6] Teach core object handling functions about ..., Josef Weidendorfer, (Tue Apr 10, 9:28 am)
Re: [PATCH 0/6] Initial subproject support (RFC?), Alex Riesen, (Tue Apr 10, 9:43 am)
Re: [PATCH 6/6] Teach core object handling functions about ..., Josef Weidendorfer, (Tue Apr 10, 10:23 am)
Re: [PATCH 6/6] Teach core object handling functions about ..., Josef Weidendorfer, (Tue Apr 10, 12:29 pm)
Re: [PATCH 0/6] Initial subproject support (RFC?), Junio C Hamano, (Tue Apr 10, 12:32 pm)
Re: [PATCH 0/6] Initial subproject support (RFC?), Linus Torvalds, (Tue Apr 10, 1:11 pm)
Re: [PATCH 0/6] Initial subproject support (RFC?), Junio C Hamano, (Tue Apr 10, 1:52 pm)
Re: [PATCH 0/6] Initial subproject support (RFC?), Sam Ravnborg, (Tue Apr 10, 2:02 pm)
Re: [PATCH 0/6] Initial subproject support (RFC?), Nicolas Pitre, (Tue Apr 10, 2:03 pm)
Re: [PATCH 0/6] Initial subproject support (RFC?), Junio C Hamano, (Tue Apr 10, 2:27 pm)
Re: [PATCH 0/6] Initial subproject support (RFC?), Martin Waitz, (Wed Apr 11, 1:32 am)
Re: [PATCH 0/6] Initial subproject support (RFC?), Alex Riesen, (Wed Apr 11, 1:42 am)
Re: [PATCH 0/6] Initial subproject support (RFC?), Martin Waitz, (Wed Apr 11, 1:57 am)
Re: [PATCH 5/6] Teach "fsck" not to follow subproject links, Linus Torvalds, (Wed Apr 11, 4:53 pm)
Re: [PATCH 6/6] Teach core object handling functions about ..., Josef Weidendorfer, (Thu Apr 12, 8:12 am)
Re: [PATCH 0/6] Initial subproject support (RFC?), J. Bruce Fields, (Sun Apr 15, 4:21 pm)