A common problem when cloning over http is that the repo has a symlink for HEAD, and apache refuses to serve symlinks by default. Without this patch, the clone succeeds as a "bare" and "HEADless" clone, but does not give any indication that things have gone wrong. A bare clone that fails to fetch HEAD will still complete "successfully". I'm not sure if that's expected/desired. Is a HEADless repo valid in any situation? Signed-off-by: Martin Langhoff <martin@catalyst.net.nz> --- git-clone.sh | 5 +++++ 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/git-clone.sh b/git-clone.sh index 513b574..ef8cd26 100755 --- a/git-clone.sh +++ b/git-clone.sh @@ -65,6 +65,11 @@ Perhaps git-update-server-info needs to be run there?" rm -fr "$clone_tmp" http_fetch "$1/HEAD" "$GIT_DIR/REMOTE_HEAD" || rm -f "$GIT_DIR/REMOTE_HEAD" + + if test -z "$bare" && test ! -f "$GIT_DIR/REMOTE_HEAD" + then + die "Could not retrieve $1/HEAD - perhaps it is a symlink?" + fi } quiet= -- 1.5.1.106.ga32037 - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
| Cliffe | Re: [RFC 0/5] [TALPA] Intro to a linux interface for on access scanning |
| Amit K. Arora | [RFC] Heads up on sys_fallocate() |
| Bart Van Assche | Integration of SCST in the mainstream Linux kernel |
| Andrew Morton | Re: [RFC/PATCH] Documentation of kernel messages |
| David Miller | [GIT]: Networking |
| Jarek Poplawski | Re: [PATCH] pkt_sched: Destroy gen estimators under rtnl_lock(). |
| Radu Rendec | Endianness problem with u32 classifier hash masks |
| Gerrit Renker | [PATCH 27/37] dccp: Integration of dynamic feature activation - part 2 (server side) |
git: | |
