Re: [PATCH] git-archive: document CWD effect

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: <rene.scharfe@...>
Cc: Andy Parkins <andyparkins@...>, <git@...>, Nick Williams <njw@...>
Date: Tuesday, April 10, 2007 - 5:49 pm

René Scharfe <rene.scharfe@lsrfire.ath.cx> writes:


I do not think it has much to do with "working directory".  The
remote one would most often be bare, and especially the public
ones are so.  I think the issue is if I ask a tarball of this
commit without giving any specific parameters, what should
happen.

And I think most people find it natural if you give them the
whole tree no matter where they start from.

You could:

        $ git archive HEAD -- t/howto

to have a narrowed tarball, and even if you make:

	$ cd t/howto
	$ git archive HEAD

to produce the whole tree, the user can still do:

	$ cd t/howto
        $ git archive HEAD -- .

to get the narrowed tree if the command understands the prefix
it receives from git_setup_directory().

So while I understand when you say this is "another input
method", letting people in a deep directory to abbreviate their
cwd with "." would equally a good input method, and probably
better than the current implementation, which leaves people
without a single way to say "I want the whole tree" without
cd'ing up.

-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
bug in git-archive?, Nick Williams, (Sat Mar 3, 12:07 pm)
Re: [PATCH] git-archive: document CWD effect, Junio C Hamano, (Sun Apr 8, 7:21 pm)
Re: [PATCH] git-archive: document CWD effect, Andy Parkins, (Mon Apr 9, 4:37 pm)
Re: [PATCH] git-archive: document CWD effect, Junio C Hamano, (Tue Apr 10, 5:49 pm)
Re: bug in git-archive?, Johannes Schindelin, (Sat Mar 3, 12:09 pm)