git mailing list

FromSubjectsort iconDate
Julian Phillips
Why are ref_lists sorted?
Having got a C implementation of fetch far enough to be able to tell me that I'm up-to-date (when using git:// and not using remotes or branches files) I thought I'd compare performance with the fetch--tool based version. I was a bit surprised at what I saw. Hot-cache time went from ~30s to ~3s, which didn't seem too bad. However what did puzzle me was where the C version was spending it's time. Being a work in progress it's a bit chatty in places, but there is an up-front delay of just ov...
Mar 18, 11:38 pm 2007
J. Bruce Fields
gitk handling of -- on commandline?
Since I often use "TMP" as a name both for files and branches, I wasn't that suprised recently when gitk TMP complained that "TMP" was ambiguous and asked me to use -- to separate filenames from revisions. I was a bit more surprised when it still did that after I gave it gitk TMP -- I looked through the source code very quickly but it wasn't obvious to me why this was happening. The reverse, gitk -- TMP interestingly doesn't seem to have the same problem. --b. -
Mar 18, 11:36 pm 2007
J. Bruce Fields
[PATCH] glossary: clean up cross-references
From: J. Bruce Fields <bfields@citi.umich.edu> Manual clean-up of cross-references, and also clean up a few definitions (e.g. git-rebase). Signed-off-by: "J. Bruce Fields" <bfields@citi.umich.edu> --- Documentation/glossary.txt | 58 ++++++++++++++++++++++---------------------- 1 files changed, 29 insertions(+), 29 deletions(-) diff --git a/Documentation/glossary.txt b/Documentation/glossary.txt index 82e17db..2465514 100644 --- a/Documentation/glossary.txt +++ b/Documentation...
Mar 18, 11:18 pm 2007
J. Bruce Fields
[PATCH] user-manual: introduce "branch" and "branch head" di...
From: J. Bruce Fields <bfields@citi.umich.edu> I was using "branch" to mean "head", but that's perhaps a little sloppy; so instead start by using the terms "branch head" and "head", while still quickly falling back on "branch", since that's what people actually say more frequently. Also include glossary references on the first uses of "head" and "tag". Signed-off-by: "J. Bruce Fields" <bfields@citi.umich.edu> --- Documentation/user-manual.txt | 43 ++++++++++++++++++++-----------...
Mar 18, 11:18 pm 2007
J. Bruce Fields
glossary and user-manual updates
Also available from: git://linux-nfs.org/~bfields/git.git The main change is just to maintain the glossary manually instead of by the sort_glossary.pl script; includes a subsequent patch to demonstrate the sort of cleanup that allows. --b. -
Mar 18, 11:17 pm 2007
J. Bruce Fields
[PATCH] user-manual: run xsltproc without --nonet option
From: J. Bruce Fields <bfields@citi.umich.edu> The --nonet option prevents xsltproc from going to the network to find anything. But it always tries to find them locally first, so for a user with the necessary docbook stylesheets installed the build will work just fine without xsltproc attempting to use the network; all --nonet does is make it fail rather than falling back on that. That doesn't seem particularly helpful. Signed-off-by: "J. Bruce Fields" <bfields@citi.umich.edu> --- ...
Mar 18, 11:17 pm 2007
J. Bruce Fields
[PATCH] user-manual.txt: fix a tiny typo.
From: Jim Meyering <jim@meyering.net> "file patch" was doubtless intended to be "file path", but "directory name" is clearer. Signed-off-by: Jim Meyering <jim@meyering.net> Signed-off-by: "J. Bruce Fields" <bfields@citi.umich.edu> --- Documentation/user-manual.txt | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/Documentation/user-manual.txt b/Documentation/user-manual.txt index 0919574..773f65e 100644 --- a/Documentation/user-manual.txt +++ b/Docu...
Mar 18, 11:17 pm 2007
J. Bruce Fields
[PATCH] user-manual: Use def_ instead of ref_ for glossary r...
From: J. Bruce Fields <bfields@citi.umich.edu> I'd like to start using references to the glossary in the user manual. The "ref_" prefix for these references seems a little generic; so replace with "def_". Signed-off-by: "J. Bruce Fields" <bfields@citi.umich.edu> --- Documentation/sort_glossary.pl | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Documentation/sort_glossary.pl b/Documentation/sort_glossary.pl index 05dc7b2..4ae6290 100644 --- a/Documentat...
Mar 18, 11:17 pm 2007
J. Bruce Fields
[PATCH] glossary: stop generating automatically
From: J. Bruce Fields <bfields@citi.umich.edu> The sort_glossary.pl script sorts the glossary, checks for duplicates, and automatically adds cross-references. But it's not so hard to do all that by hand, and sometimes the automatic cross-references are a little wrong; so let's run the script one last time and check in its output. Note: to make the output fit better into the user manual I also deleted the acknowledgements at the end, which was maybe a little rude; feel free to object and ...
Mar 18, 11:17 pm 2007
J. Bruce Fields
[PATCH] Make git-send-email aware of Cc: lines.
In the Linux kernel, for example, it's common to include Cc: lines for cases when you want to remember to cc someone on a patch without necessarily claiming they signed off on it. Make git-send-email aware of these. Signed-off-by: "J. Bruce Fields" <bfields@citi.umich.edu> --- Documentation/git-send-email.txt | 3 ++- git-send-email.perl | 8 ++++---- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/Documentation/git-send-email.txt b/Documentation/git-sen...
Mar 18, 9:37 pm 2007
Robin Rosenberg
[PATCH] Fix compare at project level, non-root project
Compare didn't work at the project level when the project wasn't the same as the git working directory, i.e. egit itself. Signed-off-by: Robin Rosenberg <robin.rosenberg@dewire.com> --- .../core/internal/mapping/GitFileRevision.java | 11 ++++++++--- 1 files changed, 8 insertions(+), 3 deletions(-) diff --git a/org.spearce.egit.core/src/org/spearce/egit/core/internal/mapping/GitFileRevision.java b/org.spearce.egit.core/src/org/spearce/egit/core/internal/mapping/GitFileRevision.java ...
Mar 18, 8:19 pm 2007
Jakub Narebski Mar 18, 7:48 pm 2007
Johannes Schindelin
Re: any info getting a birdview of Git and its test suite?
Hi, I have to disagree. Git is substantially more sane than CVS, so that it is actually _simpler_ to learn Git than to unlearn CVS and _then_ learn Git. Ciao, Dscho -
Mar 18, 8:20 pm 2007
Robin Rosenberg Mar 18, 8:28 pm 2007
Jakub Narebski
Re: any info getting a birdview of Git and its test suite?
Well, experience may consist of few days playing with Git. But it is not what I wanted to say. I wanted to say that before doing any work on Git tests one should get to know what SCM is about. By the way, in "more extensive tests" did you want also tests of Git _API_, and not only git commands (porcelain and plumbing)? IIRC the "more tests" proposal for SoC2007 was by you... (And yes, I think that Git has most sane ideas about SCM). -- Jakub Narebski Poland -
Mar 18, 8:26 pm 2007
sbejar
[PATCH] git-fetch: Fix single_force in append_fetch_head
This fixes the single force (+) when fetched with fetch_per_ref. Also use $LF as separator because IFS is $LF. Signed-off-by: Santi Béjar <sbejar@gmail.com> --- git-fetch.sh | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/git-fetch.sh b/git-fetch.sh index a650116..f97263a 100755 --- a/git-fetch.sh +++ b/git-fetch.sh @@ -114,8 +114,8 @@ ls_remote_result=$(git ls-remote $exec "$remote") || append_fetch_head () { flags= - test -n "$verbose" &&am...
Mar 18, 7:16 pm 2007
James Bowes
[PATCH] mergetool: Add support for vimdiff.
Signed-off-by: James Bowes <jbowes@dangerouslyinc.com> --- git-mergetool.sh | 8 +++++--- 1 files changed, 5 insertions(+), 3 deletions(-) diff --git a/git-mergetool.sh b/git-mergetool.sh index 52386a5..563c5c0 100755 --- a/git-mergetool.sh +++ b/git-mergetool.sh @@ -185,9 +185,9 @@ merge_file () { mv -- "$BACKUP" "$path.orig" fi ;; - meld) + meld|vimdiff) touch "$BACKUP" - meld -- "$LOCAL" "$path" "$REMOTE" + $merge_tool -- "$LOCAL" "$path" "$REMOTE"...
Mar 18, 6:28 pm 2007
Theodore Tso
Re: [PATCH] mergetool: Add support for vimdiff.
Hi James, Thanks for adding vimdiff support! One minor nit, which I fixed before applying to my tree: You didn't update git-mergetool.txt and config.txt in the Documentation directory to add "vimdiff" to the list of possible merge resolution tools. Junio, please pull from: git://repo.or.cz/git/mergetool.git - Ted commit 9cec65399d3575774910b21c1cfd762a5e88a245 Author: James Bowes <jbowes@dangerouslyinc.com> Date: Sun Mar 18 22:11:54 2007 -0400 mergetool: Add supp...
Mar 18, 10:18 pm 2007
Linus Torvalds
Set up for better tree diff optimizations
This is mainly just a cleanup patch, and sets up for later changes where the tree-diff.c "interesting()" function can return more than just a yes/no value. In particular, it should be quite possible to say "no subsequent entries in this tree can possibly be interesting any more", and thus allow the callers to short-circuit the tree entirely. In fact, changing the callers to do so is trivial, and is really all this patch really does, because changing "interesting()" itself to say that not...
Mar 18, 6:18 pm 2007
Robin Rosenberg
[PATCH 0/4] Eclipse (EGIT) Structured compare
Now Eclipse can compare two git version at the project level. Thanks to the SHA-1's the compare is very quick. There is some extra cost for version managed archives (zip/jars) as Eclipse insists on comparing the contents of those at the file level too. Not that I mind that. It is useful and cool. (No, it doesn't compare open office documents in any useful manner, unless you happen to have a plugin for it, in which case it might actually work.) Along with this some experiments with caching and a min...
Mar 18, 6:15 pm 2007
Shawn O. Pearce
Re: [PATCH 0/4] Eclipse (EGIT) Structured compare
Thanks for this series. I have applied it and pushed it out, along with a small fix on top. It works nicely, at least the "NG" variant when comparing trees. ;-) The non-NG variant shows the raw tree diff, which is uh, a little uninteresting, unless you are a true core Git hacker... I tested it on a small-ish repository. The history browser works quite nicely once the cache starts to get filled. I don't know how well it works on bigger repositories. ;-) --'da small fix-- From 6c402714c...
Mar 18, 10:21 pm 2007
Robin Rosenberg
[PATCH 4/4] Add support for structured comparison.
With this code we can now compare revisions at project and folder levels, rather than only file level. We use the compare api's that eclipse provide to do the display and detailed compare work, while we do the high level comparisons at the SHA-1 level. A possible downside is that the API:s we use are internal, which could make us version dependent. This code works with both 3.2.x and 3.3M5 versions though. Signed-off-by: Robin Rosenberg <robin.rosenberg@dewire.com> --- org.spearce.egit...
Mar 18, 6:16 pm 2007
Robin Rosenberg
[PATCH 2/4] Rework tree/commit cache
We now use SoftRefernces to hold the value objects and reuse the object id's as cache keys. Seems to work much better, i.e. the gc only throws out stuff from the cache when memory is tight, rather than at the first opportunity. Signed-off-by: Robin Rosenberg <robin.rosenberg@dewire.com> --- .../src/org/spearce/jgit/lib/Repository.java | 30 +++++++++++++++-------- 1 files changed, 20 insertions(+), 10 deletions(-) diff --git a/org.spearce.jgit/src/org/spearce/jgit/lib/Repository...
Mar 18, 6:16 pm 2007
Robin Rosenberg
[PATCH 3/4] Decode message when encoding line is present
Seems we left the newline between the encoding and the rest of the message Signed-off-by: Robin Rosenberg <robin.rosenberg@dewire.com> --- .../src/org/spearce/jgit/lib/Commit.java | 6 ++++-- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/org.spearce.jgit/src/org/spearce/jgit/lib/Commit.java b/org.spearce.jgit/src/org/spearce/jgit/lib/Commit.java index 4356149..c5c65c4 100644 --- a/org.spearce.jgit/src/org/spearce/jgit/lib/Commit.java +++ b/org.spearce.jgit/...
Mar 18, 6:16 pm 2007
Robin Rosenberg
[PATCH 1/4] Cache tree ObjectId's too
The caching part is experimental. We explicitly leave it up to the garbage collector when to recycle git objects. After trying this practically we will se what is best. The upside is that rescanning the history for a certain resource is very quick when data is still in the cache (tens of milliseconds), which is very good for interactivity. When memory is tight we go to disk and fetch the data, which could take a couple of seconds on a large repo. Signed-off-by: Robin Rosenberg <robin.rosenberg@...
Mar 18, 6:15 pm 2007
Jakub Narebski
Re: git push to a non-bare repository
Perhaps it would be for the best. BUT unless you arrange some fancy post-update hook you have two sane choices: * push to bare repository, with 1:1 refs mapping * push to non-bare repository, but with mapping pushed refs on pushee to remotes refs (remote / tracking branches) on remote side. In all other choices there madness lies... ;-) -- Jakub Narebski Warsaw, Poland ShadeHawk on #git -
Mar 18, 6:01 pm 2007
Linus Torvalds
Trivial cleanup of track_tree_refs()
This makes "track_tree_refs()" use the same "tree_entry()" function for counting the entries as it does for actually traversing them a few lines later. Not a biggie, but the reason I care was that this was the only user of "update_tree_entry()" that didn't actually *extract* the tree entry first. It doesn't matter as things stand now, but it meant that a separate test-patch I had that avoided a few more "strlen()" calls by just saving the entry length in the entry descriptor and using it d...
Mar 18, 4:38 pm 2007
Johannes Sixt
[PATCH] Teach git-remote to list pushed branches.
The configured refspecs are printed almost verbatim, i.e. both the local and the remote branch name separated by a colon are printed; only the prefix 'refs/heads/' is removed, like this: Local branch(es) pushed with 'git push' master refs/tags/*:refs/tags/* next:next Signed-off-by: Johannes Sixt <johannes.sixt@telecom.at> --- [Resent; I don't see the patch applied nor were there any comments.] The hunk that reads the 'Push'es from the .git/remotes file is taken almost verbatim ...
Mar 18, 4:34 pm 2007
Junio C Hamano
Re: [PATCH] Teach git-remote to list pushed branches.
Maybe while waiting for application nor comments you could have tested and removed that comment? -
Mar 18, 4:37 pm 2007
Jim Meyering
[PATCH] user-manual.txt: fix a tiny typo.
"file patch" was doubtless intended to be "file path", but "directory name" is clearer. Signed-off-by: Jim Meyering <jim@meyering.net> --- Documentation/user-manual.txt | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/Documentation/user-manual.txt b/Documentation/user-manual.txt index d7b227e..72668f0 100644 --- a/Documentation/user-manual.txt +++ b/Documentation/user-manual.txt @@ -1698,7 +1698,7 @@ then you can just pull changes from each other's repositories...
Mar 18, 1:39 pm 2007
Matthieu Moy
git push to a non-bare repository
Hi, I have a repository with a working tree on a machine A, did a clone to another machine B and commited there locally. I want my changes to get back into the first repository, so I did a "push". The new commit is in the history, I can see it with "git log", but the modifications are not in the working tree. This time, it's OK: I didn't have any uncommited modifications on A, so I just did a "git reset --hard HEAD" there. But if I had some uncommited changes, "git reset --hard HEAD" means ...
Mar 18, 1:31 pm 2007
Theodore Tso
Re: git push to a non-bare repository
The general answer (which you've already received) is to tell folks is to simply don't use "git push" to remote trees; basically, if you ever have a non-bare repository, it doesn't do what you expect, and it will leave the novice user horribly confused. A much better answer is to simply go back to machine A, and pull from machine B. I was exploring though to see if there was anything we could do better, and so I used my standard test repository of the GNU Hello, world program, and did the follow...
Mar 18, 10:00 pm 2007
Junio C Hamano
Re: git push to a non-bare repository
Doesn't update hook get pre- and post- commit object name? -
Mar 18, 9:55 pm 2007
Shawn O. Pearce
Re: git push to a non-bare repository
Yes, and the same is true in the new post-receive hook. -- Shawn. -
Mar 18, 10:21 pm 2007
Theodore Tso
Re: git push to a non-bare repository
In my comments, I was observing that *after* the push had succeeded, there was no way to find the commit-id-before-the-push, since neither the reflog nor ORIG_HEAD is getting updated. Is there a good reason why not? Would you accept a patch which caused the reflog and possibly ORIG_HEAD to be updated on the remote side of the push? When I was talking about a hook to enforce the BitKeeper semantics, the question is whether we have enough to enforce the following: * Only accept the push if i...
Mar 18, 10:47 pm 2007
Shawn O. Pearce
Re: git push to a non-bare repository
The reflog does update if the log file exists during a push (err, actually during receive-pack). Or if core.logAllRefUpdates is set to true. Now this isn't the default in a bare repository, but it should be the default in a repository with a working directory. Yes, the update hook can detect this. Actually receive-pack by default rejects *all* non-fast-forward pushes, even if the client The update hook could also perform this check; test if the ref being updated is the current branch, and if...
Mar 18, 10:56 pm 2007
Theodore Tso
Re: git push to a non-bare repository
Ah, so that's controlled by receive.denyNonFastForwards, right? Cool, I missed that. Thanks!! Documentation/config.txt doesn't say it defaults to true, but from What git-runstatus will allow me to do is to abort if there are any local modifications, regardless of whether or not they would conflict with the working tree update. The key phrase in my criteria was no locally modified files "THAT WOULD BE AFFECTED". What I could do with BitKeeper is that I could modify some file like schedule....
Mar 18, 11:33 pm 2007
Shawn O. Pearce
Re: git push to a non-bare repository
Ah, my bad, it defaults to false: static int deny_non_fast_forwards = 0; I should have known better, as I run a 1.5.x (aka 'next') server for a workgroup and I never have that set, but use instead a complex git-diff $old $new | git-apply --index ? If the patch does not apply, nothing gets updated. If it does apply, the index is also updated and stat data updated. OK, it doesn't quite handle every case, as sometimes a patch will reject but the internal 3-way merge from xdiff that is ...
Mar 18, 11:47 pm 2007
Theodore Tso
Re: git push to a non-bare repository
So I dug a little more deeply, and the problem is that the reflog for master was getting updated, but not the reflog for HEAD, and that's what "git reflog" was showing --- hence my confusion. What are the rules for when HEAD's reflog should get updated, and is this documented anywhere in the man pages? - Ted Script started on Sun 18 Mar 2007 11:11:59 PM EDT Top-level shell (parent script) Using ssh-agent pid 7679 <tytso@candygram> {/home/tytso/talks/dscm/git} 1% cp -r test1 t...
Mar 18, 11:21 pm 2007
Shawn O. Pearce
Re: git push to a non-bare repository
It is buried down in write_ref_sha1 (in refs.c). The rule is if the name of the ref given to us for update does not match the actual ref we are about to change, we log to both the original ref name given and the actual ref name. This handles the case of HEAD being a symref to some actual branch; we update the HEAD reflog and the actual branch reflog whenever someone updates HEAD. Which is what we are usually doing from tools like git-checkout. receive-pack isn't updating the HEAD reflog as i...
Mar 18, 11:53 pm 2007
Junio C Hamano
Re: git push to a non-bare repository
Actually, there are no such "design choices". That's entirely up to the repository owners to arrange post-update hook, to allow you to do anything you want. The default is not to encourage people (who do not know what they are doing anyway) to push into non-bare repository. -
Mar 18, 3:47 pm 2007
Sam Vilain
Re: git push to a non-bare repository
Maybe it's worth making it an error (that can be forced) if you're pushing to the head that's checked out in a non-bare repository ? It's pretty nasty behaviour for people used to darcs / bzr et al. Sam. -
Mar 18, 5:51 pm 2007
Junio C Hamano
Re: git push to a non-bare repository
We talked about that in the past on the list. No. -
Mar 18, 6:18 pm 2007
James Bowes
[PATCH] mergetool: Use merge.tool config option.
If no merge program was supplied on the commandline, and the config option merge.tool was set to a valid value, then mergetool would unset $merge_tool and instead try to find an installed merge program. This patch removes the code that unset $merge_tool, so the merge.tool config option will always be used, if set. Signed-off-by: James Bowes <jbowes@dangerouslyinc.com> --- git-mergetool.sh | 4 ---- 1 files changed, 0 insertions(+), 4 deletions(-) diff --git a/git-mergetool.sh b/git-me...
Mar 18, 12:13 pm 2007
Junio C Hamano
Re: [PATCH] mergetool: Use merge.tool config option.
The problem description looks correct, but I think the original meant to reject configuration value for merge_tool that is not IOW, wouldn't this be a better way? if test -z "$merge_tool" then merge_tool=`git-config merge.tool` case "$merge_tool" in kdiff3 | tkdiff | xxdiff | meld | emerge) ;; # happy *) echo >&2 "We do not know how to drive $merge_tool" ...
Mar 18, 8:18 pm 2007
James Bowes
Re: [PATCH] mergetool: Use merge.tool config option.
There's a bit later on in mergetool that errors out if you have provided an unknown merge program (either via the command line or through your config). The command line and the config ways should probably behave the same, eh? If so, the case block should be brought fi case "$merge_tool" in kdiff3 | tkdiff | xxdiff | meld | emerge) ;; # happy *) echo >&2 "We do not know how to drive $merge_tool" ...
Mar 18, 9:11 pm 2007
Theodore Tso
Re: [PATCH] mergetool: Use merge.tool config option.
It seemed to me that Junio's suggestion made the most amount of sense, but I tinkered with the with the warning message to make it clear that the cause of the warning was a bugus tool in the merge.tool configuration parameter. This has also been pushed out to git://repo.or.cz/git/mergetool.git Junio, please pull if you approve... - Ted commit d6678c28e30e836449092a2917d4b0bd6254b06c Author: Theodore Ts'o <tytso@mit.edu> Date: Sun Mar 18 22:30:10 2007 -0400 mergetool: pri...
Mar 18, 10:32 pm 2007
Raimund Bauer
[wishlist] graphical diff
I think it would be really helpful (especially for newbies like me) to have an option like git diff --gui [revisions] <singe path spec> to fire up a graphical diff viewer (similar to what git-mergetool does). Another good place to start a graphical diff from is probably gitk from a context-menu for the changed files in the lower right pane. Thoughts? -- best regards Ray -
Mar 18, 9:16 am 2007
Christian MICHON
Re: [wishlist] graphical diff
gvimdiff is pretty cool. Have a look at the archives, I asked recently how to perform this, and a few solutions came out (you need a sane shell, and the abilities to create fifos). I'd use it everyday if a true vim/gvim explorer plugin would exist (and it's hard to code!). -- Christian -
Mar 18, 5:39 pm 2007
Robin Rosenberg
Re: [wishlist] graphical diff
Fine, except it is not likely to be my favourite gui. But you don't have to wait, you can get a gui easily today. Pipe the output to another tool. Kompare is such a tool which can take a patch and compare it. It does not have to a single file. You can diff two trees and compare. You'll need at kdesdk version 3.5.5 (or 3.5.6) or the patch in http://bugs.kde.org/show_bug.cgi?id=131717 for kompare to display git diffs. git diff HEAD^..HEAD | kompare - As for other gui's I don't know which ones...
Mar 18, 11:06 am 2007
previous daytodaynext day
March 17, 2007March 18, 2007March 19, 2007