Re: [PATCH 3/2] Avoid unnecessary strlen() calls

view
thread

!MAILaRCHIVE_VOTE_RePLACE

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

[view in full thread]

From: Junio C Hamano <junkio@...>

To: Linus Torvalds <torvalds@...>

Cc: Nicolas Pitre <nico@...>, Morten Welinder <mwelinder@...>, Git Mailing List <git@...>

Subject: Re: [PATCH 3/2] Avoid unnecessary strlen() calls

Date: Sunday, March 18, 2007 - 5:45 am

Linus Torvalds <torvalds@linux-foundation.org> writes:

quoted text> This shaves off another ~5-10% from some loads that are very tree 
> intensive (notably doing commit filtering by a pathspec).
>
> Signed-off-by: Linus Torvalds  <torvalds@linux-foundation.org>"

With your 256-entry cache, Nico's reusing objects out of delta
base cache, and this strlen() patch

	git blame -C block/ll_rw_blk.c

gets these numbers:

(v1.5.0)
14.71user 0.26system 0:15.07elapsed 99%CPU (0avgtext+0avgdata 0maxresident)k
0inputs+0outputs (0major+93622minor)pagefaults 0swaps

(master + three patches)
8.94user 0.14system 0:09.10elapsed 99%CPU (0avgtext+0avgdata 0maxresident)k
0inputs+0outputs (0major+40075minor)pagefaults 0swaps

Just for fun, these are the same for the kernel history with tglx-history 
repository's history grafted behind it, i.e. with this grafts file:

$ cat .git/info/grafts
1da177e4c3f41524e886b7f1b8a0c1fc7321cac2 e7e173af42dbf37b1d946f9ee00219cb3b2bea6a

(v1.5.0)
73.80user 2.57system 1:16.40elapsed 99%CPU (0avgtext+0avgdata 0maxresident)k
0inputs+0outputs (0major+773077minor)pagefaults 0swaps

(master + three patches)
65.14user 0.40system 1:05.55elapsed 99%CPU (0avgtext+0avgdata 0maxresident)k
0inputs+0outputs (0major+125052minor)pagefaults 0swaps

In either case, it is showing drastic reduction of minor faults.

-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:

cleaner/better zlib sources?, Linus Torvalds, (Thu Mar 15, 9:04 pm)

Re: cleaner/better zlib sources?, Davide Libenzi, (Thu Mar 15, 9:33 pm)

Re: cleaner/better zlib sources?, Davide Libenzi, (Thu Mar 15, 10:06 pm)

Re: cleaner/better zlib sources?, Jeff Garzik, (Thu Mar 15, 9:11 pm)

Re: cleaner/better zlib sources?, Linus Torvalds, (Thu Mar 15, 9:46 pm)

Re: cleaner/better zlib sources?, Linus Torvalds, (Thu Mar 15, 9:54 pm)

Re: cleaner/better zlib sources?, Davide Libenzi, (Thu Mar 15, 10:43 pm)

Re: cleaner/better zlib sources?, Linus Torvalds, (Thu Mar 15, 10:56 pm)

Re: cleaner/better zlib sources?, Davide Libenzi, (Thu Mar 15, 11:16 pm)

Re: cleaner/better zlib sources?, Linus Torvalds, (Fri Mar 16, 12:21 pm)

Re: cleaner/better zlib sources?, Nicolas Pitre, (Fri Mar 16, 1:06 pm)

Re: cleaner/better zlib sources?, Linus Torvalds, (Fri Mar 16, 1:51 pm)

Re: cleaner/better zlib sources?, Nicolas Pitre, (Fri Mar 16, 2:09 pm)

Re: cleaner/better zlib sources?, Jeff Garzik, (Fri Mar 16, 12:35 pm)

Re: cleaner/better zlib sources?, Shawn O. Pearce, (Fri Mar 16, 7:22 pm)

Re: cleaner/better zlib sources?, Nicolas Pitre, (Fri Mar 16, 1:12 pm)

Re: cleaner/better zlib sources?, Matt Mackall, (Fri Mar 16, 12:42 pm)

Re: cleaner/better zlib sources?, Linus Torvalds, (Fri Mar 16, 12:51 pm)

Re: cleaner/better zlib sources?, Davide Libenzi, (Fri Mar 16, 12:24 pm)

Re: cleaner/better zlib sources?, Linus Torvalds, (Fri Mar 16, 12:35 pm)

Re: cleaner/better zlib sources?, Davide Libenzi, (Fri Mar 16, 3:21 pm)

Re: cleaner/better zlib sources?, Linus Torvalds, (Fri Mar 16, 8:01 pm)

Re: cleaner/better zlib sources?, Linus Torvalds, (Fri Mar 16, 9:11 pm)

Re: cleaner/better zlib sources?, Nicolas Pitre, (Fri Mar 16, 11:28 pm)

Re: cleaner/better zlib sources?, Linus Torvalds, (Sat Mar 17, 1:55 pm)

Re: cleaner/better zlib sources?, Linus Torvalds, (Sat Mar 17, 3:40 pm)

[PATCH 2/2] Implement a simple delta_base cache, Linus Torvalds, (Sat Mar 17, 3:44 pm)

Re: [PATCH 2/2] Implement a simple delta_base cache, Linus Torvalds, (Sat Mar 17, 6:44 pm)

Re: [PATCH 2/2] Implement a simple delta_base cache, Linus Torvalds, (Sat Mar 17, 5:45 pm)

Re: [PATCH 2/2] Implement a simple delta_base cache, Morten Welinder, (Sat Mar 17, 9:14 pm)

Re: [PATCH 2/2] Implement a simple delta_base cache, Avi Kivity, (Sun Mar 18, 2:28 am)

Re: [PATCH 2/2] Implement a simple delta_base cache, Linus Torvalds, (Sat Mar 17, 9:29 pm)

Re: [PATCH 2/2] Implement a simple delta_base cache, Linus Torvalds, (Sat Mar 17, 9:44 pm)

Re: [PATCH 2/2] Implement a simple delta_base cache, Nicolas Pitre, (Sat Mar 17, 9:38 pm)

Re: [PATCH 2/2] Implement a simple delta_base cache, Linus Torvalds, (Sat Mar 17, 9:55 pm)

Re: [PATCH 2/2] Implement a simple delta_base cache, Nicolas Pitre, (Sat Mar 17, 10:03 pm)

Re: [PATCH 2/2] Implement a simple delta_base cache, Linus Torvalds, (Sat Mar 17, 10:20 pm)

[PATCH 3/2] Avoid unnecessary strlen() calls, Linus Torvalds, (Sat Mar 17, 11:06 pm)

Re: [PATCH 3/2] Avoid unnecessary strlen() calls, Junio C Hamano, (Sun Mar 18, 5:45 am)

Re: [PATCH 3/2] Avoid unnecessary strlen() calls, Linus Torvalds, (Sun Mar 18, 11:54 am)

Re: [PATCH 3/2] Avoid unnecessary strlen() calls, Junio C Hamano, (Mon Mar 19, 11:16 pm)

Re: [PATCH 3/2] Avoid unnecessary strlen() calls, Linus Torvalds, (Tue Mar 20, 12:31 am)

Re: [PATCH 3/2] Avoid unnecessary strlen() calls, Shawn O. Pearce, (Tue Mar 20, 12:39 am)

Re: [PATCH 3/2] Avoid unnecessary strlen() calls, Linus Torvalds, (Tue Mar 20, 12:57 am)

Re: [PATCH 3/2] Avoid unnecessary strlen() calls, Johannes Schindelin, (Mon Mar 19, 11:05 pm)

Re: [PATCH 3/2] Avoid unnecessary strlen() calls, Shawn O. Pearce, (Mon Mar 19, 11:29 pm)

Re: [PATCH 3/2] Avoid unnecessary strlen() calls, Shawn O. Pearce, (Mon Mar 19, 11:40 pm)

Re: [PATCH 3/2] Avoid unnecessary strlen() calls, Linus Torvalds, (Tue Mar 20, 12:11 am)

Re: [PATCH 3/2] Avoid unnecessary strlen() calls, Junio C Hamano, (Tue Mar 20, 1:44 am)

Re: [PATCH 3/2] Avoid unnecessary strlen() calls, Shawn O. Pearce, (Tue Mar 20, 12:18 am)

Re: [PATCH 3/2] Avoid unnecessary strlen() calls, Linus Torvalds, (Tue Mar 20, 12:45 am)

Re: [PATCH 3/2] Avoid unnecessary strlen() calls, Linus Torvalds, (Sun Mar 18, 11:57 am)

Re: [PATCH 3/2] Avoid unnecessary strlen() calls, Shawn O. Pearce, (Sun Mar 18, 5:38 pm)

Re: [PATCH 3/2] Avoid unnecessary strlen() calls, Linus Torvalds, (Sun Mar 18, 5:48 pm)

Re: [PATCH 2/2] Implement a simple delta_base cache, Nicolas Pitre, (Sat Mar 17, 11:00 pm)

Re: [PATCH 2/2] Implement a simple delta_base cache, Linus Torvalds, (Sat Mar 17, 11:31 pm)

Re: [PATCH 2/2] Implement a simple delta_base cache, Robin Rosenberg, (Sun Mar 18, 6:53 am)

Re: [PATCH 2/2] Implement a simple delta_base cache, Linus Torvalds, (Sun Mar 18, 1:34 pm)

Re: [PATCH 2/2] Implement a simple delta_base cache, Robin Rosenberg, (Sun Mar 18, 2:29 pm)

Re: [PATCH 2/2] Implement a simple delta_base cache, David Brodsky, (Mon Mar 19, 9:16 am)

Re: [PATCH 2/2] Implement a simple delta_base cache, Robin Rosenberg, (Tue Mar 20, 2:35 am)

Re: [PATCH 2/2] Implement a simple delta_base cache, David Brodsky, (Tue Mar 20, 5:13 am)

Re: [PATCH 2/2] Implement a simple delta_base cache, Linus Torvalds, (Tue Mar 20, 10:37 pm)

Re: [PATCH 2/2] Implement a simple delta_base cache, Nicolas Pitre, (Tue Mar 20, 10:54 pm)

Re: [PATCH 2/2] Implement a simple delta_base cache, Shawn O. Pearce, (Sun Mar 18, 5:25 pm)

Re: [PATCH 2/2] Implement a simple delta_base cache, Julian Phillips, (Sun Mar 18, 1:30 am)

Re: [PATCH 2/2] Implement a simple delta_base cache, Linus Torvalds, (Sun Mar 18, 1:23 pm)

Re: [PATCH 2/2] Implement a simple delta_base cache, Junio C Hamano, (Sat Mar 17, 7:12 pm)

Re: [PATCH 2/2] Implement a simple delta_base cache, Linus Torvalds, (Sat Mar 17, 7:24 pm)

Re: [PATCH 2/2] Implement a simple delta_base cache, Jon Smirl, (Sat Mar 17, 7:52 pm)

Re: [PATCH 2/2] Implement a simple delta_base cache, Junio C Hamano, (Sat Mar 17, 6:37 pm)

Re: [PATCH 2/2] Implement a simple delta_base cache, Nicolas Pitre, (Sat Mar 17, 9:13 pm)

Re: [PATCH 2/2] Implement a simple delta_base cache, Junio C Hamano, (Sun Mar 18, 3:47 am)

Re: [PATCH 2/2] Implement a simple delta_base cache, Linus Torvalds, (Sat Mar 17, 7:09 pm)

Re: [PATCH 2/2] Implement a simple delta_base cache, Linus Torvalds, (Sat Mar 17, 7:54 pm)

[PATCH 1/2] Make trivial wrapper functions around delta base..., Linus Torvalds, (Sat Mar 17, 3:42 pm)

Re: cleaner/better zlib sources?, Shawn O. Pearce, (Sat Mar 17, 1:19 am)

Re: cleaner/better zlib sources?, Matt Mackall, (Thu Mar 15, 9:14 pm)

Re: cleaner/better zlib sources?, Shawn O. Pearce, (Thu Mar 15, 9:10 pm)

Navigation

Popular discussions


linux-kernel:
Greg KH	Re: Dual-Licensing Linux Kernel with GPL V2 and GPL V3
Greg Kroah-Hartman	[PATCH 001/196] Chinese: Add the known_regression URI to the HOWTO
Andy Whitcroft	clam
Ingo Molnar	[patch] paravirt: VDSO page is essential
git:

linux-netdev:
David Miller	Re: [PATCH] pkt_sched: Destroy gen estimators under rtnl_lock().
Gerrit Renker	[PATCH 27/37] dccp: Integration of dynamic feature activation - part 2 (server side)
Lovich, Vitali	RE: [PATCH] Packet socket: mmapped IO: PACKET_TX_RING
David Miller	[GIT]: Networking
openbsd-misc:

Colocation donated by:

Online users

zmarszczki

Syndicate