I tried. Of course, it helped tremendously that there were test cases.
Nevertheless would I appreciate review from the list...
Yes, that was part of the reason I rewrote these two in C: For example, I
would like a little bit better locking (double locking index would be a
good start).
Of course, it makes it easier to write cmd_rebase(): I plan to put it into
the same file so that the function revert_or_cherry_pick() can easily be
reused.
I briefly considered this, until I realized that merge-recursive is no
builtin yet!
Speaking of this issue: Would it be conceivable to make the standalones
into builtins? (This adds a dependency on libcurl to core Git programs,
but I could live with that... It would make a builtin fetch easier, too.)
Okay. I have no idea how much the tests rely on that locations, let alone
other scripts. Therefore I think it is sane to do it in a separate step.
Yeah, let's do that, too.
BTW it took me so long because there was a hard-to-catch bug with the
encodings (of course!). In the end I realized that I only forgot to call
git_config(git_default_config)... D'oh.
Ciao,
Dscho
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html