login
Header Space

 
 

Re: git-fast-import

Score:
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Linus Torvalds <torvalds@...>
Cc: Horst H. von Brand <vonbrand@...>, Shawn O. Pearce <spearce@...>, Andy Parkins <andyparkins@...>, <git@...>
Date: Thursday, February 8, 2007 - 5:34 pm

Hi,

On Tue, 6 Feb 2007, Linus Torvalds wrote:


FWIW I just grepped git for tz, and looked at the results. The place I had 
to think a bit more about was in builtin-blame.c:format_time(). Probably a 
special date format is needed to stay compatible with cvsserver, otherwise 
show_date() or even show_rfc2822_date() could be used.

The code actually adds the timezone in minutes to the timestamp, and then 
calls gmtime() to be able to format the date with strftime() (something 
similar, without strftime() is done in show_[rfc2822_]date()). The result 
is correct AFAICT, although it would be cleaner IMHO to add yet another 
function to date.c which formats the time according to cvsserver's wishes.

Post 1.5.0.

Ciao,
Dscho

-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
git-fast-import, Shawn O. Pearce, (Mon Feb 5, 10:31 pm)
Re: git-fast-import, Alex Riesen, (Tue Feb 6, 9:50 am)
Re: git-fast-import, Shawn O. Pearce, (Tue Feb 6, 1:43 pm)
Re: git-fast-import, Alex Riesen, (Tue Feb 6, 2:02 pm)
Re: git-fast-import, Andy Parkins, (Tue Feb 6, 5:28 am)
Re: git-fast-import, Linus Torvalds, (Tue Feb 6, 12:37 pm)
Re: git-fast-import, Shawn O. Pearce, (Tue Feb 6, 12:44 pm)
Re: git-fast-import, Daniel Barkalow, (Wed Feb 7, 12:45 am)
Re: git-fast-import, Horst H. von Brand, (Tue Feb 6, 9:17 pm)
Re: git-fast-import, Shawn O. Pearce, (Wed Feb 7, 1:46 am)
Re: git-fast-import, Linus Torvalds, (Tue Feb 6, 10:50 pm)
Re: git-fast-import, Johannes Schindelin, (Thu Feb 8, 5:34 pm)
Re: git-fast-import, Shawn O. Pearce, (Wed Feb 7, 1:53 am)
Re: git-fast-import, Horst H. von Brand, (Wed Feb 7, 6:18 pm)
Re: git-fast-import, Linus Torvalds, (Wed Feb 7, 6:39 pm)
Re: git-fast-import, Karl , (Wed Feb 7, 5:21 am)
Re: git-fast-import, Linus Torvalds, (Tue Feb 6, 1:24 pm)
Re: git-fast-import, Shawn O. Pearce, (Tue Feb 6, 5:40 am)
Re: git-fast-import, Aneesh Kumar K.V, (Tue Feb 6, 2:12 am)
Re: git-fast-import, Shawn O. Pearce, (Tue Feb 6, 2:18 am)
Re: git-fast-import, Daniel Barkalow, (Wed Feb 7, 12:55 am)
Re: git-fast-import, David Woodhouse, (Wed Feb 7, 9:38 am)
RE: git-fast-import, Raimund Bauer, (Wed Feb 7, 5:29 am)
Re: git-fast-import, Karl , (Wed Feb 7, 5:13 am)
Re: git-fast-import, Johannes Schindelin, (Wed Feb 7, 7:17 am)
Re: git-fast-import, Shawn O. Pearce, (Wed Feb 7, 6:55 pm)
Re: git-fast-import, Johannes Schindelin, (Wed Feb 7, 7:55 pm)
Re: git-fast-import, Linus Torvalds, (Thu Feb 8, 12:56 pm)
Re: git-fast-import, Shawn O. Pearce, (Thu Feb 8, 3:10 pm)
Re: git-fast-import, Karl , (Fri Feb 9, 4:49 am)
Re: git-fast-import, Linus Torvalds, (Fri Feb 9, 11:47 am)
Re: git-fast-import, Shawn O. Pearce, (Wed Feb 7, 8:12 pm)
Re: git-fast-import, Nicolas Pitre, (Tue Feb 6, 12:06 am)
Re: git-fast-import, Shawn O. Pearce, (Tue Feb 6, 1:48 am)
Re: git-fast-import, Linus Torvalds, (Tue Feb 6, 12:35 pm)
Re: git-fast-import, Shawn O. Pearce, (Tue Feb 6, 12:56 pm)
Re: git-fast-import, Linus Torvalds, (Tue Feb 6, 1:20 pm)
Re: git-fast-import, Nicolas Pitre, (Tue Feb 6, 2:53 pm)
Re: git-fast-import, David Woodhouse, (Wed Feb 7, 6:58 am)
Re: git-fast-import, Shawn O. Pearce, (Tue Feb 6, 4:09 pm)
Re: git-fast-import, Nicolas Pitre, (Tue Feb 6, 5:03 pm)
Re: git-fast-import, Shawn O. Pearce, (Tue Feb 6, 5:15 pm)
Re: git-fast-import, Nicolas Pitre, (Tue Feb 6, 5:42 pm)
Re: git-fast-import, Nicolas Pitre, (Mon Feb 5, 11:18 pm)
speck-geostationary