login
Header Space

 
 

[RFC/PATCH] enable rerere by default

Score:
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: <git@...>, <junkio@...>
Date: Tuesday, February 6, 2007 - 6:13 am

Since the theme of the upcoming release is the (true) Wow factor, we 
should enable this feature by default. New users are not likely to learn 
of that feature otherwise.

Signed-off-by: Johannes Schindelin <Johannes.Schindelin@gmx.de>
---

	I know it is quite late in the game for 1.5.0, but since the theme 
	is usability and user-friendliness, I cannot think of a better 
	release to enable rerere by default, if that should ever happen.

	Comments?

 builtin-init-db.c |    2 ++
 t/t4200-rerere.sh |    3 ---
 2 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/builtin-init-db.c b/builtin-init-db.c
index 12e43d0..2504507 100644
--- a/builtin-init-db.c
+++ b/builtin-init-db.c
@@ -260,6 +260,8 @@ static int create_default_files(const char *git_dir, const char *template_path)
 		/* allow template config file to override the default */
 		if (log_all_ref_updates == -1)
 		    git_config_set("core.logallrefupdates", "true");
+		strcpy(path + len, "rr-cache");
+		safe_create_dir(path, 1);
 	}
 	return reinit;
 }
diff --git a/t/t4200-rerere.sh b/t/t4200-rerere.sh
index 91be272..8187038 100755
--- a/t/t4200-rerere.sh
+++ b/t/t4200-rerere.sh
@@ -37,9 +37,6 @@ git checkout -b second master
 git show first:a1 | sed 's/To die, t/To die! T/' > a1
 git commit -q -a -m second
 
-# activate rerere
-mkdir .git/rr-cache
-
 test_expect_failure 'conflicting merge' 'git pull . first'
 
 sha1=4f58849a60b4f969a2848966b6d02893b783e8fb
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[RFC/PATCH] enable rerere by default, Johannes Schindelin, (Tue Feb 6, 6:13 am)
Re: [RFC/PATCH] enable rerere by default, Alex Riesen, (Tue Feb 6, 9:56 am)
Re: [RFC/PATCH] enable rerere by default, Johannes Schindelin, (Tue Feb 6, 11:03 am)
Re: [RFC/PATCH] enable rerere by default, Junio C Hamano, (Tue Feb 6, 7:06 pm)
Re: [RFC/PATCH] enable rerere by default, Johannes Schindelin, (Tue Feb 6, 7:19 pm)
Re: [RFC/PATCH] enable rerere by default, Alex Riesen, (Tue Feb 6, 11:39 am)
Re: [RFC/PATCH] enable rerere by default, Johannes Schindelin, (Tue Feb 6, 11:53 am)
speck-geostationary