On Mon, 26 Feb 2007, Johannes Schindelin wrote:

quoted text
> Hi,
> 
> On Mon, 26 Feb 2007, Linus Torvalds wrote:
> 
> > I suspect you only tested with small input to stdin.
> 
> Addendum: yes, I only tested with a reflist which was smaller than one 
> megabyte ;-)

Well, that CHUNK_SIZE is just silly. I don't see why you'd have a 
chunk-size of a megabyte to begin with, IO doesn't really get any more 
efficient that way. And yeah, in this case it would easily hide the bug, 
because in practice nobody would ever test with that much input data.

It might make sense to make the chunk-size smaller just from a testability 
standpoint (not to mention that it's probably currently just wasting 
memory for most users - although at least under Linux, if you never use a 
page, none will be allocated for you, so the OS may hide the wastage).

		Linus
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html