Re: [PATCH 3/3] diffstat generation in hooks--update was passing "^baserev" to git-diff-tree

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Johannes Sixt
Date: Tuesday, February 13, 2007 - 10:16 am

Andy Parkins wrote:

You are using ^$baserev in two instances.

(1) in a for loop which obviously is intended as a table of contents
(revs plus rev-type (can this be anything else than 'commit'?)). Here
you should use

git-rev-list $newrev --not $baserev

(2) later to print the log messages for all new revs. Here you use just
this:

git-rev-list --pretty $oldrev..$newrev


Then the diffstat:

git-diff-tree --no-color --stat -M -C --find-copies-harder \
  $oldrev $newrev

This reflects the modifications of the revisions that have just been
listed *only* in the fast-forward case. But even in the forced update
case it tells how the old tree transformed into the new tree, and for
this reason nothing more complicated is needed, IMO.

-- Hannes

-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Re: [PATCH 3/3] diffstat generation in hooks--update was p ..., Johannes Sixt, (Tue Feb 13, 10:16 am)