[Resend PATCH] git-send-email.perl: Really add angle brackets to In-Reply-To if necessary

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Mike Hommey
Date: Sunday, December 9, 2007 - 12:58 pm

3803bcea tried to fix this, but it only adds the branckes when the given
In-Reply-To begins and ends with whitespaces. It also didn't do anything
to the --in-reply-to argument.

Signed-off-by: Mike Hommey <mh@glandium.org>
---

Randal L. Schwartz wrote:

Doh', I forgot to remove them. Here is a cleaned out patch.

 git-send-email.perl |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/git-send-email.perl b/git-send-email.perl
index 76baa8e..c0e1dd3 100755
--- a/git-send-email.perl
+++ b/git-send-email.perl
@@ -367,10 +367,11 @@ if ($thread && !defined $initial_reply_to && $prompting) {
 	} while (!defined $_);
 
 	$initial_reply_to = $_;
-	$initial_reply_to =~ s/^\s+<?/</;
-	$initial_reply_to =~ s/>?\s+$/>/;
 }
 
+$initial_reply_to =~ s/^\s*<?/</;
+$initial_reply_to =~ s/>?\s*$/>/;
+
 if (!defined $smtp_server) {
 	foreach (qw( /usr/sbin/sendmail /usr/lib/sendmail )) {
 		if (-x $_) {
-- 
1.5.3.7


-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH 1/4] Cleanup variables in http.[ch], Mike Hommey, (Sun Dec 9, 10:04 am)
[PATCH 2/4] Use strbuf in http code, Mike Hommey, (Sun Dec 9, 10:04 am)
[PATCH 4/4] Add support for URLs to git-apply, Mike Hommey, (Sun Dec 9, 10:05 am)
Re: [PATCH 1/4] Cleanup variables in http.[ch], Junio C Hamano, (Sun Dec 9, 11:21 am)
Re: [PATCH] git-send-email.perl: Really add angle brackets ..., Randal L. Schwartz, (Sun Dec 9, 11:53 am)
Re: [PATCH] git-send-email.perl: Really add angle brackets ..., Randal L. Schwartz, (Sun Dec 9, 12:51 pm)
[Resend PATCH] git-send-email.perl: Really add angle brack ..., Mike Hommey, (Sun Dec 9, 12:58 pm)