login
Header Space

 
 

git mailing list

FromSubjectsort iconDate
Eyvind Bernhardsen
Where has "git ls-remote" reference pattern matching gone?
git-ls-remote(1) says that ls-remote supports filtering by reference But when I try to use the <refs> argument on a current build of git (git version v1.5.3.7-1112-g9758ecd), I just get its usage message, ls-remote was recently made a builtin; was reference filtering deliberately removed, or was it just lost in translation from the shell script? Eyvind Bernhardsen -
Dec 8, 6:05 pm 2007
Benoit Sigoure
[Misfeature] cloning without configuration fails and returns 0
Hi, on a new machine I have access to, I fetched tonight's git master (git version 1.5.3.7.g9758e) and installed it on my account in order to clone one of my projects. I did not setup anything in my git config and stumbled on the following misfeature: ---------------------------------------------------------------------- $ git clone ssh://login@host/~/path/git/project/.git project Initialized empty Git repository in /home/me/git/project/.git/ Password: remote: Counting objects: 609, done. ...
Dec 8, 6:21 pm 2007
Jon Smirl
dmalloc and leaks in git
It is very easy to use dmalloc with git. Follow the instructions here, http://dmalloc.com/docs/latest/online/dmalloc_4.html But using dmalloc shows a pervasive problem, none of the git commands are cleaning up after themselves. For example I ran a simple command, git-status, and thousands of objects were not freed. Normally this doesn't hurt since exiting the process obviously frees all of the memory. But when programming this way it becomes impossible to tell which leaks were on purpose and whic...
Dec 8, 4:53 pm 2007
Johannes Schindelin
Re: dmalloc and leaks in git
Hi, Known problem. Goes by the name of "libification" on this list. Ciao, Dscho -
Dec 8, 4:58 pm 2007
Jon Smirl
Re: dmalloc and leaks in git
I tried using dmalloc to find the leak in repack but it is impossible to sort out the accidental leaks from the on-purpose ones. On exit there were millions of unfreed objects coming from all over the place. -- Jon Smirl jonsmirl@gmail.com -
Dec 8, 5:02 pm 2007
Johannes Schindelin Dec 8, 5:19 pm 2007
Finn Arne Gangstad
Submodules and merging
From an earlier discussion here on the mailing list I had the impression that there was some support for merging submodules from the supermodule. This does not seem to be the case, but I think it would be very good if this WAS possible? Here is the shortest example that still mimics "real" work that shows the problem. Assume change1 and change2 are done by two different people in two different repositories and push this into separate branches in a central repo somewhere. A maintainer at the central...
Dec 8, 2:40 pm 2007
Dan Nicholson
[PATCH] send-email: Allow sleeping between sending mails
Sometimes when sending many mails, the thread appears out of order for the recipient. This adds a simple workaround by sleeping between sending mails. This is controlled by the option --sleep, which defaults to 0. Since the perl builtin function sleep is used, only integer granularity is offered. GetOptions seems to perform the necessary checking for this. Signed-off-by: Dan Nicholson <dbn.lists@gmail.com> --- Documentation/git-send-email.txt | 5 +++++ git-send-email.perl ...
Dec 8, 1:12 pm 2007
Jim Meyering
[PATCH] Fix off-by-one error: don't read the byte before a m...
* config.c (store_write_pair): Don't read value[-1]. Signed-off-by: Jim Meyering <meyering@redhat.com> --- config.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/config.c b/config.c index ed96213..6031b38 100644 --- a/config.c +++ b/config.c @@ -652,7 +652,7 @@ static int store_write_pair(int fd, const char* key, const char* value) for (i = 0; value[i]; i++) if (value[i] == ';' || value[i] == '#') quote = 1; - if (value[i-1] == ' ') + if (i &amp...
Dec 8, 11:48 am 2007
Petr Baudis
[PATCH] gitweb: Make config_to_multi return [] instead of [u...
This is important for the list of clone urls, where if there are no per-repository clone URL configured, the default base URLs are never used for URL construction with this patch. Signed-off-by: Petr Baudis <pasky@suse.cz> --- gitweb/gitweb.perl | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl index 491a3f4..d5505a4 100755 --- a/gitweb/gitweb.perl +++ b/gitweb/gitweb.perl @@ -1512,7 +1512,7 @@ sub config_to_int { sub c...
Dec 8, 8:30 am 2007
Jakub Narebski
Re: [PATCH] gitweb: Make config_to_multi return [] instead o...
Shouldn't it be + return ref($val) ? $val : defined($val) ? [ $val ] : []; -- Jakub Narebski -
Dec 8, 12:13 pm 2007
Petr Baudis
Removing redundant packs
Hi, before exporting whole repo.or.cz over rsync for mirroring, I would like to clean up the worst repositories (esp. linux-2.6 repositories) whose objects database looks absolutely horrible now. At the same time, I have to be careful not to prune all unreferenced objects since they can be referenced in forks. How would you go about it? My idea was to do a fresh cummulative pack of all referenced objects with git repack -a and then remove packs that contain _only_ objects that ar...
Dec 8, 8:50 am 2007
Junio C Hamano
Re: Removing redundant packs
How about... (1) In each repository, run "repack -a -d". That would ensure that everybody has the necessary objects that they themselves need. By doing this for a repository that borrows from another makes sure pruning the latter would not break the former, so you start from leaves and move on to the repositories they borrow from. (2) In each repository, run "repack -a -l -d". By doing this for a repository that borrows from another repacks the former without ...
Dec 8, 5:37 pm 2007
Jeff King
Re: Removing redundant packs
I'm not sure this works. Try this: # make parent repo with two commits, fully packed mkdir parent && cd parent && git init && echo content >file && git add file && git commit -m added && echo more >>file && git commit -m more -a && git repack -a -d # clone child repo with alternates git clone -s . ../child # and now forget about the second commit in the parent git reset --hard HEAD^ rm -rf .git/logs # at this point...
Dec 8, 7:44 pm 2007
Jeff King
Re: Removing redundant packs
And by "you seem to think" I obviously don't mean "stupid n00b, you don't understand git" but "I'm unclear on what the behavior should be. You seem to be saying this, which means this is a serious bug." -Peff -
Dec 8, 7:50 pm 2007
Christian Couder
[PATCH v2] git-help: simplify and fix option parsing.
Also use "execl_git_cmd" to launch "git-browse-help". Signed-off-by: Christian Couder <chriscool@tuxfamily.org> --- help.c | 33 ++++++++++++--------------------- 1 files changed, 12 insertions(+), 21 deletions(-) Junio wrote: > This should be execl_git_cmd() to honor GIT_TRACE and to help > transition to bindir != gitexecdir layout, I think. Here it is. diff --git a/help.c b/help.c index ecc8c66..9d7fc8a 100644 --- a/help.c +++ b/help.c @@ -241,7 +241,9 @@ void list_...
Dec 8, 8:18 am 2007
Jakub Narebski
[PATCH] gitweb: Teach "a=blob" action to be more lenient abo...
Since 930cf7dd7cc6b87d173f182230763e1f1913d319 'blob' action knows the file type; if the file type is not "text/*" or one of common network image formats/mimetypes (gif, png, jpeg) then the action "blob" defaulted to "blob_plain". This caused the problem if mimetypes file was not well suited for web, for example returning "application/x-sh" for "*.sh" shell scripts, instead of "text/plain" (or other "text/*"). Now "blob" action defaults to "blob_plain" ('raw' view) only if file is of type which is...
Dec 8, 7:55 am 2007
Wincent Colaiuta
[PATCH 0/3] builtin-commit fixes
A little series to bring built-in commit back in line with the behaviour as implemented by git-commit.sh and described in the documentation. 1/3 Allow --no-verify to bypass commit-msg hook - git-commit.sh used to do this, but builtin-commit wasn't. 2/3 Documentation: fix --no-verify documentation for "git commit" - The "git commit" man page should mention the commit-msg hook to bring it in line with what's in the hook notes and in Documentation/hooks.txt. 3/3 Fix commit-msg hook to allow ...
Dec 8, 7:38 am 2007
Wincent Colaiuta
[PATCH 4/4] Add tests for pre-commit and commit-msg hooks
As desired, these pass for git-commit.sh, fail for builtin-commit (prior to the fixes), and succeeded for builtin-commit (after the fixes). Signed-off-by: Wincent Colaiuta <win@wincent.com> --- t/t7501-commit.sh | 2 +- t/t7503-pre-commit-hook.sh | 64 ++++++++++++++++++++++++++++++++ t/t7504-commit-msg-hook.sh | 88 ++++++++++++++++++++++++++++++++++++++++++++ 3 files changed, 153 insertions(+), 1 deletions(-) create mode 100755 t/t7503-pre-commit-hook.sh create mode 100...
Dec 8, 8:29 am 2007
Wincent Colaiuta
Re: [PATCH 4/4] Add tests for pre-commit and commit-msg hooks
Actually, that's a slight lie. The commit-msg tests 9 and 10 (editing the commit message from the hook) fail for git-commit.sh (tested 1.5.3.4 and 1.5.3.7). By the looks of it, this discrepancy isn't actually a bug in git- commit.sh, but is because of stuff that was in commit.c back in 1.5.3.7 and prior which causes a commit message like "foo" to yield "foo<unknown>" when you do a "git log --pretty=format:%s%b -1"; post 1.5.3.7 (on master) it instead yields "foo", which is what I...
Dec 8, 8:51 am 2007
Wincent Colaiuta
[PATCH 1/3] Allow --no-verify to bypass commit-msg hook
At the moment the --no-verify switch to "git commit" instructs it to skip over the pre-commit hook. Here we teach "git commit --no-verify" to skip over the commit-msg hook as well. This brings the behaviour of builtin-commit back in line with git-commit.sh. Signed-off-by: Wincent Colaiuta <win@wincent.com> --- builtin-commit.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/builtin-commit.c b/builtin-commit.c index 2ec8223..df9377e 100644 --- a/builtin-commit.c...
Dec 8, 7:38 am 2007
Wincent Colaiuta
[PATCH 2/3] Documentation: fix --no-verify documentation for...
The documentation for the --no-verify switch should mention the commit-msg hook, not just the pre-commit hook. Signed-off-by: Wincent Colaiuta <win@wincent.com> --- Documentation/git-commit.txt | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/Documentation/git-commit.txt b/Documentation/git-commit.txt index 4bb2791..4261384 100644 --- a/Documentation/git-commit.txt +++ b/Documentation/git-commit.txt @@ -86,7 +86,7 @@ OPTIONS Add Signed-off-by line at the end o...
Dec 8, 7:38 am 2007
Wincent Colaiuta
[PATCH 3/3] Fix commit-msg hook to allow editing
The old git-commit.sh script allowed the commit-msg hook to not only prevent a commit from proceding, but also to edit the commit message on the fly and allow it to proceed. So here we teach builtin-commit to do the same. Signed-off-by: Wincent Colaiuta <win@wincent.com> --- builtin-commit.c | 16 ++++++++++------ 1 files changed, 10 insertions(+), 6 deletions(-) diff --git a/builtin-commit.c b/builtin-commit.c index df9377e..a6223d2 100644 --- a/builtin-commit.c +++ b/builtin-commit...
Dec 8, 7:38 am 2007
Jeff King
[PATCH] git-status: documentation improvements
This patch is the result of reading over git-status with an editorial eye: - fix a few typo/grammatical errors - mention untracked output - present output types in the order they appear from the command Signed-off-by: Jeff King <peff@peff.net> --- This is on top of the documentation patch I sent a few minutes ago. Documentation/git-status.txt | 25 +++++++++++++------------ 1 files changed, 13 insertions(+), 12 deletions(-) diff --git a/Documentation/git-status.txt b/Do...
Dec 8, 5:00 am 2007
Junio C Hamano
[OT] perhaps we want to support copied-context diff output
The patch looks correct, but I have an offtopic comment that does not have anything to do with the problem being discussed right now. Before being able to understand what was going on, I had to shuffle the above patch by duplicating the context lines, prefix them with '-' and then '+', and grouping preimage lines and postimage lines together, to come up with this patch: static int type_size_sort(const void *_a, const void *_b) { const struct object_entry *a = *(struct object_entry **)_a; ...
Dec 8, 4:18 am 2007
Mike Hommey
Re: [OT] perhaps we want to support copied-context diff output
Or maybe use the patience diff. On a testcase I had a few months ago, patience diff would give: @@ -42,11 +42,10 @@ include $(DEPTH)/config/autoconf.mk +EXTRA_COMPONENTS = nsKillAll.js + include $(topsrcdir)/config/rules.mk -libs:: - $(INSTALL) $(srcdir)/nsKillAll.js $(DIST)/bin/components - clean:: rm -f $(DIST)/bin/components/nsKillAll.js Where "normal" diff would give: @@ -42,10 +42,9 @@ include $(DEPTH)/config/autoconf.mk -include $(topsrcdir)/config/rule...
Dec 8, 4:53 am 2007
Peter Baumann
Re: [OT] perhaps we want to support copied-context diff output
[... skip testcase showing a much nicer diff for human consumption ...] AFAIR bzr uses the patience diff already. I don't actually use bzr (obviously, because git is so much better:-) but it produces much nicer diffs than git if you have many small changes nearby. -Peter -
Dec 8, 7:10 am 2007
Junio C Hamano
Re: [PATCH] Calculate $commitsha1 in update() only when needed
Hmm. The first rev-parse could be squelched with 2>/dev/null and then you can check if it does not match [a-f0-9]{40} and die early before running "cat-file commit", can't you? Also the regexp to check "tree" object name above seems quite wrong ;-) If the purpose of this check is to make sure if the ref points at a commit object, perhaps... my $commitsha1 = `git rev-parse --verify $self->{module}^0 2>&1`; chomp($commitsha1); if ($commitsha1 !~ /^[0-9a-f]{40}$/) { ...
Dec 8, 4:17 am 2007
Pavel Roskin
Re: [PATCH] Calculate $commitsha1 in update() only when needed
Yes, my impression is that the code in question can be improved a lot. This is specifically the error message I'd like to see fixed in some way, as it's confusing to beginners trying to check out the module for the first time. $ CVS_SERVER=/home/proski/bin/git-cvsserver cvs -d \ :fork:/home/proski/src/qgit/.git co foo fatal: ambiguous argument 'foo': unknown revision or path not in the working tree. Use '--' to separate paths from revisions Invalid module 'foo' at /home/proski/bin/git...
Dec 8, 4:48 am 2007
Assim Deodia
On running git via proxy
Hello, I am a newbie to git. I am running git on my virtual machine which has the internet access via proxy through the host machine. I am unable to configure git to run via proxy. system proxy seems not to be working for git.. Can you please guide me for the same? -- With Regards Assim -
Dec 8, 1:13 am 2007
Pavel Roskin
[PATCH] Calculate $commitsha1 in update() only when needed
This suppresses unhelpful error messages from git rev-parse during checkout if the module doesn't exist. Signed-off-by: Pavel Roskin <proski@gnu.org> --- git-cvsserver.perl | 12 +++++++----- 1 files changed, 7 insertions(+), 5 deletions(-) diff --git a/git-cvsserver.perl b/git-cvsserver.perl index ecded3b..409b301 100755 --- a/git-cvsserver.perl +++ b/git-cvsserver.perl @@ -2427,9 +2427,6 @@ sub update # first lets get the commit list $ENV{GIT_DIR} = $self->{git_pa...
Dec 8, 1:07 am 2007
Nicolas Pitre
[PATCH 2/2] pack-objects: fix threaded load balancing
The current method consists of a master thread serving chunks of objects to work threads when they're done with their previous chunk. The issue is to determine the best chunk size: making it too large creates poor load balancing, while making it too small has a negative effect on pack size because of the increased number of chunk boundaries and poor delta window utilization. This patch implements a completely different approach by initially splitting the work in large chunks uniformly amongst al...
Dec 8, 1:03 am 2007
Jeff King
Re: [PATCH 2/2] pack-objects: fix threaded load balancing
Yay! This works great on my "pack a few hundred very large objects" repo. -Peff -
Dec 8, 5:18 am 2007
Nicolas Pitre
[PATCH 1/2] pack-objects: reverse the delta search sort list
It is currently sorted and then walked backward. Not only this doesn't feel natural for my poor brain, but it would make the next patch less obvious as well. So reverse the sort order, and reverse the list walking direction, which effectively produce the exact same end result as before. Also bring the relevant comment nearer the actual code and adjust it accordingly, with minor additional clarifications. Signed-off-by: Nicolas Pitre <nico@cam.org> --- builtin-pack-objects.c | 41 +...
Dec 8, 1:00 am 2007
Christian Couder
[PATCH] git-help: simplify and fix option parsing.
Signed-off-by: Christian Couder <chriscool@tuxfamily.org> --- help.c | 31 +++++++++++-------------------- 1 files changed, 11 insertions(+), 20 deletions(-) Junio wrote about "help.c" in my "git-help: add -w|--web option to display html man page in a browser." patch: > Isn't this "check-help-cmd" duplication ugly, by the way? You are right, this patch should fix it. Thanks. diff --git a/help.c b/help.c index ecc8c66..78686db 100644 --- a/help.c +++ b/help.c @@ -241,7 ...
Dec 8, 1:06 am 2007
J.C. Pizarro
Re: Git and GCC
If SHA1 is slow then why dont he contribute adding Haval160 (3 rounds) that it's faster than SHA1? And to optimize still more it with SIMD instructions It's better 1. "Don't compress this repo but compact this uncompressed repo using minimal spanning forest and deltas" 2. "After, compress this whole repo with LZMA (e.g. 48MiB) from 7zip before burning it to DVD for backup reasons or before replicating it to internet". J.C.Pizarro "the noiser" -
Dec 7, 10:21 pm 2007
Johannes Schindelin
Re: Git and GCC
Hi, Patches? ;-) Ciao, Dscho -
Dec 8, 8:24 am 2007
Joe Buck
Re: Git and GCC
git list, meet J.C. Pizarro. Care to take him off of our hands for a while? He's been hanging on the gcc list for some time, and perhaps seeks new horizons. Mr. Pizarro has endless ideas, and he'll give you some new ones every day. He thinks that no one else knows any computer science, and he will attempt to teach you what he knows, and tell you to rewrite all of your code based on something he read and half-understood. But he's not interested in actually DOING the work, mind you; that's up ...
Dec 8, 3:53 pm 2007
Marco Costalba
Re: Git and GCC
Actually he never spoke like that (probably I missed that part too). Thanks Marco -
Dec 8, 4:28 pm 2007
Junio C Hamano
[PATCH 1/2] mailmap: fix bogus for() loop that happened to b...
The empty loop pretended to have an empty statement as its body by a phony indentation, but in fact was slurping the next statement into it. Signed-off-by: Junio C Hamano <gitster@pobox.com> --- mailmap.c | 7 ++++--- 1 files changed, 4 insertions(+), 3 deletions(-) diff --git a/mailmap.c b/mailmap.c index 8714167..f017255 100644 --- a/mailmap.c +++ b/mailmap.c @@ -42,9 +42,10 @@ int read_mailmap(struct path_list *map, const char *filename, char **repo_abbrev continue; if (r...
Dec 7, 9:32 pm 2007
Junio C Hamano
[PATCH 2/2] shortlog: code restruturing and clean-up
The code tried to parse and clean-up the author name and the one line information in three places (two callers of insert_author_oneline() and the called function itself), whihc was a mess. This renames the callee to insert_one_record() and make it responsible for cleaning up the author name and one line information. Signed-off-by: Junio C Hamano <gitster@pobox.com> --- builtin-shortlog.c | 165 +++++++++++++++++++-------------------------------- 1 files changed, 62 insertions(+), 103 del...
Dec 7, 9:32 pm 2007
Alex Riesen Dec 8, 1:13 pm 2007
Wincent Colaiuta
Re: [PATCH 2/2] shortlog: code restruturing and clean-up
whihc -> which Cheers, Wincent -
Dec 8, 5:34 am 2007
Miklos Vajna
git-svn branch naming question
hi, i'm using git-svn for projects where i don't just want to commit to trunk but to other branches, too. for example: git-svn clone -s svn+ssh://vmiklos@svn.gnome.org/svn/ooo-build ooo-build then i have a local 'master' branch and all the other branches are local branches. so, when i want to work in the ooo-build-2-3 branch, i do a: git checkout -b ooo-build-2-3 ooo-build-2-3 but when i do a git svn rebase, i get: warning: refname 'ooo-build-2-3' is ambiguous. what am i doing w...
Dec 7, 9:04 pm 2007
Peter Baumann
Re: git-svn branch naming question
Try using 'git svn rebase remotes/ooo-build-2-3'. git-svn should produce its branches under refs/remotes/* and your local branches are under refs/heads/*. By using 'git checkout -b ooo-build-2-3 ooo-build-2-3' you created refs/heads/ooo-build-2-3 as a copy of refs/remotes/ooo-build-2-3 and now using only ooo-build-2-3 is ambigious. (at least in some cases where git Look up --prefix in the manpage for git-svn. -Peter -
Dec 8, 6:59 am 2007
Miklos Vajna
Re: git-svn branch naming question
great, --prefix is what i missed. a related question: is it possible to avoid even the "remotes" prefix? it could be useful when creating an incremental import of an svn repo. (ie when using git-svn as a replacement of git-svnimport.) so after the clone, one will see all the svn branches as a remote branch, since they will be local (and not remote) ones in the mirror repo. thanks, - VMiklos
Dec 8, 10:14 am 2007
Peter Baumann
Re: git-svn branch naming question
git svn init --stdlayout creates this entry in your .git/config per default [svn-remote "svn"] url = https://url/to/your/svn/repo fetch = trunk:refs/remotes/trunk branches = branches/*:refs/remotes/* tags = tags/*:refs/remotes/tags/* You could change this to [svn-remote "svn"] url = https://url/to/your/svn/repo fetch = trunk:refs/remotes/origin/trunk branches = branches/*:refs/remotes/origin/* tags = tags/*:refs/remotes/o...
Dec 8, 12:56 pm 2007
Miklos Vajna
Re: git-svn branch naming question
On Sat, Dec 08, 2007 at 05:56:57PM +0100, Peter Baumann <waste.manager@gmx.= yes, that's exactly what i want to do - in case the target is to convert an svn repo to a git one (and i need git-svn since git-svnimport is to be removed in 1.5.4) thanks, - VMiklos
Dec 8, 7:52 pm 2007
Nicolas Pitre
Re: Something is broken in repack
Since you have a different result according to the source pack used then those cache settings, even if there was a bug with them, are not Which is quite reasonable, even if the same issue might still be there. So the problem seems to be related to the pack access code and not the repack code. And it must have something to do with the number of deltas being replayed. And because the repack is attempting delta compression roughly from newest to oldest, and because old objects are typica...
Dec 7, 9:46 pm 2007
Jon Smirl
Re: Something is broken in repack
What could be wrongly allocating 4GB of memory? Figure that out and you should have your answer. The slow down may be coming from having to search through more and more objects in memory. Memory consumption seem to be correlated to the depth of the delta chain being accessed. It blows up tremendously right at the end. It may even be a square of the length of the chain length. For the normal default case the square didn't hurt, but 250*250 = 62,500 which would eat a huge amount of memory. -- ...
Dec 7, 10:22 pm 2007
previous daytodaynext day
December 7, 2007December 8, 2007December 9, 2007
speck-geostationary