login
Header Space

 
 

Re: [PATCH] gc --aggressive: make it really aggressive

Score:
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Johannes Schindelin <Johannes.Schindelin@...>
Cc: Linus Torvalds <torvalds@...>, Daniel Berlin <dberlin@...>, David Miller <davem@...>, <ismail@...>, <gcc@...>, <git@...>, <gitster@...>
Date: Thursday, December 6, 2007 - 9:42 am

On Thu, Dec 06, 2007 at 12:03:38PM +0000, Johannes Schindelin wrote:

I'd also suggest adding a comment in the man pages that this should
only be done rarely, and that it can potentially take a *long* time
(i.e., overnight) for big repositories, and in general it's not worth
the effort to use --aggressive.

Apologies to Linus and to the gcc folks, since I was the one who
originally coded up gc --aggressive, and at the time my intent was
"rarely does it make sense, and it may take a long time".  The reason
why I didn't make the default --window and --depth larger is because
at the time the biggest repo I had easy access to was the Linux
kernel's, and there you rapidly hit diminishing returns at much
smaller numbers, so there was no real point in using --window=250
--depth=250.

Linus later pointed out that what we *really* should do is at some
point was to change repack -f to potentially retry to find a better
delta, but to reuse the existing delta if it was no worse.  That
automatically does the right thing in the case where you had
previously done a repack with --window=<large n> --depth=<large n>,
but then later try using "gc --agressive", which ends up doing a worse
job and throwing away the information from the previous repack with
large window and depth sizes.  Unfortunately no one ever got around to
implementing that.

Regards,

						- Ted
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Re: Git and GCC, David Miller, (Wed Dec 5, 10:52 pm)
Re: Git and GCC, Johannes Schindelin, (Thu Dec 6, 7:57 am)
Re: Git and GCC, Ismail , (Thu Dec 6, 8:04 am)
Re: Git and GCC, Daniel Berlin, (Wed Dec 5, 11:47 pm)
Re: Git and GCC, Harvey Harrison, (Thu Dec 6, 12:25 am)
Re: Git and GCC, Linus Torvalds, (Thu Dec 6, 12:54 am)
Re: Git and GCC, Harvey Harrison, (Thu Dec 6, 1:04 am)
Re: Git and GCC, David Miller, (Thu Dec 6, 12:20 am)
Re: Git and GCC, Daniel Berlin, (Thu Dec 6, 12:32 am)
Re: Git and GCC, David Miller, (Thu Dec 6, 12:48 am)
Re: Git and GCC, Daniel Berlin, (Thu Dec 6, 1:11 am)
Re: Git and GCC, Linus Torvalds, (Thu Dec 6, 2:09 am)
Re: Git and GCC, Jon Loeliger, (Thu Dec 6, 3:12 pm)
Re: Git and GCC, Junio C Hamano, (Thu Dec 6, 4:04 pm)
Re: Git and GCC, Junio C Hamano, (Thu Dec 6, 5:02 pm)
Re: Git and GCC, David Kastrup, (Thu Dec 6, 6:26 pm)
[OT] Re: Git and GCC, Randy Dunlap, (Thu Dec 6, 6:38 pm)
Re: Git and GCC, Linus Torvalds, (Thu Dec 6, 3:39 pm)
Re: Git and GCC, Jakub Narebski, (Thu Dec 6, 8:29 pm)
Re: Git and GCC, NightStrike, (Thu Dec 6, 2:24 pm)
Re: Git and GCC, Linus Torvalds, (Thu Dec 6, 2:45 pm)
Re: Git and GCC, NightStrike, (Fri Dec 7, 1:36 am)
Re: Git and GCC, Daniel Berlin, (Thu Dec 6, 2:04 pm)
Re: Git and GCC, Harvey Harrison, (Thu Dec 6, 10:42 pm)
Re: Git and GCC, Linus Torvalds, (Thu Dec 6, 11:01 pm)
Re: Git and GCC, Jon Smirl, (Fri Dec 7, 12:06 am)
Re: Git and GCC, Linus Torvalds, (Fri Dec 7, 1:21 am)
Re: Git and GCC, Jon Smirl, (Fri Dec 7, 3:08 am)
Re: Git and GCC, Nicolas Pitre, (Fri Dec 7, 3:36 pm)
Re: Git and GCC, Nicolas Pitre, (Fri Dec 7, 12:21 am)
Re: Git and GCC, Linus Torvalds, (Thu Dec 6, 2:29 pm)
[PATCH] gc --aggressive: make it really aggressive, Johannes Schindelin, (Thu Dec 6, 8:03 am)
Re: [PATCH] gc --aggressive: make it really aggressive, Harvey Harrison, (Thu Dec 6, 11:30 am)
Re: [PATCH] gc --aggressive: make it really aggressive, Linus Torvalds, (Thu Dec 6, 12:19 pm)
Re: [PATCH] gc --aggressive: make it really aggressive, Johannes Schindelin, (Thu Dec 6, 11:56 am)
Re: [PATCH] gc --aggressive: make it really aggressive, Pierre Habouzit, (Thu Dec 6, 10:22 am)
Re: [PATCH] gc --aggressive: make it really aggressive, Johannes Schindelin, (Thu Dec 6, 11:55 am)
Re: [PATCH] gc --aggressive: make it really aggressive, David Kastrup, (Thu Dec 6, 1:05 pm)
Re: [PATCH] gc --aggressive: make it really aggressive, Theodore Tso, (Thu Dec 6, 9:42 am)
Re: [PATCH] gc --aggressive: make it really aggressive, Nicolas Pitre, (Thu Dec 6, 10:15 am)
Re: Git and GCC, Harvey Harrison, (Thu Dec 6, 3:49 am)
Re: Git and GCC, Nicolas Pitre, (Thu Dec 6, 10:01 am)
Re: Git and GCC, David Brown, (Thu Dec 6, 4:11 am)
Re: Git and GCC, Harvey Harrison, (Thu Dec 6, 1:15 am)
Re: Git and GCC, Daniel Berlin, (Thu Dec 6, 1:17 am)
Re: Git and GCC, Jon Smirl, (Thu Dec 6, 2:47 am)
Re: Git and GCC, Jeff King, (Thu Dec 6, 3:15 am)
Re: Git and GCC, Nicolas Pitre, (Thu Dec 6, 10:18 am)
Re: Git and GCC, Jeff King, (Thu Dec 6, 1:39 pm)
Re: Git and GCC, David Miller, (Thu Dec 6, 11:31 pm)
Re: Git and GCC, Jeff King, (Fri Dec 7, 2:38 am)
Re: Git and GCC, Jon Smirl, (Fri Dec 7, 3:10 am)
Re: Git and GCC, David Miller, (Fri Dec 7, 8:53 am)
Re: Git and GCC, David Miller, (Mon Dec 10, 5:57 am)
Re: Git and GCC, Linus Torvalds, (Fri Dec 7, 1:23 pm)
Re: Git and GCC, David Miller, (Fri Dec 7, 9:55 pm)
Re: Git and GCC, Giovanni Bajo, (Fri Dec 7, 4:26 pm)
Re: Git and GCC, Jakub Narebski, (Fri Dec 7, 6:14 pm)
Re: Git and GCC, Giovanni Bajo, (Fri Dec 7, 7:14 pm)
Re: Git and GCC, Daniel Berlin, (Fri Dec 7, 7:33 pm)
Re: Git and GCC, Johannes Schindelin, (Sat Dec 8, 8:00 am)
Re: Git and GCC, Luke Lu, (Fri Dec 7, 7:04 pm)
Re: Git and GCC, Linus Torvalds, (Thu Dec 6, 2:35 pm)
Re: Git and GCC, Harvey Harrison, (Fri Dec 7, 8:47 pm)
Re: Git and GCC, Gabriel Paubert, (Mon Dec 10, 5:54 am)
Re: Git and GCC, Nicolas Pitre, (Mon Dec 10, 11:35 am)
Re: Git and GCC, Jeff King, (Fri Dec 7, 3:31 am)
Re: Git and GCC, Jon Smirl, (Thu Dec 6, 2:55 pm)
Re: Git and GCC, Nicolas Pitre, (Thu Dec 6, 3:08 pm)
Re: Git and GCC, Jon Smirl, (Thu Dec 6, 5:39 pm)
Re: Git and GCC, Nicolas Pitre, (Thu Dec 6, 6:08 pm)
Re: Git and GCC, Jon Smirl, (Thu Dec 6, 6:22 pm)
Re: Git and GCC, Nicolas Pitre, (Thu Dec 6, 6:30 pm)
Re: Git and GCC, Jon Smirl, (Thu Dec 6, 6:44 pm)
Re: Git and GCC, Jon Smirl, (Thu Dec 6, 6:11 pm)
Re: Git and GCC, Nicolas Pitre, (Thu Dec 6, 2:02 pm)
Re: Git and GCC, Jeff King, (Fri Dec 7, 2:50 am)
Re: Git and GCC, Jeff King, (Fri Dec 7, 3:27 am)
Re: Git and GCC, Harvey Harrison, (Thu Dec 6, 12:28 am)
speck-geostationary