Re: [PATCH] hooks--update: fix test for properly set up project description file

Previous thread: Re: git-merge ignore specific files by Jakub Narebski on Tuesday, November 6, 2007 - 6:03 am. (3 messages)

Next thread: [PATCH] contrib/hooks/post-receive-email: fix typo by Gerrit Pape on Tuesday, November 6, 2007 - 6:48 am. (1 message)
From: Gerrit Pape
Date: Tuesday, November 6, 2007 - 6:47 am

The update hook template intends to abort if the project description file
hasn't been adjusted or is empty.  This patch fixes the check for 'being
adjusted'.

Signed-off-by: Gerrit Pape <pape@smarden.org>
---
 templates/hooks--update |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/templates/hooks--update b/templates/hooks--update
index d8c7626..65e8c32 100644
--- a/templates/hooks--update
+++ b/templates/hooks--update
@@ -34,8 +34,8 @@ fi
 allowunannotated=$(git-repo-config --bool hooks.allowunannotated)
 
 # check for no description
-projectdesc=$(sed -e '1p' "$GIT_DIR/description")
-if [ -z "$projectdesc" -o "$projectdesc" = "Unnamed repository; edit this file to name it for gitweb" ]; then
+projectdesc=$(sed -ne '1p' "$GIT_DIR/description")
+if [ -z "$projectdesc" -o "$projectdesc" = "Unnamed repository; edit this file to name it for gitweb." ]; then
 	echo "*** Project description file hasn't been set" >&2
 	exit 1
 fi
-- 
1.5.3.5

-

From: Andreas Ericsson
Date: Tuesday, November 6, 2007 - 6:55 am

Write this as 

	projectdesc=$(sed -e 1q "$GIT_DIR/description")


I must have missed when the default updatehook got this addendum, as it's
impossible to push to a repository that isn't named with this hook in
effect. I imagine this could lead to some fun problems when trying to
push to repositories on windows machines.

-- 
Andreas Ericsson                   andreas.ericsson@op5.se
OP5 AB                             www.op5.se
Tel: +46 8-230225                  Fax: +46 8-230231
-

From: Gerrit Pape
Date: Thursday, November 8, 2007 - 7:02 am

The update hook template intends to abort if the project description file
hasn't been adjusted or is empty.  This patch fixes the check for 'being
adjusted'.

Signed-off-by: Gerrit Pape <pape@smarden.org>
---


I made it $(head -n 1 ...).


 templates/hooks--update |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/templates/hooks--update b/templates/hooks--update
index d8c7626..fbf664f 100644
--- a/templates/hooks--update
+++ b/templates/hooks--update
@@ -34,8 +34,8 @@ fi
 allowunannotated=$(git-repo-config --bool hooks.allowunannotated)
 
 # check for no description
-projectdesc=$(sed -e '1p' "$GIT_DIR/description")
-if [ -z "$projectdesc" -o "$projectdesc" = "Unnamed repository; edit this file to name it for gitweb" ]; then
+projectdesc=$(head -n 1 "$GIT_DIR/description")
+if [ -z "$projectdesc" -o "$projectdesc" = "Unnamed repository; edit this file to name it for gitweb." ]; then
 	echo "*** Project description file hasn't been set" >&2
 	exit 1
 fi
-- 
1.5.3.5

-

From: Junio C Hamano
Date: Thursday, November 8, 2007 - 3:13 pm

I even suspect that the original 'p' is indeed a typo of 'q'.
-

Previous thread: Re: git-merge ignore specific files by Jakub Narebski on Tuesday, November 6, 2007 - 6:03 am. (3 messages)

Next thread: [PATCH] contrib/hooks/post-receive-email: fix typo by Gerrit Pape on Tuesday, November 6, 2007 - 6:48 am. (1 message)