login
Header Space

 
 

Re: [PATCH 4/4] Implement git commit and status as a builtin commands.

Score:
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Kristian <krh@...>
Cc: Junio C Hamano <gitster@...>, <git@...>
Date: Monday, November 5, 2007 - 3:23 pm

On 2007.11.05 13:57:53 -0500, Kristian Høgsberg wrote:

Ah, damn. I (obviously) misread the error message as:
	foo and (bar or bar2)

IOW "and" instead of the first comma.

Actually it should be:
	if ((all && (interactive || also)) || (interactive && also))

(or whatever more simple version you come up with)


Note that there are only two commas. The asterisks catch everything and
$# won't be "t", so that catches anything with at least two t's.

Also note, that the two checks after that one in git-commit.sh as of the
current master (140dd77a5cb2e61dcb942e245a2474fae95e42a5) are broken
(I'll send a patch in a separate mail).


--include is not in the manpage, and I only glanced over git-commit.sh,
but yeah, at least to me, that sounds right.

Björn
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH 1/4] Add testcase for ammending and fixing author in ..., Kristian Høgsberg, (Fri Nov 2, 11:33 am)
[PATCH 2/4] Remove unecessary hard-coding of EDITOR=':' VISU..., Kristian Høgsberg, (Fri Nov 2, 11:33 am)
[PATCH 3/4] Export launch_editor() and make it accept ':' as..., Kristian Høgsberg, (Fri Nov 2, 11:33 am)
[PATCH 4/4] Implement git commit and status as a builtin com..., Kristian Høgsberg, (Fri Nov 2, 11:33 am)
Re: [PATCH 4/4] Implement git commit and status as a builtin..., Björn, (Mon Nov 5, 3:23 pm)
Re: [PATCH 4/4] Implement git commit and status as a builtin..., Johannes Schindelin, (Mon Nov 5, 7:18 pm)
Re: [PATCH 4/4] Implement git commit and status as a builtin..., Johannes Schindelin, (Sat Nov 3, 9:56 am)
speck-geostationary