Re: [PATCH 1/2] Added basic color support to git add --interactive | KernelTrap

Re: [PATCH 1/2] Added basic color support to git add --interactive

view
thread

!MAILaRCHIVE_VOTE_RePLACE

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

[view in full thread]

From: Jeff King <peff@...>

To: Junio C Hamano <gitster@...>

Cc: Dan Zwell <dzwell@...>, Shawn O. Pearce <spearce@...>, Wincent Colaiuta <win@...>, Git Mailing List <git@...>, Jonathan del Strother <maillist@...>, Johannes Schindelin <Johannes.Schindelin@...>, Frank Lichtenheld <frank@...>

Subject: Re: [PATCH 1/2] Added basic color support to git add --interactive

Date: Sunday, November 4, 2007 - 1:43 am

On Sat, Nov 03, 2007 at 10:36:00PM -0700, Junio C Hamano wrote:

quoted text> I think you would end up spitting out:
> 
>         COLOR something RESET LF COLOR RESET LF
> 
> instead of:
> 
> 	COLOR something RESET LF LF
> 
> when you get "something\n\n" if you did that.  Not a big deal,
> though, as at this point we would be human I/O bound.

Yes, though I wonder if the former is "more correct" in the sense that
we don't know what the attributes are doing, and maybe it matters for
them to apply to each line, whether it has text or not.

But I don't think it's possible for a blank line to actually do anything
with the attributes we're currently allowing, and we don't have any
plans to allow arbitrary terminal control codes in the color specs, so
it probably doesn't matter.

-Peff
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:

[PATCH] Color support added to git-add--interactive., Dan Zwell, (Sat Oct 13, 12:13 am)

Re: [PATCH] Color support added to git-add--interactive., Johannes Schindelin, (Sat Oct 13, 8:25 am)

Re: [PATCH] Color support added to git-add--interactive., Jeff King, (Sat Oct 13, 4:12 am)

Re: [PATCH] Color support added to git-add--interactive., Frank Lichtenheld, (Sat Oct 13, 8:49 am)

Re: [PATCH] Color support added to git-add--interactive., Wincent Colaiuta, (Sat Oct 13, 10:45 am)

Re: [PATCH] Color support added to git-add--interactive., Johannes Schindelin, (Sat Oct 13, 12:38 pm)

Re: [PATCH] Color support added to git-add--interactive., Jean-Luc Herren, (Sat Oct 13, 12:38 pm)

Re: [PATCH] Color support added to git-add--interactive., Wincent Colaiuta, (Sat Oct 13, 1:14 pm)

Re: [PATCH] Color support added to git-add--interactive., Andreas Ericsson, (Sat Oct 13, 2:31 pm)

Re: [PATCH] Color support added to git-add--interactive., Jeff King, (Mon Oct 15, 12:12 am)

Re: [PATCH] Color support added to git-add--interactive., Jeff King, (Sat Oct 13, 1:27 pm)

Re: [PATCH] Color support added to git-add--interactive., Jeff King, (Sat Oct 13, 1:51 pm)

Re: [PATCH] Color support added to git-add--interactive., Dan Zwell, (Sat Oct 13, 4:03 pm)

Re: [PATCH] Color support added to git-add--interactive., Wincent Colaiuta, (Sat Oct 13, 4:36 pm)

Re: [PATCH] Color support added to git-add--interactive., Dan Z, (Sat Oct 13, 5:50 pm)

Re: [PATCH] Color support added to git-add--interactive., Jean-Luc Herren, (Sat Oct 13, 6:23 pm)

Re: [PATCH] Color support added to git-add--interactive., Jeff King, (Sun Oct 14, 11:43 pm)

Re: revised: [PATCH] Color support added to git-add--interac..., Dan Zwell, (Tue Oct 16, 8:47 pm)

Re: revised: [PATCH] Color support added to git-add--interac..., Shawn O. Pearce, (Tue Oct 16, 9:51 pm)

Re: revised: [PATCH] Color support added to git-add--interac..., Dan Zwell, (Wed Oct 17, 3:57 am)

Re: revised: [PATCH] Color support added to git-add--interac..., Shawn O. Pearce, (Wed Oct 17, 4:11 am)

[PATCH 2/2] Let git-add--interactive read colors from git-co..., Dan Zwell, (Mon Oct 22, 5:40 pm)

Re: [PATCH 2/2] Let git-add--interactive read colors from gi..., Jeff King, (Tue Oct 23, 12:27 am)

Re: [PATCH 2/2] Let git-add--interactive read colors from gi..., Dan Zwell, (Tue Oct 23, 4:52 am)

[PATCH 2/2] Let git-add--interactive read colors from .gitco..., Dan Zwell, (Fri Nov 2, 11:41 pm)

Re: *[PATCH 2/2] Let git-add--interactive read colors from ...., Junio C Hamano, (Sat Nov 3, 1:06 am)

Re: *[PATCH 2/2] Let git-add--interactive read colors from ...., Dan Zwell, (Sat Nov 3, 3:26 am)

Re: *[PATCH 2/2] Let git-add--interactive read colors from ...., Junio C Hamano, (Sat Nov 3, 2:11 pm)

[PATCH 1/2] Added basic color support to git add --interactive, Dan Zwell, (Fri Nov 2, 11:41 pm)

Re: [PATCH 1/2] Added basic color support to git add --inter..., Jeff King, (Sun Nov 4, 12:57 am)

Re: [PATCH 1/2] Added basic color support to git add --inter..., Junio C Hamano, (Sun Nov 4, 1:36 am)

Re: [PATCH 1/2] Added basic color support to git add --inter..., Jeff King, (Sun Nov 4, 1:43 am)

Subject: [PATCH 2/3] Let git-add--interactive read colors fr..., Dan Zwell, (Sat Nov 10, 10:23 pm)

Re: Subject: [PATCH 2/3] Let git-add--interactive read color..., Junio C Hamano, (Sun Nov 11, 5:53 am)

Re: Subject: [PATCH 2/3] Let git-add--interactive read color..., Junio C Hamano, (Sun Nov 11, 6:34 am)

Re: Subject: [PATCH 2/3] Let git-add--interactive read color..., Dan Zwell, (Mon Nov 12, 9:39 pm)

Re: Subject: [PATCH 2/3] Let git-add--interactive read color..., Junio C Hamano, (Mon Nov 12, 10:32 pm)

Re: Subject: [PATCH 2/3] Let git-add--interactive read color..., Dan Zwell, (Mon Nov 12, 10:55 pm)

Re: Subject: [PATCH 2/3] Let git-add--interactive read color..., Jeff King, (Tue Nov 13, 3:26 am)

Subject: [PATCH 1/3] Added basic color support to git add --..., Dan Zwell, (Sat Nov 10, 10:23 pm)

[PATCH 0/3] Adding colors to git-add--interactive, Dan Zwell, (Sat Nov 10, 10:21 pm)

[PATCH 3/3] Added diff hunk coloring to git-add--interactive, Dan Zwell, (Sat Nov 10, 8:03 pm)

Re: [PATCH 3/3] Added diff hunk coloring to git-add--interac..., Junio C Hamano, (Sun Nov 11, 6:00 am)

[PATCH 2/3] Let git-add--interactive read colors from .gitco..., Dan Zwell, (Sat Nov 10, 8:02 pm)

[PATCH 1/3] Added basic color support to git add --interactive, Dan Zwell, (Sat Nov 10, 8:01 pm)

[PATCH 0/3] Adding colors to git-add--interactive, Dan Zwell, (Sat Nov 10, 8:01 pm)

[PATCH 5/5] Added diff hunk coloring to git-add--interactive, Dan Zwell, (Thu Nov 22, 6:56 am)

Re: [PATCH 5/5] Added diff hunk coloring to git-add--interac..., Jeff King, (Thu Nov 22, 8:25 am)

Re: [PATCH 5/5] Added diff hunk coloring to git-add--interac..., Junio C Hamano, (Thu Nov 22, 6:35 pm)

Re: [PATCH 5/5] Added diff hunk coloring to git-add--interac..., Junio C Hamano, (Thu Nov 22, 5:37 pm)

Re: [PATCH 5/5] Added diff hunk coloring to git-add--interac..., Jeff King, (Fri Nov 23, 6:21 am)

[PATCH 4/5] Let git-add--interactive read colors from config..., Dan Zwell, (Thu Nov 22, 6:56 am)

Re: [PATCH 4/5] Let git-add--interactive read colors from co..., Jeff King, (Thu Nov 22, 8:18 am)

Re: [PATCH 4/5] Let git-add--interactive read colors from co..., Junio C Hamano, (Thu Nov 22, 5:28 pm)

Re: [PATCH 4/5] Let git-add--interactive read colors from co..., Jeff King, (Thu Nov 22, 6:30 pm)

Re: [PATCH 4/5] Let git-add--interactive read colors from co..., Dan Zwell, (Fri Nov 23, 1:32 am)

Re: [PATCH 4/5] Let git-add--interactive read colors from co..., Jeff King, (Fri Nov 23, 5:09 am)

Re: [PATCH 4/5] Let git-add--interactive read colors from co..., Junio C Hamano, (Fri Nov 23, 5:17 am)

[PATCH 3/5] Added config_default($key, $default) to Git.pm, Dan Zwell, (Thu Nov 22, 6:55 am)

Re: [PATCH 3/5] Added config_default($key, $default) to Git.pm, Jeff King, (Thu Nov 22, 8:14 am)

[PATCH 2/5] Don't return 'undef' in case called in a vector ..., Dan Zwell, (Thu Nov 22, 6:55 am)

Re: [PATCH 2/5] Don't return 'undef' in case called in a vec..., Junio C Hamano, (Thu Nov 22, 5:17 pm)

Re: [PATCH 2/5] Don't return 'undef' in case called in a vec..., Dan Zwell, (Fri Nov 23, 12:15 am)

Re: [PATCH 2/5] Don't return 'undef' in case called in a vec..., Jeff King, (Thu Nov 22, 8:06 am)

[PATCH 1/5] Added basic color support to git add --interactive, Dan Zwell, (Thu Nov 22, 6:54 am)

[PATCH 0/5] Colors for git-add--interactive, Dan Zwell, (Thu Nov 22, 6:54 am)

Re: [PATCH 0/5] Colors for git-add--interactive, Junio C Hamano, (Thu Nov 22, 3:20 pm)

Re: [PATCH 0/5] Colors for git-add--interactive, Jeff King, (Thu Nov 22, 7:57 am)

Re: [PATCH 0/3] Adding colors to git-add--interactive, Jeff King, (Sun Nov 11, 3:54 am)

Re: [PATCH 0/3] Adding colors to git-add--interactive, Junio C Hamano, (Sun Nov 11, 4:23 am)

Re: [PATCH 0/3] Adding colors to git-add--interactive, Dan Zwell, (Sun Nov 11, 4:39 am)

[PATCH 1/2] Added basic color support to git add --interactive, Dan Zwell, (Mon Oct 22, 5:32 pm)

Re: [PATCH 1/2] Added basic color support to git add --inter..., Jeff King, (Tue Oct 23, 12:03 am)

Re: [PATCH 1/2] Added basic color support to git add --inter..., Wincent Colaiuta, (Tue Oct 23, 2:28 am)

Re: [PATCH 1/2] Added basic color support to git add --inter..., Jeff King, (Tue Oct 23, 2:41 am)

Re: [PATCH 1/2] Added basic color support to git add --inter..., Wincent Colaiuta, (Tue Oct 23, 3:44 am)

[PATCH] Let git-add--interactive read "git colors" from git-..., Dan Zwell, (Mon Oct 22, 10:19 pm)

Re: [PATCH] Let git-add--interactive read "git colors" from ..., Jeff King, (Tue Oct 23, 12:29 am)

Re: [PATCH] Let git-add--interactive read "git colors" from ..., Shawn O. Pearce, (Tue Oct 23, 12:40 am)

Re: [PATCH] resend of git-add--interactive color patch again..., Dan Zwell, (Mon Oct 22, 10:11 pm)

Re: [PATCH] Color support added to git-add--interactive., Tom Tobin, (Sat Oct 13, 4:21 pm)

Re: [PATCH] Color support added to git-add--interactive., Tom Tobin, (Sat Oct 13, 4:26 pm)

Navigation

Popular discussions


linux-kernel:
david	Re: Dual-Licensing Linux Kernel with GPL V2 and GPL V3
Greg Kroah-Hartman	[PATCH 005/196] Chinese: add translation of SubmittingDrivers
Vladislav Bolkhovitin	Re: Integration of SCST in the mainstream Linux kernel
Jan Engelhardt	intel iommu (Re: -mm merge plans for 2.6.23)
git:

openbsd-misc:

linux-netdev:
David Miller	[GIT]: Networking
David Miller	Re: [PATCH] pkt_sched: Destroy gen estimators under rtnl_lock().
Gerrit Renker	[PATCH 27/37] dccp: Integration of dynamic feature activation - part 2 (server side)
Natalie Protasevich	[BUG] New Kernel Bugs

Colocation donated by:

Who's online

There are currently 0 users and 557 guests online.

Syndicate