login
Header Space

 
 

Re: [PATCH 1/3] send-pack: track errors for each ref

Score:
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Daniel Barkalow <barkalow@...>
Cc: Junio C Hamano <gitster@...>, <git@...>, Alex Riesen <raa.lkml@...>, Pierre Habouzit <madcoder@...>
Date: Saturday, November 17, 2007 - 8:13 pm

On Sat, Nov 17, 2007 at 01:05:35PM -0500, Daniel Barkalow wrote:


Yes, I also considered changing "from" to "show peer" which might have
been nicer. I am not opposed to such a cleanup, but again, not sure if
it worth it now that we are merged.


I agree, though I don't feel qualified to comment on what other places
that should be used (I was a bit surprised to find out that
find_unique_abbrev ever returned NULL, but changing the semantics at
this point is probably going to cause some subtle bug).


Oops, yes. I think it should be hard to trigger (both commits would have
to either not be in your db, or not be unique to 40 digits). But clearly
it should be fixed, and it looks like Junio did.

It was a stupid cut-and-paste from Nicolas' fetch code, but it looks
like he correctly allocates 84 bytes for the "..." case.


Sorry, I don't see the style nit you're mentioning here.

-Peff
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH v3 0/3] tracking per-ref errors on push, Jeff King, (Sat Nov 17, 8:53 am)
Re: [PATCH 3/3] send-pack: assign remote errors to each ref, Junio C Hamano, (Sun Nov 18, 12:47 am)
Re: [PATCH 3/3] send-pack: assign remote errors to each ref, Daniel Barkalow, (Sat Nov 17, 2:05 pm)
[PATCH 1/3] send-pack: track errors for each ref, Jeff King, (Sat Nov 17, 8:54 am)
Re: [PATCH 1/3] send-pack: track errors for each ref, Junio C Hamano, (Sat Nov 17, 4:53 pm)
Re: [PATCH 1/3] send-pack: track errors for each ref, Daniel Barkalow, (Sat Nov 17, 2:05 pm)
Re: [PATCH 1/3] send-pack: track errors for each ref, Jeff King, (Sat Nov 17, 8:13 pm)
Re: [PATCH 1/3] send-pack: track errors for each ref, Junio C Hamano, (Sat Nov 17, 9:21 pm)
Re: [PATCH 1/3] send-pack: track errors for each ref, Jeff King, (Sat Nov 17, 11:12 pm)
Re: [PATCH 1/3] send-pack: track errors for each ref, Alex Riesen, (Sat Nov 17, 9:34 am)
speck-geostationary