Re: [PATCH 3/3] send-pack: assign remote errors to each ref

view
thread

!MAILaRCHIVE_VOTE_RePLACE

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

[view in full thread]

From: Jeff King <peff@...>

To: Daniel Barkalow <barkalow@...>

Cc: Junio C Hamano <gitster@...>, <git@...>, Alex Riesen <raa.lkml@...>, Pierre Habouzit <madcoder@...>

Subject: Re: [PATCH 3/3] send-pack: assign remote errors to each ref

Date: Saturday, November 17, 2007 - 8:03 pm

On Sat, Nov 17, 2007 at 01:05:29PM -0500, Daniel Barkalow wrote:

quoted text> Maybe this should take both the full list and the hint and do both passes 
> internally? IMHO, the logic in receive_status() looks like it might be 
> setting the error twice or not at all, unless you read very carefully.

Not unreasonable, though I started in that direction and it ended up
being less readable (which isn't to say that it's not possible). But it
looks like Junio has merged to next, so I think it is best to leave it
as-is.

-Peff
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:

[PATCH v3 0/3] tracking per-ref errors on push, Jeff King, (Sat Nov 17, 8:53 am)

[PATCH 3/3] send-pack: assign remote errors to each ref, Jeff King, (Sat Nov 17, 8:56 am)

Re: [PATCH 3/3] send-pack: assign remote errors to each ref, Junio C Hamano, (Sat Nov 17, 9:03 pm)

Re: [PATCH 3/3] send-pack: assign remote errors to each ref, Jeff King, (Sat Nov 17, 10:39 pm)

Re: [PATCH 3/3] send-pack: assign remote errors to each ref, Junio C Hamano, (Sun Nov 18, 12:47 am)

Re: [PATCH 3/3] send-pack: assign remote errors to each ref, Jeff King, (Sun Nov 18, 1:00 am)

Re: [PATCH 3/3] send-pack: assign remote errors to each ref, Daniel Barkalow, (Sat Nov 17, 2:05 pm)

Re: [PATCH 3/3] send-pack: assign remote errors to each ref, Jeff King, (Sat Nov 17, 8:03 pm)

[PATCH 2/3] send-pack: check ref->status before updating ..., Jeff King, (Sat Nov 17, 8:55 am)

Re: [PATCH 2/3] send-pack: check ref->status before updat..., Daniel Barkalow, (Sat Nov 17, 2:05 pm)

Re: [PATCH 2/3] send-pack: check ref->status before updat..., Alex Riesen, (Sat Nov 17, 9:45 am)

Re: [PATCH 2/3] send-pack: check ref->status before updat..., Jeff King, (Sat Nov 17, 9:53 am)

[PATCH 1/3] send-pack: track errors for each ref, Jeff King, (Sat Nov 17, 8:54 am)

Re: [PATCH 1/3] send-pack: track errors for each ref, Junio C Hamano, (Sat Nov 17, 4:53 pm)

Re: [PATCH 1/3] send-pack: track errors for each ref, Jeff King, (Sat Nov 17, 8:15 pm)

Re: [PATCH 1/3] send-pack: track errors for each ref, Daniel Barkalow, (Sat Nov 17, 2:05 pm)

Re: [PATCH 1/3] send-pack: track errors for each ref, Jeff King, (Sat Nov 17, 8:13 pm)

Re: [PATCH 1/3] send-pack: track errors for each ref, Junio C Hamano, (Sat Nov 17, 9:21 pm)

Re: [PATCH 1/3] send-pack: track errors for each ref, Jeff King, (Sat Nov 17, 11:12 pm)

Re: [PATCH 1/3] send-pack: track errors for each ref, Alex Riesen, (Sat Nov 17, 9:34 am)

Navigation

Popular discussions


linux-kernel:
monstr	[PATCH 11/60] microblaze_v4: cache support
Andrew Morton	Re: x86: 4kstacks default
Greg KH	[GIT PATCH] driver core patches against 2.6.24
Alan Cox	Re: Dual-Licensing Linux Kernel with GPL V2 and GPL V3
git:

linux-netdev:
Jarek Poplawski	[PATCH] pkt_sched: Destroy gen estimators under rtnl_lock().
Ben Hutchings	Re: [GIT]: Networking
Gerrit Renker	[PATCH 03/37] dccp: List management for new feature negotiation
Jiri Olsa	[PATCHv5 0/2] net: fix race in the receive/select
openbsd-misc:

Colocation donated by: