Home » Mailing list archives » git » 2007 » November » 13

[PATCH 07/11] builtin run_command: do not exit with -1.

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Johannes Sixt <johannes.sixt@...>
To: Junio C Hamano <gitster@...>
Cc: <git@...>, Johannes Sixt <johannes.sixt@...>
Subject: [PATCH 07/11] builtin run_command: do not exit with -1.
Date: Tuesday, November 13, 2007 - 4:05 pm

There are shells that do not correctly detect an exit code of -1 as a
failure. We simply truncate the status code to the lower 8 bits.

Signed-off-by: Johannes Sixt <johannes.sixt@telecom.at>
---
 git.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/git.c b/git.c
index 4a250f7..37d99d6 100644
--- a/git.c
+++ b/git.c
@@ -256,7 +256,7 @@ static int run_command(struct cmd_struct *p, int argc, const char **argv)
 
 	status = p->fn(argc, argv, prefix);
 	if (status)
-		return status;
+		return status & 0xff;
 
 	/* Somebody closed stdout? */
 	if (fstat(fileno(stdout), &st))
-- 
1.5.3.5.1592.g0d6db

-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH 07/11] builtin run_command: do not exit with -1., Johannes Sixt, (Tue Nov 13, 4:05 pm)
[PATCH 08/11] Close files opened by lock_file() before unlin..., Johannes Sixt, (Tue Nov 13, 4:05 pm)
Re: [PATCH 08/11] Close files opened by lock_file() before u..., Johannes Schindelin, (Tue Nov 13, 5:05 pm)
[PATCH 09/11] Allow a relative builtin template directory., Johannes Sixt, (Tue Nov 13, 4:05 pm)