Home » Mailing list archives » git » 2007 » November » 13

Re: Subject: [PATCH 2/3] Let git-add--interactive read colors from .gitconfig

Previous thread: The 5th issue of the msysGit Herald by Johannes Schindelin on Monday, November 12, 2007 - 11:13 pm. (1 message)

Next thread: [PATCH] Handle broken vsnprintf implementations in strbuf by Shawn O. Pearce on Tuesday, November 13, 2007 - 4:22 am. (1 message)
[view original message]
From: Junio C Hamano <gitster@...>
To: Dan Zwell <dzwell@...>
Cc: Johannes Schindelin <Johannes.Schindelin@...>, Frank Lichtenheld <frank@...>, Jeff King <peff@...>, Shawn O. Pearce <spearce@...>, Jonathan del Strother <maillist@...>, Git Mailing List <git@...>, Wincent Colaiuta <win@...>
Subject: Re: Subject: [PATCH 2/3] Let git-add--interactive read colors from .gitconfig
Date: Tuesday, November 13, 2007 - 3:29 am

But the point is, that you are not ignoring invalid color names

but instead giving back a random match aren't you?

-
[view original message]
From: Dan Zwell <dzwell@...>
To: Junio C Hamano <gitster@...>
Cc: Dan Zwell <dzwell@...>, Johannes Schindelin <Johannes.Schindelin@...>, Frank Lichtenheld <frank@...>, Jeff King <peff@...>, Shawn O. Pearce <spearce@...>, Jonathan del Strother <maillist@...>, Git Mailing List <git@...>, Wincent Colaiuta <win@...>
Subject: Re: Subject: [PATCH 2/3] Let git-add--interactive read colors from .gitconfig
Date: Tuesday, November 13, 2007 - 4:25 am

No, if there's no match, the token is ignored. False matches are

possible in some cases (the bogus config option "colored" would match

"red", for example), so I will follow your suggestion with the hash,

after all. I'll send out the next revised patches in a day or two--I've

made most of the changes you and Jeff suggested, but I need to double check.


Dan

-
Previous thread: The 5th issue of the msysGit Herald by Johannes Schindelin on Monday, November 12, 2007 - 11:13 pm. (1 message)

Next thread: [PATCH] Handle broken vsnprintf implementations in strbuf by Shawn O. Pearce on Tuesday, November 13, 2007 - 4:22 am. (1 message)