git mailing list

FromSubjectsort iconDate
Jakub Narebski
Re: wishlist: git info
Perhaps also project description (if it exists?) -- Jakub Narebski Warsaw, Poland ShadeHawk on #git -
Nov 12, 7:46 pm 2007
Jakub Narebski
Re: git config error message
And neither does per-user config file (I triet to reproduce this error, and forgot about ~/.gitconfig file). -- Jakub Narebski Warsaw, Poland ShadeHawk on #git -
Nov 12, 7:09 pm 2007
Jakub Narebski
Re: Cloning empty repositories, was Re: What is the idea for...
Do I remember correctly that there was some talk about extending git protocol to avoid this compicated dance, and transfer symbolic refs directly? -- Jakub Narebski Warsaw, Poland ShadeHawk on #git -
Nov 12, 6:49 pm 2007
Alex Riesen
[PATCH] Beautify the output of send-pack a bit
Cluster the errors regarding ancestry violation and output them in one batch, together with a hint to pull before pushing. Signed-off-by: Alex Riesen <raa.lkml@gmail.com> --- Catching trend... send-pack.c | 33 ++++++++++++++++++++++----------- 1 files changed, 22 insertions(+), 11 deletions(-) diff --git a/send-pack.c b/send-pack.c index d56d980..e6da567 100644 --- a/send-pack.c +++ b/send-pack.c @@ -215,6 +215,7 @@ static int send_pack(int in, int out, struct remote *remote, in...
Nov 12, 6:11 pm 2007
Alex Riesen
[PATCH] Add a test checking if send-pack updated local track...
Signed-off-by: Alex Riesen <raa.lkml@gmail.com> --- t/t5404-tracking-branches.sh | 40 ++++++++++++++++++++++++++++++++++++++++ 1 files changed, 40 insertions(+), 0 deletions(-) create mode 100755 t/t5404-tracking-branches.sh diff --git a/t/t5404-tracking-branches.sh b/t/t5404-tracking-branches.sh new file mode 100755 index 0000000..20718d4 --- /dev/null +++ b/t/t5404-tracking-branches.sh @@ -0,0 +1,40 @@ +#!/bin/sh + +test_description='tracking branch update checks for git push' +...
Nov 12, 5:38 pm 2007
Alex Riesen
[PATCH] Update the tracking references only if they were suc...
It fixes the bug where local tracing branches were filled with zeroed SHA-1 if the remote branch was not updated because, for instance, it was not an ancestor of the local (i.e. had other changes). Signed-off-by: Alex Riesen <raa.lkml@gmail.com> --- Jeff, I think your change (334f4831e5a77) was either not complete or got broken some time later. send-pack.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/send-pack.c b/send-pack.c index b74fd45..d56d980 10064...
Nov 12, 5:39 pm 2007
Emil Medve
[PATCH] Fix a strchrnul() related build error
Systems/environments without glibc (such as CygWin), and as a consequence whithout the __GLIBC_PREREQ() macro, fail to build with the following error message: CC git.o In file included from builtin.h:4, from git.c:1: git-compat-util.h:187:48: missing binary operator before token "(" Signed-off-by: Emil Medve <Emilian.Medve@Freescale.com> --- Here is a relevant comment from my Linux box features.h: /* Convenience macros to test the versions of glibc and gcc. Us...
Nov 12, 5:01 pm 2007
Johannes Schindelin
Re: [PATCH] Fix a strchrnul() related build error
Hi, didn't Johannes Sixt provide a (slightly nicer) patch earlier today? Ciao, Dscho -
Nov 12, 5:27 pm 2007
Medve Emilian
RE: [PATCH] Fix a strchrnul() related build error
That is nicer and should go into the tree. Cheers, Emil. -
Nov 12, 6:12 pm 2007
Kristian Høgsberg
[PATCH] Call refresh_cache() when updating the user index fo...
We're guaranteeing the user that the index will be stat-clean after git commit. Thus, we need to call refresh_cache() for the user index too, in the 'git commit <paths>' case. Signed-off-by: Kristian Høgsberg <krh@redhat.com> --- builtin-commit.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/builtin-commit.c b/builtin-commit.c index 5011b8b..35205ef 100644 --- a/builtin-commit.c +++ b/builtin-commit.c @@ -109,6 +109,7 @@ static char *prepare_index(const...
Nov 12, 4:48 pm 2007
Junio C Hamano
Re: [PATCH] Call refresh_cache() when updating the user inde...
Ah. This is the real index file that is left for the user after a partial commit "git-commit <path>" returns. The other refresh_cache() after this one does not matter if we did not have hook scripts, but it is not very easy to cheaply detect if we are not going to run any hooks so let's leave it there. Thanks. -
Nov 12, 7:01 pm 2007
Thomas Neumann
wishlist: git info
Hi, while git is pleasant to use in everyday work, there is one svn feature which is miss dearly, namely "svn info". svn info can give information about specific file objects, but I think its main feature is to use it without any path and thus just describe the current project. I use this a lot to quickly find out to which remote repository the current directory belongs (yes, some work projects tend to look very similar...) and what is the current state of the directory. As a crude approximation...
Nov 12, 4:30 pm 2007
Alex Riesen
Re: wishlist: git info
[Empty message]
Nov 12, 6:21 pm 2007
Thomas Neumann
Re: wishlist: git info
hm, this is not what I am after. I do not want to inspect the history, I want to see where this repository "belongs" to. Gitk shows me the name (which is reasonable, of course), but not the URL. And it is a GUI probably "current working directory" was not the best way to phrase it. I mean state of the repository, which in my case is a clone of a central repository. My commands show (ignoring formatting): 1. the remote repositories with URL 2. the current head commit hash 3. the date of the head commi...
Nov 12, 6:50 pm 2007
Alex Riesen
Re: wishlist: git info
...which in Git-lingo would be misunderstood as the output of Ach, make it "git remote -v". It does exactly showing of the url. Dunno what I wanted the "-r" for. Probably left from thinking of It is there since 1.5.3-rc1 -
Nov 12, 7:41 pm 2007
Remi Vanicat
[PATCH] Make GIT_INDEX_FILE apply to git-commit
Currently, when committing, git-commit ignore the value of GIT_INDEX_FILE, and always use $GIT_DIR/index. This patch fix it. Signed-off-by: Rémi Vanicat <vanicat@debian.org> --- git-commit.sh | 2 +- t/t7500-commit.sh | 32 ++++++++++++++++++++++++++++++++ 2 files changed, 33 insertions(+), 1 deletions(-) diff --git a/git-commit.sh b/git-commit.sh index fcb8443..7022e6c 100755 --- a/git-commit.sh +++ b/git-commit.sh @@ -26,7 +26,7 @@ refuse_partial () { } TMP_INDEX=...
Nov 12, 2:45 pm 2007
Junio C Hamano
Re: [PATCH 2/3] Implement --dirty for git-rebase--interactive.
This forces the user to pay the two rev-list overhead, even when running rebase without --dirty option. Can we avoid paying any, when not giving the option? Also it pollutes the reflog of the branch, but that won't be a huge issue with Dscho's "detach HEAD while rebasing" patch. -
Nov 12, 3:51 pm 2007
Junio C Hamano
Re: [PATCH 4/6] add ref_abbrev_matches_full_with_rules()
How about calling this simply "ref_abbrev_matches()" or "refname_match()" which is even shorter? -
Nov 12, 3:51 pm 2007
Steffen Prohaska
Re: [PATCH 4/6] add ref_abbrev_matches_full_with_rules()
Yes. As you already did on pu. Thanks for cleaning up. Steffen -
Nov 12, 4:51 pm 2007
Junio C Hamano
Re: [PATCH 5/6] push: use same rules as git-rev-parse to res...
I vaguely recall that in the old round this check used to be without negation '!' in the front. I think this version is correct. -
Nov 12, 3:51 pm 2007
Steffen Prohaska
Re: [PATCH 5/6] push: use same rules as git-rev-parse to res...
Yes. I started with a syntax inspired by strcmp. But later the function got match in its name. I think returning a match with 'true' is more natural; and reserving '-1, 0, 1' for compare (as in strcmp). Therefore I changed the return value. With '!' is correct now. Without '!' was correct before. Steffen -
Nov 12, 4:48 pm 2007
David Kastrup
Re: Cloning empty repositories, was Re: What is the idea for...
git-init does not perform sexual intercourse, either. I don't see why geneticists should be relevant for determining what git-clone does. -- David Kastrup -
Nov 12, 1:32 pm 2007
Jakub Narebski
Re: What is the idea for bare repositories?
Note that "git --bare init" and "git init --bare" are two *different* things (first is no-op, by the way). -- Jakub Narebski Warsaw, Poland ShadeHawk on #git -
Nov 12, 12:39 pm 2007
Jakub Narebski
Re: What is the idea for bare repositories?
git-diff can compare tree and tree, or tree and index; only for comparing tree and files of index and files it needs working dir. git-reset resets only refs and index. git-reset --hard resets also files, so it needs working directory. Perhaps it should fail completely and not only after doing mixed (non-hard) reset if we are in bare repository. -- Jakub Narebski Warsaw, Poland ShadeHawk on #git -
Nov 12, 12:37 pm 2007
David Kastrup
Re: What is the idea for bare repositories?
Well, if called without arguments (as above), it compares tree and Please reread the above: it does not fail at all. Neither before nor after the mixed reset. -- David Kastrup -
Nov 12, 12:54 pm 2007
David D. Kilzer
[RFC PATCH] git-svn info: implement info command
Implement "git-svn info" for files and directories based on the "svn info" command. Note that the -r/--revision argument is not supported yet. Added 18 tests in t/t9117-git-svn-info.sh. Signed-off-by: David D. Kilzer <ddkilzer@kilzer.net> --- Looking for feedback on this patch. Specifically, I'm looking for insight for the two FIXME comments in the cmd_info() function added to git-svn. (I can't help but think I'm missing a plumbing command or a basic concept. Pointers to code, web page...
Nov 12, 12:19 pm 2007
David Kastrup
Re: What is the idea for bare repositories?
Fine. So why don't the following commands complain? Apart from git-reset without arguments (which could probably get along without a -- David Kastrup -
Nov 12, 12:17 pm 2007
Jakub Narebski
Re: [PATCH] status&commit: Teach them to show submodule ...
Or status.submodule.summary, although we usually use section.<variable_sub>.key configuration variables, e.g. branch.<name>.remote. But we have exception: color.branch.<slot> -- Jakub Narebski Warsaw, Poland ShadeHawk on #git -
Nov 12, 12:12 pm 2007
Ping Yin
Re: [PATCH] status&commit: Teach them to show submodule ...
maybe submodule.status.summary better? later new variables can be added easily such as -- Ping Yin -
Nov 12, 12:42 pm 2007
Andy Whitcroft
[PATCH] push mirroring update test titles
Fix up the test titles which are incorrectly in the negative. Signed-off-by: Andy Whitcroft <apw@shadowen.org> --- This probabally should be folded down into the current tests patch. If you want me to do that and resubmit, yell at me. t/t5517-push-mirror.sh | 20 ++++++++++---------- 1 files changed, 10 insertions(+), 10 deletions(-) diff --git a/t/t5517-push-mirror.sh b/t/t5517-push-mirror.sh index 0fc6778..ed3fec1 100755 --- a/t/t5517-push-mirror.sh +++ b/t/t5517-push-mirror.sh...
Nov 12, 11:48 am 2007
David D. Kilzer
[PATCH] git-send-email: show all headers when sending mail
As a git newbie, it was confusing to set an In-Reply-To header but then not see it printed when the git-send-email command was run. This patch prints all headers that would be sent to sendmail or an SMTP server instead of only printing From, Subject, Cc, To. It also removes the now-extraneous Date header after the "Log says" line. Added test to t/t9001-send-email.sh. Signed-off-by: David D. Kilzer <ddkilzer@kilzer.net> --- I'd like to see this applied to the maint branch. git-send...
Nov 12, 12:01 pm 2007
Jakub Narebski
Re: [PATCH] status&commit: Teach them to show submodule ...
Shouldn't you also modify Documentation/config.txt ? -- Jakub Narebski Warsaw, Poland ShadeHawk on #git -
Nov 12, 11:37 am 2007
Ping Yin Nov 12, 11:46 am 2007
Jon Smirl
git config error message
I'm not in a git repo, this error message is misleading. jonsmirl@terra:~/foo$ git config remote.origin.url http://git.digispeaker.com/projects/digispeaker-kernel.git could not lock config file -- Jon Smirl jonsmirl@gmail.com -
Nov 12, 11:35 am 2007
Alex Riesen
Re: git config error message
Cygwin or any crashes in this repo lately? If cygwin, than we probably have a file handle leak in config code. -
Nov 12, 6:23 pm 2007
Johannes Schindelin
Re: git config error message
Hi, He said that he's not in a git repo. Thus, .git/config does not exist, and is not lockable, since not even .git/ exists. Ciao, Dscho -
Nov 12, 6:24 pm 2007
Alex Riesen Nov 12, 6:26 pm 2007
Adrian Wilkins
BUG: git-svn does not escape literal backslashes in author n...
Recently converted a large (11,000+ revisions) repository. We authenticate against the NT domain controller, so all our revision authors are of the form "domain\user". (You can switch off mod_sspi reporting the domain part, but I didn't know about this at the time, so it continues for historical reasons.) git-svn treats the literal backslashes in the author names as escapes. This leads to authors like domainkevin domain\ ichard I know, I should have read the manual and used my "authors" fi...
Nov 12, 10:28 am 2007
Ping Yin
[PATCH] status&commit: Teach them to show submodule comm...
git status/commit just treats submodules as ordinary files when reporting status changes. However, one may also wonder how submodules change (the commits). This commit teaches git status/commit to additionally show commit summary of user-cared (i.e. checked out) modified submodules since HEAD (or HEAD^ if --amend option is on). For submodules deleted or initially added, commit summary are not shown. A configuration variable 'submodule.status' is used to turn this summary behaviour on or off (defa...
Nov 12, 10:21 am 2007
Johannes Sixt
Re: [PATCH] status&commit: Teach them to show submodule ...
In general, I like the idea (as I've already pointed out). But at this time git-commit is about to be made a builtin, and since your implementation contains a lot of non-portable constructs ($'', >&) and a new dependency on awk (and, hence, has little chances of being accepted), I suggest that you stay tuned, and implement this in the forth-coming There is already 'status.color', I suggest the configuration to become 'status.submoduleSummary'. -- Hannes -
Nov 12, 11:59 am 2007
Ping Yin
Re: [PATCH] status&commit: Teach them to show submodule ...
Implement this in shell scripts is just a piece of cake, but not so easy in builtin-commit.c. Not to mention that i'm unamiliar with git c code. $', >& portable problem can be easily corrected. However, awk is There is 'status.color', but 'color.status' is prefered as said in the documentation. So i follows this rule, name the variable submodule.* just as the ones for git-submodule. I think it's a good idea to put all submodule related configuration variables in the submodule.* -- Ping...
Nov 12, 12:35 pm 2007
Johannes Sixt
Re: [PATCH] status&commit: Teach them to show submodule ...
I'm with you. But git-commit.sh is a dead horse, no matter how hard you beat it. BTW, maybe you can keep the log generation in a helper script, git-status--submodulesummary, and invoke that from builtin-commit.c. This "I think it's a good idea to put all status related configuration variables in the status.* namespace." But I don't care too deeply. I don't have the big picture about which configuration variables namespaces exist and which one to pick in this case. -- Hannes -
Nov 12, 12:45 pm 2007
Lars Hjemli
Re: [PATCH] status&commit: Teach them to show submodule ...
Sorry for repeating myself, but IMVHO this belong in git-submodule.sh: It can be useful as a standalone command, we get all submodule-related commands isolated in a single place, and builtin-commit.c can of course exec git-submodule to get the summary. -- larsh -
Nov 12, 1:47 pm 2007
Johannes Schindelin
Re: [PATCH] status&commit: Teach them to show submodule ...
Hi, You could make this variable even a numeric one. Saying how many lines you want to have maximally (-1 meaning unlimited). Ciao, Dscho -
Nov 12, 12:13 pm 2007
Ping Yin
Re: [PATCH] status&commit: Teach them to show submodule ...
On Nov 13, 2007 12:13 AM, Johannes Schindelin Good idea. However, there is a problem about limiting the lines of commit summary: if there are 50 backwards and 50 forwards, and summary lines are limited to 50 lines. How to display? 25 backwards, 25 forwards or -- Ping Yin -
Nov 12, 12:39 pm 2007
Johannes Sixt
Re: [PATCH] status&commit: Teach them to show submodule ...
Just use git log --left-right --topo-order, then you can easily insert -$n, and git-log will decide where it cuts off the lists. However, --left-right won't reverse one of the list, like you did. -- Hannes -
Nov 12, 12:51 pm 2007
Ralf Wildenhues
Re: [PATCH] status&commit: Teach them to show submodule ...
Hello, A couple of portability nits: * Ping Yin wrote on Mon, Nov 12, 2007 at 03:21:17PM CET: Typo: s/modifiled/modified/ Then, "echo -e" is not portable (and not used elsewhere in git), but you can just use this instead: test ... && { echo "# ..."; echo "#"; } Also, it so happens you leave $modules outside quotes which will drop multiple adjacent white spaces. Did you mean to use echo "# Submodules modified: \"$modules\"" $' is not portable (and not POSIX either). For ex...
Nov 12, 10:46 am 2007
Ping Yin
Re: [PATCH] status&commit: Teach them to show submodule ...
I leave $modules outside quotes to let "\n" change to <space> by auto word splitting. It actually eats white spaces in the module names. So any suggestion to handle this case? To handles module names with spaces, is it ok to display as follows? Submodules modified: sm1 "sm name with space" I just guess '\r' is need for Mac OS because i havn't Mac OS environment. -- Ping Yin -
Nov 12, 11:17 am 2007
Brian Gernhardt
Re: [PATCH] status&commit: Teach them to show submodule ...
OS X's command line environment is modeled after BSD and uses the nice and sane \n as a line ending. And since earlier Mac OS versions (that did use \r) don't have a command line, I don't see people using git on them. ~~ Brian -
Nov 12, 12:53 pm 2007
Jon Smirl
Cloning from kernel.org, then switching to another repo
I'd like to do this sequence, but I can't figure out how without editing the config file. There doesn't seem to be a simple command to move the origin. git clone linus move origin to digispeaker.git git pull What's the simplest way to do this? -- Jon Smirl jonsmirl@gmail.com -
Nov 12, 9:57 am 2007
previous daytodaynext day
November 11, 2007November 12, 2007November 13, 2007