Re: [BUG] fast-import producing very deep tree deltas

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Brian Downing <bdowning@...>
Cc: Shawn O. Pearce <spearce@...>, <git@...>
Date: Monday, November 12, 2007 - 4:26 pm

On Mon, 12 Nov 2007, Brian Downing wrote:

Hmm. Quick hack: increase the delta cache window. The reason (I think) why 
performance turns glacial with really deep delta chains is that it turns 
into an O(n^2) thing when you don't hit in the delta cache, and your delta 
depth is so deep that following a *single* delta chain will flush the 
cache.

So I bet that making the delta cache bigger will "fix" it. You probably 
don't have to make it 6000+ entries, but with the *median* being that 
deep, making it 2k entries should improve it for most cases.

Obviously fastimport should be fixed to not do those insanely deep chains 
too, but it might be a good idea to at least make the delta cache a bit 
bigger by default, and perhaps have some config option for setting it.

		Linus
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[BUG] fast-import producing very deep tree deltas, Brian Downing, (Mon Nov 12, 7:03 am)
Re: [BUG] fast-import producing very deep tree deltas, Shawn O. Pearce, (Tue Nov 13, 4:53 am)
Re: [BUG] fast-import producing very deep tree deltas, Shawn O. Pearce, (Tue Nov 13, 5:27 am)
Re: [BUG] fast-import producing very deep tree deltas, Brian Downing, (Tue Nov 13, 10:36 am)
Re: [BUG] fast-import producing very deep tree deltas, Linus Torvalds, (Mon Nov 12, 4:26 pm)
[BUG] fast-import quoting broken for renames, Brian Downing, (Mon Nov 12, 7:13 am)