Re: [PATCH] Fixed crash in fetching remote tags when there is not tags.

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Alex Riesen
Date: Tuesday, October 9, 2007 - 11:20 am

Väinö Järvelä, Tue, Oct 09, 2007 12:52:01 +0200:

Your test does not crash on my system and your fix is obviously bogus.
Just take a look at the only call site of the tail_link_ref: ret
cannot be NULL. alloc_ref will crash in memset, if this were the case.

If you can reproduce the crash reliably, try compiling git with -g and
run it in your test with valgrind or gdb (assuming these are available
to you).

-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH] Fixed crash in fetching remote tags when there is ..., Väinö Järvelä, (Tue Oct 9, 1:51 am)
Re: [PATCH] Fixed crash in fetching remote tags when there ..., Alex Riesen, (Tue Oct 9, 11:20 am)