git mailing list

FromSubjectsort iconDate
Junio C Hamano
[ANNOUNCE] GIT 1.5.3.5
The latest maintenance release GIT 1.5.3.5 is available at the usual places: http://www.kernel.org/pub/software/scm/git/ git-1.5.3.5.tar.{gz,bz2} (tarball) git-htmldocs-1.5.3.5.tar.{gz,bz2} (preformatted docs) git-manpages-1.5.3.5.tar.{gz,bz2} (preformatted docs) RPMS/$arch/git-*-1.5.3.5-1.$arch.rpm (RPM) There are many fixes including a handful bugs that led to segfaults. ---------------------------------------------------------------- GIT v1.5.3.5 Release Notes ===========...
Oct 31, 6:40 pm 2007
Robin Rosenberg
[PATCH] cvsexportcommit: Add switch to specify CVS workdir
Signed-off-by: Robin Rosenberg <robin.rosenberg@dewire.com> --- Documentation/git-cvsexportcommit.txt | 22 ++++++++++++++---- git-cvsexportcommit.perl | 39 ++++++++++++++++++++++---------- 2 files changed, 44 insertions(+), 17 deletions(-) I finally got tired of swapping working directories. -- robin diff --git a/Documentation/git-cvsexportcommit.txt b/Documentation/git-cvsexportcommit.txt index c3922f9..310d56a 100644 --- a/Documentation/git-cvsexportcommit.txt +++...
Oct 31, 6:12 pm 2007
Junio C Hamano
Re: [PATCH 1/1] Add --first-parent support to interactive re...
I agree. "Signed-off-by" as part of the existing commit message should be fine, but with "format-patch -s" the code needs to be careful. The following is on top of 'master'. I haven't tested it. If it works, great. If it doesn't, at least it should illustrate what needs to be touched. Ideally a fix to 'maint' is needed --- the pretty-print infrastructure on the 'master' side has strbuf changes and the patch may have conflicts at the textual level, but it should be straightforward to adjus...
Oct 31, 5:53 pm 2007
Jeff King
Re: [PATCH 1/1] Add --first-parent support to interactive re...
You beat me to it, as I was busy flaming Linus. :) The patch I started is very similar to this, but I had one concern that I was tracking down: is the author name encoding necessarily the same as the commit text encoding? -Peff -
Oct 31, 5:56 pm 2007
Junio C Hamano
Re: [PATCH 1/1] Add --first-parent support to interactive re...
The user is screwing himself already if that is the case and uses -s to format-patch, isn't he? -
Oct 31, 6:31 pm 2007
Alex Riesen
[PATCH] Updated russian translation of git-gui
Fixed some spelling mistakes. --- po/ru.po | 516 +++++++++++++++++++++++++++++++++++--------------------------- 1 files changed, 292 insertions(+), 224 deletions(-) diff --git a/po/ru.po b/po/ru.po index b8e9447..6727a83 100644 --- a/po/ru.po +++ b/po/ru.po @@ -7,7 +7,7 @@ msgid "" msgstr "" "Project-Id-Version: git-gui\n" "Report-Msgid-Bugs-To: \n" -"POT-Creation-Date: 2007-10-10 04:04-0400\n" +"POT-Creation-Date: 2007-10-31 21:23+0100\n" "PO-Revision-Date: 2007-10-22 22:30-0200\n" ...
Oct 31, 5:16 pm 2007
Brad King
[PATCH] cvsexportcommit: fix for commits that do not have pa...
Previously commits without parents would fail to export with a message indicating that the commits had more than one parent. Instead we should use the --root option for git-diff-tree in place of a parent. Signed-off-by: Brad King <brad.king@kitware.com> --- This is a corrected version of the patch I previously posted which had a typo. git-cvsexportcommit.perl | 13 ++++++++++--- 1 files changed, 10 insertions(+), 3 deletions(-) diff --git a/git-cvsexportcommit.perl b/git-cvsexportcommi...
Oct 31, 4:55 pm 2007
Brad King
[PATCH] cvsexportcommit: fix for commits that do not have pa...
Previously commits without parents would fail to export with a message indicating that the commits had more than one parent. Instead we should use the --root option for git-diff-tree in place of a parent. Signed-off-by: Brad King <brad.king@kitware.com> --- git-cvsexportcommit.perl | 13 ++++++++++--- 1 files changed, 10 insertions(+), 3 deletions(-) diff --git a/git-cvsexportcommit.perl b/git-cvsexportcommit.perl index f284c88..7548cc0 100755 --- a/git-cvsexportcommit.perl +++ b/git...
Oct 31, 4:16 pm 2007
Sergei Organov
Bug in git-show-branch, or in core-tutorial?
Or is it me who needs a fix? [Sorry, this is roughly a repeat of my earlier post <http://permalink.gmane.org/gmane.comp.version-control.git/62493> I didn't get any answer to, and I'm trying once more to attract your attention to the issue.] Please consider the following quote starting at core-tutorial.txt:933 (emphasis is mine): <quote> ------------------------------------------------ $ git show-branch --topo-order master mybranch * [master] Merge work in mybranch ! [mybranch] ...
Oct 31, 4:17 pm 2007
Mike Hommey
[PATCH] Don't use cpio in git-clone when not installed
Signed-off-by: Mike Hommey <mh@glandium.org> --- git-clone.sh | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/git-clone.sh b/git-clone.sh index 0ea3c24..57e96ae 100755 --- a/git-clone.sh +++ b/git-clone.sh @@ -191,7 +191,9 @@ fi # it is local if base=$(get_repo_base "$repo"); then repo="$base" - local=yes + if type cpio > /dev/null 2>&1; then + local=yes + fi fi dir="$2" -- 1.5.3.4 -
Oct 31, 4:05 pm 2007
Junio C Hamano
Re: [PATCH] Don't use cpio in git-clone when not installed
"type"? That's probably better than using "which", but sounds quite wrong. Why not add Makefile target that the shell scripts depend on to see if necessary tools are available and let the builder know if they are not? -
Oct 31, 6:29 pm 2007
Johannes Schindelin
Re: [PATCH] Don't use cpio in git-clone when not installed
Hi, I thought the accord was that "cpio" is a _runtime_ dependency. But yes, I agree "type" is not necessarily the best choice. Maybe testing the exit code for 127 (not found) is the better choice? Ciao, Dscho -
Oct 31, 7:55 pm 2007
Mike Hommey
Re: [PATCH] Don't use cpio in git-clone when not installed
Damn, and I forgot git-send-email doesn't add the <> to In-Reply-To. Mike -
Oct 31, 4:10 pm 2007
Sergei Organov
Newbie: report of first experience with git-rebase.
Hello, I've made my first attempt at tracking my changes to upstream git repository using git-fetch/git-rebase workflow. I did three commits to my master branch, and then upstream incorporated two of them in slightly modified form, so that some conflicts are to be expected. I did git-fetch followed by git-rebase, and finally have got the end result I hoped for, but there were some confusion along the way. I think I'd post the log of the session here along with my thoughts so that an interested per...
Oct 31, 3:39 pm 2007
Alex Riesen
Re: Newbie: report of first experience with git-rebase.
Well... This one kind of hard: git-rebase _cannot_ know whether it is safe to just drop all changes in the index and work tree (you could have made the changes on purpose). It was decided not to drop anything. You always can do $ git reset --hard # kills all changes in index and work tree $ git rebase --skip Yes. It was the last commit. You were just too unlucky to hit all the hard cases your first day. -
Oct 31, 5:25 pm 2007
Björn
Re: Newbie: report of first experience with git-rebase.
It wasn't a no-op patch. It had conflicts which you resolved to the There seems to be some bug in rebase that makes it fail in this case. Someone on #git also reported that --abort failed to reset his branch to the old head in a similar case, but I didn't manage to reproduce that yet (well, I didn't try that hard), so I don't know if it's really a bug or a misuse by that guy. Björn -
Oct 31, 3:57 pm 2007
Sergei Organov
Re: Newbie: report of first experience with git-rebase.
Yes, and that's the problem. Why 'git --continue' didn't just skip this patch that *already became no-op* after conflict resolution and forced me to explicitly use 'git --skip' instead? This forces one to use 'git --skip' if the patch happens to become a no-op after conflict resolution, and 'git --continue' otherwise. Why this complication? -- Sergei. -
Oct 31, 4:28 pm 2007
Johannes Schindelin
Re: Newbie: report of first experience with git-rebase.
Hi, Isn't that obvious? To prevent you from accidentally losing a commit. Ciao, Dscho -
Oct 31, 5:12 pm 2007
David Kastrup
Re: Newbie: report of first experience with git-rebase.
The commit would not change anything, so what is there to lose? -- David Kastrup, Kriemhildstr. 15, 44793 Bochum -
Oct 31, 6:49 pm 2007
Junio C Hamano
Re: Newbie: report of first experience with git-rebase.
In case it is not obvious... A rebase conflict resolution that results in emptiness is a rather rare event (especially because rebase drops upfront the identical changes from the set of commits to be replayed), but it does happen. One could argue that "rebase --continue" can notice that the resolved index is identical to the tree of the HEAD commit and skip it automatically. Given an index that is identical to HEAD, however, it is not easy to safely determine if that is because the patch did ...
Oct 31, 5:39 pm 2007
David Kastrup
Re: Newbie: report of first experience with git-rebase.
Wouldn't there be a conflict in the index? A conflict which can only be resolved by adding? Which then results in a question whether you forgot to add? -- David Kastrup, Kriemhildstr. 15, 44793 Bochum -
Oct 31, 6:53 pm 2007
J. Bruce Fields
Re: Newbie: report of first experience with git-rebase.
That would make sense to me if this was a mistake that could easily happen. I'd assumed that in the case of a conflict that stopped the rebase process, the index and working tree are always left dirty, so that if they both agree with the HEAD at the time of commit, then it's because the user explicitly made them that way. I ran into the same confusion as the original poster when starting to use rebase, so I suspect it's common. --b. -
Oct 31, 5:29 pm 2007
Steven Grimm
Re: Newbie: report of first experience with git-rebase.
I've been using rebase just about every day for close to a year and it *still* annoys me when it happens. Especially the "Did you forget to git add?" part of the message. The thought that always goes through my head is, "No, Mr. Rebase, I did NOT forget to git add. I remembered to git add, then you were too stupid to do the right thing after that." Just happened to me this morning, in fact: I had a quick hack in place to work around a bug, the bug got fixed for real, and I rebased. In the p...
Oct 31, 6:06 pm 2007
J. Bruce Fields
Re: Newbie: report of first experience with git-rebase.
Yeah, I think a message saying "patch is now empty, skipping..." would be sufficient to let the user know what's going on. This doesn't seem so perilous to me that it's worth requiring a positive acknowledgement. --b. -
Oct 31, 6:38 pm 2007
Daniel Barkalow
Re: Newbie: report of first experience with git-rebase.
I think it's worth requiring you to say --skip in order to acknowledge that you won't have as many commits and you'll lose the commit message. On the other hand, the message should probably suggest that you might want to skip this commit instead of suggesting that you come up with some other change to include in it. Certainly, if "git diff" returns no changes, "git add" is a bad suggestion, and it would be nicer to suggest something possibly correct. -Daniel *This .sig left intentionally...
Oct 31, 6:35 pm 2007
Simon Sasburg
[PATCH] Implement sending mails over TLS in git-send-email.
Signed-off-by: Simon Sasburg <Simon.Sasburg@gmail.com> --- With this patch I was able to use git-send-email to send mail through gmail's smpt server, which uses TLS. Net::SMTP::TLS apparently doesn't do proper error handling, so the TLS codepath is essentially not checked for errors. I'm not really happy with this. But my perl knowledge is way too limited for me to know if/how that helps. (This patch was just made by copying existing code and fiddling with it untill it did what i wanted...
Oct 31, 11:50 am 2007
Baz
Re: [PATCH] Implement sending mails over TLS in git-send-ema...
Net::SMTP::TLS is a bit ugly. It seems unable to do any checking of the server certificate, a limitation its inherited from the original script it was hacked from. I suspect some people wouldn't touch this option if that's the case (although I doubt any tin-foil hatters use gmail anyway, and we don't use this check for SSL either). Secondly, Net::SMTP::SSL has no problem connecting to gmail - it does everything Net::SMTP::TLS does and more; you can use all of the options of IO::Socket::SSL with...
Oct 31, 5:45 pm 2007
Simon Sasburg
Re: [PATCH] Implement sending mails over TLS in git-send-ema...
Ah, yes, i got the Authen::SASL errors at first, but even after resolving all missing module dependencies, the --smpt-ssl still did not work for me, so i started looking at Well, it fails here, maybe maybe you can show me exactly what you did (configuration/parameters etc)? and it fails, while the same line using --smtp-tls instead of --smtp-ssl with my patch applied works. What am i missing? -
Oct 31, 6:04 pm 2007
Baz
Re: [PATCH] Implement sending mails over TLS in git-send-ema...
ok I'm going to downgrade what I said to 'it works fine with gmail' - it just doesnt do starttls, your code does. git-send-email --from 'brian.ewins@gmail.com' --to 'brian.ewins@gmail.com' --smtp-server smtp.gmail.com --smtp-user 'brian.ewins@gmail.com' --smtp-pass 'secret' --smtp-ssl 0001-the-patch-goes-here That's using SSL on port 465, not TLS. Did this not work for you? I thought Net::SMTP passed its constructor options to IO::Socket, but no. An alternate way of getting starttls to work, ...
Oct 31, 7:59 pm 2007
Tim Janik
git-commit broken with GIT_INDEX_FILE
hey All. i'm maintaining my own git porcelainen, and as part of that had to (re-)implement my own commit command: http://blogs.gnome.org/timj/2007/10/13/13102007-yummy-yummy-porcelain-version-08/ i've read through git-commit and cg-commit, and would really like to avoid reimplementing the hook and utf8 encoding handling. thus, my tool calls git-commit once it has created an index file with all the files that need comitting. ideally, it'd construct a temporary index, e.g. $GIT_DIR/next-index$$...
Oct 31, 11:02 am 2007
しらいしななこ
[PATCH] git-gui: Update Japanese strings
This updates the Japanese translation file. Signed-off-by: しらいしななこ <nanako3@bluebottle.com> --- po/ja.po | 277 ++++++++++++++++++++++++++++++-------------------------------- 1 files changed, 133 insertions(+), 144 deletions(-) diff --git a/po/ja.po b/po/ja.po index f65e460..e4491f7 100644 --- a/po/ja.po +++ b/po/ja.po @@ -9,7 +9,7 @@ msgstr "" "Project-Id-Version: git-gui\n" "Report-Msgid-Bugs-To: \n" "POT-Creation-Date: 2007-10-10 04:04-0400\n" -"PO-Revision-Date:...
Oct 31, 10:12 am 2007
Anton Korobeynikov
Re: Possible bug: git-svn leaves broken tree in case of error
Looks like something nasty here. I also failed to reproduce with such test, however I definitely was sure, that I modelled it properly. The typical scenario here is that I'm syncing with external repository by hands. I tried to replay this with "bad" authors file, but it doesn't allow me to past through "bad" changeset. And yes, adding new entry to authors files fixes the problem. I saw corruption, when git-svn in the next run continues fetch changesets. As I saw this problem several times with m...
Oct 31, 10:04 am 2007
Gerrit Pape
[PATCH] git-diff.txt: add section "output format" describing...
git-diff.txt includes diff-options.txt which for the -p option refers to a section "generating patches.." which is missing from the git-diff documentation. This patch adapts diff-format.txt to additionally mention the git-diff program, and includes diff-format.txt into git-diff.txt. Tino Keitel noticed this problem. Signed-off-by: Gerrit Pape <pape@smarden.org> --- Documentation/diff-format.txt | 22 +++++++++++----------- Documentation/git-diff.txt | 3 +++ 2 files changed, 14...
Oct 31, 9:59 am 2007
Bill Lear
cpio command not found
I just cloned the latest git and it builds ok, but fails when I clone: % uname -a Linux gronk.zopyra.com 2.4.9-21 #1 Thu Jan 17 14:16:30 EST 2002 i686 unknown % git --version git version gitgui.0.8.4.g9c514 % git clone --bare ~/my_repo Initialized empty Git repository in /repos/git/my_repo/ /opt/git/bin/git-clone: line 297: cpio: command not found So, should git not check this when it is building? I don't remember this dependence from earlier versions of git. I have been running git 1.4....
Oct 31, 8:51 am 2007
Karl
Re: cpio command not found
When you clone with -l, git uses cpio to hardlink to the original repository. What has changed is that -l is now used by default when cloning a repository that's accessed via the file system (as opposed to over some network protocol). To work around this, specify the repository location with file://, and git won't try to hardlink (and hence won't try to use cpio). -- Karl Hasselström, kha@treskal.com www.treskal.com/kalle -
Oct 31, 9:30 am 2007
Erik Mouw
Re: cpio command not found
Why cpio? What is wrong with ln(1) (every Unix should have one) or link(2) ? Erik --=20 They're all fools. Don't worry. Darwin may be slow, but he'll eventually get them. -- Matthew Lammers in alt.sysadmin.recovery
Oct 31, 10:06 am 2007
Mike Hommey
Re: cpio command not found
Since git-clone is not yet a builtin, and is actually a shell script, it makes more sense to use cpio than ln. Mike -
Oct 31, 3:48 pm 2007
Johannes Schindelin
Re: cpio command not found
Hi, Patch, please? Ciao, Dscho -
Oct 31, 10:20 am 2007
Erik Mouw
[PATCH] Get rid of cpio in git-clone (was: Re: cpio command ...
Here you go. Remove dependency on cpio for git-clone. Apparently some POSIX systems out there don't have cpio, just assume cp is there. Signed-off-by: Erik Mouw <mouw@nl.linux.org> diff --git a/INSTALL b/INSTALL index f1eb404..9074563 100644 --- a/INSTALL +++ b/INSTALL @@ -79,8 +79,7 @@ Issues of note: - "perl" and POSIX-compliant shells are needed to use most of the barebone Porcelainish scripts. =20 - - "cpio" is used by git-merge for saving and restoring the index, - an...
Oct 31, 4:14 pm 2007
Jeff King
Re: [PATCH] Get rid of cpio in git-clone (was: Re: cpio comm...
cp -l isn't even close to portable. It's not in POSIX, and doesn't work on (at least) Solaris. I think Mike's patch (cpio if available, copy otherwise) is a reasonable approach. If there are other methods (and I think cp -l is not unreasonable for systems where it is supported and cpio is unavailable), then perhaps it is worth trying them one by one and dropping back to full copy if all fail. -Peff -
Oct 31, 4:22 pm 2007
Bill Lear
Re: cpio command not found
Hmm, thanks for the workaround, but I don't altogether like leaving things like this. If the system does not have cpio, I think the build of git should complain and fail, or it should activate code that treats any repository accessed over the file system as it would file://. No sense in leaving this surprise to the user so late in the cycle. Bill -
Oct 31, 9:54 am 2007
Allan Wind
Re: cpio command not found
git may be build and run on two different hosts, so while the build-time check is good there should be a run-time check as well. /Allan -
Oct 31, 9:58 am 2007
David Symonds
Re: cpio command not found
Something like this could be done at run-time instead. You might install cpio, but shouldn't require a rebuild of git just to use it. Dave. -
Oct 31, 10:00 am 2007
Junio C Hamano
Re: [PATCH 1/1] Add --first-parent support to interactive re...
Your MUA seems to mark the UTF-8 message you are sending out as 8859-1, which means your name in the message gets corrupt. And crucially, you forgot to say "... when you do X". I am assuming that you meant: This (picture) becomes this (picture) instead of this (picture) when you run "git rebase -p -m master topicA". but without it, the nice ASCII drawings loses their value. It is somewhat disturbing that this treats the first parent too special. -
Oct 31, 1:05 am 2007
Björn
Re: [PATCH 1/1] Add --first-parent support to interactive re...
Hm, that would be git-send-email then, anything I need to configure? When you do "git-rebase -p -i master topicA" When you do "git-rebase -p -i --first-parent master topicA" The original use-case for the "-p -i --first-parent" case was a question on #git, where someone had sth. like this: o---o---o---o---o remote/branch \ \ o---o---o---o---o topicA / o---o---o master trunk Now that guy was using git-svn to dcommit into svn from master. To dco...
Oct 31, 1:53 am 2007
Dmitry Potapov
Re: [PATCH 1/1] Add --first-parent support to interactive re...
I believe that the issue is with Junio's mail client. Indeed, the context encoding for the mail *body* was specified as 8859-1, but that should have none effect on fields in the mail header, because any field is the header should be either printable ASCII or encoded to contain only ASCII characters as specified in RFC 1522: encoded-word = "=?" charset "?" encoding "?" encoded-text "?=" Here is the From field from the mail: From: =?utf-8?q?Bj=C3=B6rn=20Steinbrink?= <B.Steinbrink@gmx.de> ...
Oct 31, 9:43 am 2007
Karl
Re: [PATCH 1/1] Add --first-parent support to interactive re...
Yes. But it's the body that's been mangled -- specifically, the Sign-off line. -- Karl Hasselström, kha@treskal.com www.treskal.com/kalle -
Oct 31, 10:00 am 2007
Dmitry Potapov
Re: [PATCH 1/1] Add --first-parent support to interactive re...
Hmm... I looked at the mail again and I cannot see where 8859-1 is specified. It seems that context encoding is not specified at all. Of course, it is incorrect to use non ASCII characters in a mail without specifying encoding. Apparently, because I use utf-8 in the terminal, the Sign-off line displays correctly for me, so I did not notice the problem. Sorry for the noise... Dmitry -
Oct 31, 10:36 am 2007
Jeff King
Re: [PATCH 1/1] Add --first-parent support to interactive re...
It is our old friend vger adding the iso-8859-1 header, I think, since no encoding was specified. I think the problem is that git-format-patch only decides whether to append a MIME header based on the commit message contents; it does not take the Signed-Off-By into account. This may also be the cause of the recent complaints from Matti Aarnio. -Peff -
Oct 31, 2:05 pm 2007
Björn
Re: [PATCH 1/1] Add --first-parent support to interactive re...
Yep, that's it. If the Signed-Off-By was added by commit -s, it works, while format-patch -s causes the header to be missing, although the Signed-Off-By is utf-8 encoded. Will try to remember that. Thanks, Björn -
Oct 31, 3:50 pm 2007
previous daytodaynext day
October 30, 2007October 31, 2007December 1, 2007