Signed-off-by: Simon Sasburg <Simon.Sasburg@gmail.com>

---
With this patch I was able to use git-send-email to send mail through gmail's

smpt server, which uses TLS.
Net::SMTP::TLS apparently doesn't do proper error handling, so the TLS

codepath is essentially not checked for errors. I'm not really happy with this.
But my perl knowledge is way too limited for me to know if/how that helps.

(This patch was just made by copying existing code and fiddling with it untill it did what i wanted)
Maybe someone who knows more about perl than I do can finish this?

Or give an estimate how difficult it would be for me to fix after pointing me in the right direction?

(I'm willing to learn a little perl for this, but not too much :-p)

---

 git-send-email.perl |   64 +++++++++++++++++++++++++++++++++-----------------

 1 files changed, 42 insertions(+), 22 deletions(-)
diff --git a/git-send-email.perl b/git-send-email.perl

index 96051bc..5cf220f 100755

--- a/git-send-email.perl

+++ b/git-send-email.perl

@@ -88,6 +88,9 @@ Options:
    --smtp-ssl     If set, connects to the SMTP server using SSL.
+   --smtp-tls     If set, connects to the SMTP server using TLS.

+                  Overrides --smtp-ssl.

+

    --suppress-from Suppress sending emails to yourself if your address

                   appears in a From: line. Defaults to off.
@@ -175,7 +178,7 @@ my ($quiet, $dry_run) = (0, 0);
 # Variables with corresponding config settings

 my ($thread, $chain_reply_to, $suppress_from, $signed_off_cc, $cc_cmd);

-my ($smtp_server, $smtp_server_port, $smtp_authuser, $smtp_authpass, $smtp_ssl);

+my ($smtp_server, $smtp_server_port, $smtp_authuser, $smtp_authpass, $smtp_ssl, $smtp_tls);

 my ($identity, $aliasfiletype, @alias_files, @smtp_host_parts);
 my %config_bool_settings = (

@@ -184,6 +187,7 @@ my %config_bool_settings = (

     "suppressfrom" => [\$suppress_from, 0],

     "signedoffcc" => [\$signed_off_cc, 1],

     "smtpssl" => [\$smtp_ssl, 0],

+    "smtptls" =&...
[ message continues ]

Net::SMTP::TLS is a bit ugly. It seems unable to do any checking of

the server certificate, a limitation its inherited from the original

script it was hacked from. I suspect some people wouldn't touch this

option if that's the case (although I doubt any tin-foil hatters use

gmail anyway, and we don't use this check for SSL either).
Secondly, Net::SMTP::SSL has no problem connecting to gmail - it does

everything Net::SMTP::TLS does and more; you can use all of the

options of IO::Socket::SSL with it. A common problem seems to be not

having Authen::SASL installed (this is required to authenticate with

gmail) - the one thing Net::SMTP::TLS *does* do is auth without using

that module.
In other words, this patch should be entirely unnecessary if you have

Authen::SASL installed - could you try this? (I've checked for myself,
My perl knowledge is a also bit stale, havent had to use it in anger

for a few years; your code looks ok to me, its the dodgy module I'm

-

Ah, yes, i got the Authen::SASL errors at first, but even after

resolving all missing module dependencies,

the --smpt-ssl still did not work for me, so i started looking at
Well, it fails here, maybe maybe you can show me exactly what you did

(configuration/parameters etc)?
and it fails, while the same line using --smtp-tls instead of

--smtp-ssl with my patch applied works.
What am i missing?

-

ok I'm going to downgrade what I said to 'it works fine with gmail' -

it just doesnt do starttls, your code does.
git-send-email --from 'brian.ewins@gmail.com' --to

'brian.ewins@gmail.com' --smtp-server smtp.gmail.com  --smtp-user

'brian.ewins@gmail.com' --smtp-pass 'secret' --smtp-ssl

0001-the-patch-goes-here
That's using SSL on port 465, not TLS. Did this not work for you? I

thought Net::SMTP passed its constructor options to IO::Socket, but

no. An alternate way of getting starttls to work, without using

Net::SMTP::TLS, is this:
#connect with Net::SMTP - not ::SSL or the connect will fail

$smtp = Net::SMTP->new('smtp.gmail.com',

                                 Port => 587,

                                 Debug => 1) or die "Could not connect

to server\n";

#issue the starttls command, assuming user asked for this

$smtp->command('STARTTLS');

$smtp->response();

#if server says 220, then go ahead and convert the socket. Bless as

Net::SMTP::SSL

# - necessary to inherit both IO::Socket::SSL and Net::SMTP

#start_SSL has been renamed, twice. Nice stable api :)

#extra args for checking server cert etc can be passed to start_SSL.

$smtp->code() == 220 and $smtp = Net::SMTP::SSL->start_SSL($smtp) or

die "STARTTLS failed! ".$smtp->message;

# say hello again to get server features (including auth)

$smtp->hello();

# now continue as before, with $smtp->auth()...

-