Home » Mailing list archives » git » 2007 » October » 24

Re: [PATCH 5/9] git-cat-file: Add --separator option

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Brian Downing <bdowning@...>
To: Adam Roben <aroben@...>
Cc: <git@...>, Junio C Hamano <gitster@...>
Subject: Re: [PATCH 5/9] git-cat-file: Add --separator option
Date: Tuesday, October 23, 2007 - 11:43 pm

On Mon, Oct 22, 2007 at 10:46:33PM -0700, Adam Roben wrote:

Maybe I'm just unreasonably paranoid, but I don't think I could ever
trust that you'd never find an arbitrary separator in the data.  I
suppose if you scanned the files beforehand you could come up with
something guaranteed to be unique, but that seems like a pain (and
doesn't happen regardless in patch 9/9; it just uses
"--------------GITCATFILESEPARATOR-----------")  If I were committing to
SVN, it's sure not something I'd like to bet the integrity of my data
on.

I think a far more reasonable output format for multiple objects would
be something like:

<count> LF
<raw data> LF

Where <count> is the number of bytes in the <raw data> as an ASCII
decimal integer.

This is pretty much the spiritual analog to the fast-import "exact byte
count" data input format as well.

-bcd
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH 3/9] git-cat-file: Make option parsing a little more ..., Adam Roben, (Tue Oct 23, 1:46 am)
[PATCH 4/9] git-cat-file: Add --stdin option, Adam Roben, (Tue Oct 23, 1:46 am)
[PATCH 5/9] git-cat-file: Add --separator option, Adam Roben, (Tue Oct 23, 1:46 am)
Re: [PATCH 5/9] git-cat-file: Add --separator option, Brian Downing, (Tue Oct 23, 11:43 pm)
Re: [PATCH 5/9] git-cat-file: Add --separator option, Adam Roben, (Wed Oct 24, 12:26 am)
[PATCH 6/9] Add tests for git hash-object, Adam Roben, (Tue Oct 23, 1:46 am)
Re: [PATCH 6/9] Add tests for git hash-object, Johannes Sixt, (Tue Oct 23, 2:59 am)
[PATCH 7/9] git-hash-object: Add --stdin-paths option, Adam Roben, (Tue Oct 23, 1:46 am)
Re: [PATCH 7/9] git-hash-object: Add --stdin-paths option, Shawn O. Pearce, (Tue Oct 23, 1:53 am)
Re: [PATCH 7/9] git-hash-object: Add --stdin-paths option, Adam Roben, (Tue Oct 23, 1:57 am)
Re: [PATCH 7/9] git-hash-object: Add --stdin-paths option, Shawn O. Pearce, (Tue Oct 23, 2:10 am)
Re: [PATCH 7/9] git-hash-object: Add --stdin-paths option, Eric Wong, (Wed Oct 24, 2:11 am)
[PATCH 8/9] Git.pm: Add command_bidi_pipe and command_close_..., Adam Roben, (Tue Oct 23, 1:46 am)