What can i do here to better accommodate MingW32? You're right, just because the original code did it this way isn't a good excuse for me not to do it better. sRp -

Hi, That someone may well have mentioned that term, but what he meant was special case those code paths which have to be treated differently for Windows, and Windows alone. (Yeah, I know, a response to that was that Nokia phones have drive letters, too, but that was an invalid objection to that particular statement, since Nokia phones expect the full path at any time, so I did not even bother answering to that mail. Well, in a way, I guess I just did.) All this boils down to adding c...

The original code was already doing both of these things (see git.c's prepend_to_path()) sRp -

Well, would be nice if your code was better in this respect. Anyway, I suspect the mingw people will trash the code anyway sometime (or not, which is just as well - it is a rare case). -

Signed-off-by: Scott R Parish <srp@srparish.net> --- exec_cmd.c | 12 ++++++------ exec_cmd.h | 2 +- git.c | 2 +- 3 files changed, 8 insertions(+), 8 deletions(-) diff --git a/exec_cmd.c b/exec_cmd.c index 9b74ed2..8b681d0 100644 --- a/exec_cmd.c +++ b/exec_cmd.c @@ -5,11 +5,11 @@ extern char **environ; static const char *builtin_exec_path = GIT_EXEC_PATH; -static const char *current_exec_path; +static const char *argv_exec_path = 0; -void git_set_exec_path(...

the default PATH is platform-dependent. Git is multi-platform. You should consider putting the path list somewhere in Makefile, -

Hi, Nice. Ciao, Dscho -

By the way, I should have said--this is with git version 1.5.3.4.208.gc990. -

Hi, I guess that 95807fe01 is the parent of a commit adding the RDF/ directory. The subdirectory filter does not look kindly upon a history where some commits lack the subdirectory in question. However, this should work: git filter-branch --subdirectory--filter RDF 95807fe01..HEAD Hth, Dscho -

Hi, It sure sounds pretty tricky. (IOW I'm probably unable to help more...) Ciao, Dscho -

OK, makes sense (that's what I was trying to propose near the end of my Ah, very clever. I think that should have nice behavior most of the time, though I wonder about a pathological case where we have many files, all very similar to each other, and then have a commit where they all start to diverge, but just by a small amount, while getting moved. We would end up with an artificially low score between renamed files (because we've thrown out all of the commonality) which may lead us to believe ...

I think I can make this a lot clearer than I did, while glossing over some details and the line_threshold parameter. 1) Make a "left index" and a "right index" out of the 2 sets of files, { line => [list of docs] }. 2) Remove any lines that appear in more than one doc from the left index. Do the same for the right index. (this corresponds to line_threshold=1 case) 3) For all lines, if the line appears in *both* the left index and the right index, increment the count of the (row=doc from...

Signed-off-by: Scott R Parish <srp@srparish.net> --- git.c | 5 ++--- help.c | 4 ++-- 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/git.c b/git.c index 853e66c..e1c99e3 100644 --- a/git.c +++ b/git.c @@ -445,9 +445,8 @@ int main(int argc, const char **argv) if (!prefixcmp(argv[0], "--")) argv[0] += 2; } else { - /* Default command: "help" */ - argv[0] = "help"; - argc = 1; + /* The user didn't specify a command; give them help */ + help_unknown...

test "x$TERM" != "xdumb" && tput hpa 60 >/dev/null 2>&1 && tput setaf 1 >/dev/null 2>&1 && color=t What if tput is not available, like on Windows? How about this (at the end of the file, so it can obey --no-color): if test "$color"; then say_color () { test "$1" != '-1' && tput setaf "$1" shift echo "* $*" tput op } else say_color() { shift echo "* $*" } color=; shift ;; -- Hannes "We don't need no do...

I was too terse, sorry. I wanted to point out that if tput is not available, the second invocation will leave "tput: command not found" behind on stderr. Therefore, I proposed to make the definition of say_color() different depending on whether $color is set or not. Then you don't need to test for $color twice inside the function. -- Hannes -

^^^^^^^^ There is no 2>/dev/null. Am I missing something? -- Hannes -

"git init --shared=all" was failing because chmod was returning EPERM. According to the man page, the set-group-id behavior is already default: man 2 mkdir: The directory's group ID is set to that of the parent directory in which it is created. Signed-off-by: Scott R Parish <srp@srparish.net> --- path.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/path.c b/path.c index 4260952..4089753 100644 --- a/path.c +++ b/path.c @@ -282,8 +282,10 @@ int adjust_...

This is a possibility, but i have no idea what that might be. I've tried googling around without any luck (except for a post about No, this was a failure when running tests (t1301-shared-repo.sh) sRp -- Scott Parish http://srparish.net/ -

Yes, I just got bitten by this. The top-level .cvsignore file ignores Makefile (since it's generated from ./configure), but Makefile exists in several subdirectories where it's *not* generated, but adding !Makefile to all those places doesn't sit too well with some of the project maintainers, and cvs doesn't grok /Makefile to mean "toplevel Makefile" I'll have a look at it. Thanks for the review. -- Andreas Ericsson andreas.ericsson@op5.se OP5 AB ...

This stems from creating scripts around it where I only want to see the numbers if there is more than a single patch. Currently I can't do that without running git-format-patch twice or re-implementing the revision parsing machinery to count revisions prior to passing arguments to That's sort of implicit in [PATCH], since all patch-series added by the tool I'm scripting will have [PATCH n/m], while I'd prefer for Would a separate option be acceptable to you? It doesn't have to be fancy ...

Because 23498~12 != 23498~12..HEAD to git rev-list, but it is to git-format-patch, meaning I'll have to duplicate the logic in every script that's supposed to use it or risk introducing a third way of Semantics could be equally clear for --numbered-if-multiple. -- Andreas Ericsson andreas.ericsson@op5.se OP5 AB www.op5.se Tel: +46 8-230225 Fax: +46 8-230231 -

Here are the topics that have been cooking. Commits prefixed with '-' are only in 'pu' while commits prefixed with '+' are in 'next'. The topics list the commits in reverse chronological order. * cc/skip (Mon Oct 22 07:49:39 2007 +0200) 9 commits - Bisect: add a "bisect replay" test case. - Bisect: add "bisect skip" to the documentation. - Bisect: factorise "bisect_{bad,good,skip}" into "bisect_state". - Bisect: factorise some logging into "bisect_write". - Bisect: factorise "bisect_write_...

You also can ask me to resubmit them when the first round of parseopt is merged. I'm actually waiting for that before I work on it again (that's not the sole reason, $work ate my time as well, so I'm not pressuring ;P) and I can send those again when things are more ready for them. Like I said to you on IRC, I intend to hack a way to ask parse-options to dump its options in a machine parseable way, to help {z,ba}sh completions authors. And obviously I intend to migrate even more builtins :) ...

I will eventually get around to rewriting this (it seems the list comments have died down), but it is much more interesting to play with Linus' rename stuff tonight. :) If somebody else wants to take a stab, please go ahead. -Peff -

Signed-off-by: Christian Couder <chriscool@tuxfamily.org> --- t/t6030-bisect-porcelain.sh | 7 +++++++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/t/t6030-bisect-porcelain.sh b/t/t6030-bisect-porcelain.sh index db82259..16d0c4a 100755 --- a/t/t6030-bisect-porcelain.sh +++ b/t/t6030-bisect-porcelain.sh @@ -167,6 +167,13 @@ test_expect_success 'bisect skip: add line and then a new test' ' git bisect skip && git bisect good > my_bisect_log.txt && ...