On Mon, Oct 22, 2007 at 12:18:22PM +0000, Johannes Sixt wrote:
quoted text
> Pierre Habouzit schrieb:
> >On Mon, Oct 22, 2007 at 11:35:30AM +0000, Johannes Sixt wrote:
> >>Pierre Habouzit schrieb:
> >>>On Mon, Oct 22, 2007 at 08:53:36AM +0000, Johannes Sixt wrote:
> >>>>Pierre Habouzit schrieb:
> >>>>>+say_color () {
> >>>>>+	[ "$nocolor" =3D 0 ] &&  [ "" !=3D '-1' ] && tput setaf ""
> >>>>>+	shift
> >>>>>+	echo "* $*"
> >>>>>+	tput op
>        ^^^^^^^^
> I am talking about this line.

  Oooh, good catch :P it should be guarded by a [ "$nocolor" =3D 0 ]
indeed :P (or use your solution).

quoted text
> >>>>>+}
> >>I wanted to point out that if tput is not available, the second=20
> >>invocation will leave "tput: command not found" behind on stderr.=20
> >>Therefore, I proposed to make the definition of say_color() different=
=20
quoted text
> >>depending on whether $color is set or not. Then you don't need to test=
=20
quoted text
> >>for $color twice inside the function.
> >  Right we can do that. I'll try to rework the patch. and no it
> >shouldn't leave tput: command not found as I 2>/dev/null and I think the
> >shell doesn't print that in that case. At least my zsh doesn't.
>=20
> There is no 2>/dev/null. Am I missing something?

  I was.

--=20
=C2=B7O=C2=B7  Pierre Habouzit
=C2=B7=C2=B7O                                                madcoder@debia=
n.org
OOO                                                http://www.madism.org