On Thu, Oct 18, 2007 at 02:25:36PM +0000, Steven Grimm wrote:=20 =20 Your argument is also bogus. IMNSHO, peer reviewing has nothing to do with git, svn, or $SCM. It's a social pattern. There are people that do it because they understand it's a good and necessary sound thing to do, and there are the others. Guess what, it has a lot to do with the 20%/80% line (that I would have more described as the 2/98 but well=E2=80=A6). Put git into the hands of fools, they won't proofread their code more or less than with svn. And they will shoot themselves into their foots twice as often as with svn. Though, for people that are able to deal with git and use it, git allows way better code reviewing patterns than with svn, because you can prepare a nice incremental branch that adds each new features you worked on with small patches (see my parse-options series). With svn, you can't do that, because there is no tool that allow you to record those patches on your end, so you submit a big +4123/-2341 patch. That makes peer reviewing really harder. Of course the git community is a perfect example of how code should be reviewed. But it's not because we use git, it's because we definitely are in the "20%". --=20 =C2=B7O=C2=B7 Pierre Habouzit =C2=B7=C2=B7O madcoder@debia= n.org OOO http://www.madism.org
| Oleg Nesterov | Re: [PATCH, RFC] reimplement flush_workqueue() |
| Linus Torvalds | Re: Linux 2.6.27-rc8 |
| Pavel Roskin | ndiswrapper and GPL-only symbols redux |
| Greg Kroah-Hartman | [PATCH 017/196] aoechr: Convert from class_device to device |
git: | |
| David Symonds | Re: git and binary files |
| Matthieu Moy | git push to a non-bare repository |
| Felipe Oliveira Carvalho | Re: [RFC] Zit: the git-based single file content tracker |
| Jakub Narebski | Re: [VOTE] git versus mercurial (for DragonflyBSD) |
| Patrick McHardy | netfilter 05/29: netns ebtables: part 2 |
| Templin, Fred L | [Resend][PATCH 01/05] ipv6: RFC4214 Support (4) |
| Laszlo Attila Toth | [PATCHv7 0/5 + 3] Interface group patches |
| Jarek Poplawski | Re: [PATCH] pkt_sched: Destroy gen estimators under rtnl_lock(). |
| Han Boetes | shutdown gets stuck at `syncing discs...' |
| Leon Dippenaar | New tcp stack attack |
| Richard Stallman | Real men don't attack straw men |
| GVG GVG | ssh_exchange_identification: Connection closed by remote host |
