Re: [RFC/PATCH] git-fetch: mega-terse fetch output

view
thread

!MAILaRCHIVE_VOTE_RePLACE

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

[view in full thread]

From: Andreas Ericsson <ae@...>

To: Shawn O. Pearce <spearce@...>

Cc: David Symonds <dsymonds@...>, Jeff King <peff@...>, <git@...>

Subject: Re: [RFC/PATCH] git-fetch: mega-terse fetch output

Date: Friday, October 19, 2007 - 6:51 am

Shawn O. Pearce wrote:
quoted text>  
> +static void determine_window_size(void)
> +{
> +	struct winsize ws;
> +	if (!ioctl(2, TIOCGWINSZ, &ws))
> +		ws_cols = ws.ws_col;
> +}
> +

I'd suggest re-using term_columns() from help.c instead. It's been in there
since the git wrapper was rewritten in C, so it's had a bit of testing and
seems to work fairly well.

-- 
Andreas Ericsson                   andreas.ericsson@op5.se
OP5 AB                             www.op5.se
Tel: +46 8-230225                  Fax: +46 8-230231
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:

[RFC/PATCH] git-fetch: mega-terse fetch output, Jeff King, (Fri Oct 19, 2:22 am)

Re: [RFC/PATCH] git-fetch: mega-terse fetch output, Andreas Ericsson, (Fri Oct 19, 6:40 am)

Re: [RFC/PATCH] git-fetch: mega-terse fetch output, David Symonds, (Fri Oct 19, 2:39 am)

Re: [RFC/PATCH] git-fetch: mega-terse fetch output, Shawn O. Pearce, (Fri Oct 19, 3:39 am)

Re: [RFC/PATCH] git-fetch: mega-terse fetch output, Steven Grimm, (Fri Oct 19, 11:50 am)

Re: [RFC/PATCH] git-fetch: mega-terse fetch output, Nicolas Pitre, (Fri Oct 19, 12:12 pm)

Re: [RFC/PATCH] git-fetch: mega-terse fetch output, Sam Ravnborg, (Fri Oct 19, 1:26 pm)

Re: [RFC/PATCH] git-fetch: mega-terse fetch output, Nicolas Pitre, (Fri Oct 19, 2:51 pm)

Re: [RFC/PATCH] git-fetch: mega-terse fetch output, Steven Grimm, (Fri Oct 19, 11:53 am)

Re: [RFC/PATCH] git-fetch: mega-terse fetch output, Nicolas Pitre, (Fri Oct 19, 9:05 am)

Re: [RFC/PATCH] git-fetch: mega-terse fetch output, Andreas Ericsson, (Fri Oct 19, 6:51 am)

Re: [RFC/PATCH] git-fetch: mega-terse fetch output, Andreas Ericsson, (Fri Oct 19, 6:45 am)

Re: [RFC/PATCH] git-fetch: mega-terse fetch output, Santi Béjar, (Fri Oct 19, 6:03 am)

Re: [RFC/PATCH] git-fetch: mega-terse fetch output, Nicolas Pitre, (Fri Oct 19, 9:15 am)

Re: [RFC/PATCH] git-fetch: mega-terse fetch output, Miles Bader, (Tue Oct 23, 4:39 am)

Re: [RFC/PATCH] git-fetch: mega-terse fetch output, Theodore Tso, (Fri Oct 19, 7:38 am)

Re: [RFC/PATCH] git-fetch: mega-terse fetch output, Karl , (Fri Oct 19, 10:38 am)

Re: [RFC/PATCH] git-fetch: mega-terse fetch output, Nicolas Pitre, (Fri Oct 19, 11:03 am)

Re: [RFC/PATCH] git-fetch: mega-terse fetch output, Theodore Tso, (Fri Oct 19, 5:17 pm)

Re: [RFC/PATCH] git-fetch: mega-terse fetch output, Nicolas Pitre, (Fri Oct 19, 5:40 pm)

Re: [RFC/PATCH] git-fetch: mega-terse fetch output, Theodore Tso, (Fri Oct 19, 5:58 pm)

Re: [RFC/PATCH] git-fetch: mega-terse fetch output, Johannes Sixt, (Fri Oct 19, 8:31 am)

Re: [RFC/PATCH] git-fetch: mega-terse fetch output, Nicolas Pitre, (Fri Oct 19, 10:14 am)

Re: [RFC/PATCH] git-fetch: mega-terse fetch output, Jeff King, (Sat Oct 20, 1:00 am)

Re: [RFC/PATCH] git-fetch: mega-terse fetch output, Shawn O. Pearce, (Sat Oct 20, 2:58 am)

Re: [RFC/PATCH] git-fetch: mega-terse fetch output, Santi Béjar, (Fri Oct 19, 10:31 am)

Re: [RFC/PATCH] git-fetch: mega-terse fetch output, Nicolas Pitre, (Fri Oct 19, 10:52 am)

Re: [RFC/PATCH] git-fetch: mega-terse fetch output, Johannes Schindelin, (Fri Oct 19, 10:41 am)

Re: [RFC/PATCH] git-fetch: mega-terse fetch output, Nicolas Pitre, (Fri Oct 19, 10:56 am)

Re: [RFC/PATCH] git-fetch: mega-terse fetch output, Karl , (Fri Oct 19, 10:40 am)

Re: [RFC/PATCH] git-fetch: mega-terse fetch output, Johannes Sixt, (Fri Oct 19, 10:40 am)

Re: [RFC/PATCH] git-fetch: mega-terse fetch output, Nicolas Pitre, (Fri Oct 19, 10:54 am)

Re: [RFC/PATCH] git-fetch: mega-terse fetch output, Johannes Schindelin, (Fri Oct 19, 10:31 am)

Re: [RFC/PATCH] git-fetch: mega-terse fetch output, Johannes Sixt, (Fri Oct 19, 4:21 am)

Re: [RFC/PATCH] git-fetch: mega-terse fetch output, Jeff King, (Fri Oct 19, 3:57 am)

Re: [RFC/PATCH] git-fetch: mega-terse fetch output, Shawn O. Pearce, (Fri Oct 19, 4:07 am)

Re: [RFC/PATCH] git-fetch: mega-terse fetch output, Jeff King, (Fri Oct 19, 4:11 am)

Re: [RFC/PATCH] git-fetch: mega-terse fetch output, Jeff King, (Fri Oct 19, 2:46 am)

Navigation

Popular discussions


linux-kernel:
david	Re: Dual-Licensing Linux Kernel with GPL V2 and GPL V3
Greg KH	[2.6.22.2 review 05/84] Fix deadlocks in sparc serial console.
Greg KH	[GIT PATCH] driver core patches against 2.6.24
Andrew Morton	-mm merge plans for 2.6.23
git:

linux-netdev:
Jeff Kirsher	[RESEND][NET-NEXT PATCH 01/29] ixgbe: fix bug where using wake queue instead of st...
Gerrit Renker	[PATCH 27/37] dccp: Integration of dynamic feature activation - part 2 (server side)
Jarek Poplawski	[PATCH] pkt_sched: Destroy gen estimators under rtnl_lock().
Patrick McHardy	Re: [GIT]: Networking
netbsd-tech-kern:
Manuel Bouyer	Re: Interactive performance in -current
Christian Limpach	Re: newfs: determining file system parameters
YAMAMOTO Takashi	Re: statvfs(2) replacement for statfs(2) patch
Charles M. Hannum	Re: kern/22869: Slave IDE drive not detected

Colocation donated by:

Online users

Syndicate