Re: [PATCH] git-blame shouldn't crash if run in an unmerged tree

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Shawn O. Pearce <spearce@...>
Cc: <git@...>, <B.Steinbrink@...>
Date: Thursday, October 18, 2007 - 6:38 pm

On Thu, 18 Oct 2007, Shawn O. Pearce wrote:

Please feel free to add a Signed-off-by: there. I guess I didn't add it in 
the original email, because I wasn't sure if I'd have the energy to see if 
I could just remove the clearing of "ce_mode". I never did.

That whole "ce->ce_mode = 0" thing is really hacky, and we use it for two 
totally different things ("git read-tree" uses it for "delete this entry", 
and reading the index uses it when you ask for only merged entries). Bad 
form, and not very logical.

		Linus


-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH] git-blame shouldn't crash if run in an unmerged tree, Shawn O. Pearce, (Thu Oct 18, 2:34 am)
Re: [PATCH] git-blame shouldn't crash if run in an unmerged ..., Linus Torvalds, (Thu Oct 18, 6:38 pm)