Re: [PATCH] gitweb: Speed up get_projects_list for large source trees

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Luke Lu <git@...>
Cc: <git@...>
Date: Tuesday, October 16, 2007 - 12:55 pm

Luke Lu wrote:

Hello Luke, and welcome to the community :)


It shows. The patch is whitespace damaged, and the commit message leaves
a little something to desire. I suggest you read through
Documentation/SubmittingPatches and then re-send your patch. Try sending
to yourself and looking at the result with a monospace font. It's what I
always do to make sure patches look okay before sending them to the list.

Not trying to be rude or anything. Oldtime list-members sometimes get to
hear the exact same thing.

Also, Junio, the maintainer, is currently away, so don't worry if your
patches are left in limbo for some time. Someone will pick it up and
carry it forward for Junio to pull, or he'll hack up some script to
get all patces from his mailbox and review them one by one. He's a very
thorough fellow, usually.


Sweet job :)

I'll have to test this, as we've got a few repos at work with a checked out
working tree connected to the repos. I haven't run into your issues though,
but perhaps that's because we run it under Linux.

-- 
Andreas Ericsson                   andreas.ericsson@op5.se
OP5 AB                             www.op5.se
Tel: +46 8-230225                  Fax: +46 8-230231
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH] Git homepage: remove all the references to Cogito, Paolo Ciarrocchi, (Mon Oct 15, 5:38 pm)
Re: [PATCH] Git homepage: remove all the references to Cogito, Paolo Ciarrocchi, (Tue Oct 16, 4:01 am)
Re: [PATCH] gitweb: Speed up get_projects_list for large sou..., Andreas Ericsson, (Tue Oct 16, 12:55 pm)
cogito and remote#branch, was Re: [PATCH] Git homepage: remo..., Johannes Schindelin, (Tue Oct 16, 6:49 am)
Re: remote#branch, Jan Hudec, (Tue Oct 16, 5:09 pm)
Re: remote#branch, Johannes Schindelin, (Tue Oct 16, 5:35 pm)
Re: remote#branch, Jan Hudec, (Sat Oct 27, 4:47 pm)
Re: remote#branch, Johannes Schindelin, (Sat Oct 27, 7:01 pm)
Re: remote#branch, Jan Hudec, (Mon Oct 29, 1:40 pm)
Re: remote#branch, Johannes Schindelin, (Mon Oct 29, 2:32 pm)
Re: remote#branch, Linus Torvalds, (Mon Oct 29, 2:17 pm)
Re: remote#branch, Theodore Tso, (Mon Oct 29, 5:49 pm)
Re: remote#branch, Linus Torvalds, (Mon Oct 29, 6:57 pm)
Re: remote#branch, Johannes Schindelin, (Mon Oct 29, 7:49 pm)
Re: remote#branch, Theodore Tso, (Mon Oct 29, 11:01 pm)
Re: remote#branch, Linus Torvalds, (Tue Oct 30, 12:50 am)
Re: remote#branch, Junio C Hamano, (Mon Oct 29, 11:40 pm)
Re: remote#branch, Theodore Tso, (Tue Oct 30, 12:40 am)
Re: remote#branch, Linus Torvalds, (Tue Oct 30, 12:51 am)
Re: remote#branch, Martin Langhoff, (Tue Oct 30, 8:41 pm)
Re: remote#branch, Jeff King, (Tue Oct 30, 9:43 pm)
Re: remote#branch, Johannes Schindelin, (Tue Oct 30, 11:08 pm)
Re: remote#branch, Martin Langhoff, (Tue Oct 30, 9:49 pm)
Re: remote#branch, Jeff King, (Tue Oct 30, 9:59 pm)
Re: remote#branch, Linus Torvalds, (Tue Oct 30, 8:59 pm)
Re: remote#branch, Johannes Schindelin, (Tue Oct 30, 6:02 am)
Re: remote#branch, Tom Prince, (Tue Oct 30, 1:37 am)
Re: remote#branch, Linus Torvalds, (Tue Oct 30, 10:59 am)
Re: remote#branch, Jan Hudec, (Tue Oct 30, 3:36 pm)
Re: remote#branch, Erik Warendorph, (Wed Oct 31, 3:29 pm)
Re: remote#branch, Linus Torvalds, (Tue Oct 30, 3:53 pm)
Re: remote#branch, Tom Prince, (Tue Oct 30, 12:02 pm)
Re: remote#branch, Linus Torvalds, (Tue Oct 30, 1:39 pm)
Re: remote#branch, Matthieu Moy, (Tue Oct 30, 1:49 pm)
Re: remote#branch, Linus Torvalds, (Tue Oct 30, 1:58 pm)
Re: remote#branch, Linus Torvalds, (Tue Oct 30, 2:19 pm)
Re: remote#branch, Pascal Obry, (Tue Oct 30, 3:18 pm)
Re: remote#branch, Linus Torvalds, (Tue Oct 30, 3:38 pm)
Re: remote#branch, Jeff King, (Tue Oct 30, 7:58 pm)
Re: remote#branch, Petr Baudis, (Wed Oct 31, 1:13 pm)
Re: remote#branch, David Kastrup, (Wed Oct 31, 2:39 am)
Re: remote#branch, Pascal Obry, (Wed Oct 31, 5:34 am)
Re: remote#branch, Robin Rosenberg, (Wed Oct 31, 4:25 am)
Re: remote#branch, Wincent Colaiuta, (Wed Oct 31, 4:16 am)
Re: remote#branch, Randal L. Schwartz, (Tue Oct 30, 4:15 pm)
Re: remote#branch, Nicolas Pitre, (Tue Oct 30, 4:36 pm)
Re: remote#branch, Linus Torvalds, (Tue Oct 30, 4:30 pm)
Re: remote#branch, Pascal Obry, (Tue Oct 30, 3:15 pm)