Re: On Tabs and Spaces

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Shawn O. Pearce
Date: Tuesday, October 16, 2007 - 12:04 am

Michael Witten <mfwitten@MIT.EDU> wrote:

The C code is all tabs, with the tabs set at 8 spaces, but the
actual tab width isn't too important here as we never use the tab
for alignment beyond the left indent.

The bulk of the Perl/shell is also done that way, but you may
run into a place where it isn't.  In which case try to match the
existing identation within that block as best as you can so the diff
is minimal and the resulting file still indents just as good/bad
as it did before.

You may also consider submitting a whitespace correction patch in
front of your actual code change to correct the offending part of
the file, but every line you touch is that much more work for your
peers to review and test.  In short changing code is bad unless
there is a really compelling reason...

-- 
Shawn.
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
On Tabs and Spaces, Michael Witten, (Mon Oct 15, 11:45 pm)
Re: On Tabs and Spaces, Shawn O. Pearce, (Tue Oct 16, 12:04 am)
Re: On Tabs and Spaces, Michael Witten, (Tue Oct 16, 12:27 am)
Re: On Tabs and Spaces, Adam Piatyszek, (Tue Oct 16, 1:30 am)
Re: On Tabs and Spaces, Lars Hjemli, (Tue Oct 16, 2:04 am)
Re: On Tabs and Spaces, Adam Piatyszek, (Tue Oct 16, 3:16 am)
Re: On Tabs and Spaces, Jeffrey C. Ollie, (Tue Oct 16, 8:26 am)
Re: On Tabs and Spaces, Michael Witten, (Tue Oct 16, 8:51 am)
Re: On Tabs and Spaces, Andreas Ericsson, (Tue Oct 16, 10:20 am)
Re: On Tabs and Spaces, Andreas Ericsson, (Tue Oct 16, 10:23 am)
Re: On Tabs and Spaces, Sam Ravnborg, (Tue Oct 16, 10:40 am)
Re: On Tabs and Spaces, Jan-Benedict Glaw, (Tue Oct 16, 11:34 am)
Re: On Tabs and Spaces, Andreas Ericsson, (Tue Oct 16, 11:51 am)
Re: On Tabs and Spaces, Petr Baudis, (Tue Oct 16, 4:09 pm)
Re: On Tabs and Spaces, David, (Tue Oct 16, 8:41 pm)
Re: On Tabs and Spaces, Andy Parkins, (Wed Oct 17, 4:32 am)
Re: On Tabs and Spaces, Robin Rosenberg, (Sat Oct 20, 6:54 am)