Home » Mailing list archives » git » 2007 » October » 15

Re: [PATCH] Color support added to git-add--interactive.

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Jeff King
Subject: Re: [PATCH] Color support added to git-add--interactive.
Date: Sunday, October 14, 2007 - 9:12 pm

On Sat, Oct 13, 2007 at 04:45:41PM +0200, Wincent Colaiuta wrote:


BTW, this approach is totally bogus. The hunks that we store end up
getting fed back to git-apply when we stage them (which doesn't
understand the color codes).

Just try using your patch to actually stage a hunk; nothing happens (and
the error is almost impossible to see, since we show the bogus diff on
stderr).

So now I am doubly convinced that colorizing the diffs in
add--interactive is the right thing (and it looks like Tom Tobin has
already done a fair bit of the work).

-Peff
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH] Color support added to git-add--interactive., Dan Zwell, (Fri Oct 12, 9:13 pm)
Re: [PATCH] Color support added to git-add--interactive., Jeff King, (Sat Oct 13, 1:12 am)
Re: [PATCH] Color support added to git-add--interactive., Johannes Schindelin, (Sat Oct 13, 5:25 am)
Re: [PATCH] Color support added to git-add--interactive., Frank Lichtenheld, (Sat Oct 13, 5:49 am)
Re: [PATCH] Color support added to git-add--interactive., Wincent Colaiuta, (Sat Oct 13, 7:45 am)
Re: [PATCH] Color support added to git-add--interactive., Jean-Luc Herren, (Sat Oct 13, 9:38 am)
Re: [PATCH] Color support added to git-add--interactive., Johannes Schindelin, (Sat Oct 13, 9:38 am)
Re: [PATCH] Color support added to git-add--interactive., Wincent Colaiuta, (Sat Oct 13, 10:14 am)
Re: [PATCH] Color support added to git-add--interactive., Jeff King, (Sat Oct 13, 10:27 am)
Re: [PATCH] Color support added to git-add--interactive., Jeff King, (Sat Oct 13, 10:51 am)
Re: [PATCH] Color support added to git-add--interactive., Andreas Ericsson, (Sat Oct 13, 11:31 am)
Re: [PATCH] Color support added to git-add--interactive., Dan Zwell, (Sat Oct 13, 1:03 pm)
Re: [PATCH] Color support added to git-add--interactive., Tom Tobin, (Sat Oct 13, 1:21 pm)
Re: [PATCH] Color support added to git-add--interactive., Tom Tobin, (Sat Oct 13, 1:26 pm)
Re: [PATCH] Color support added to git-add--interactive., Wincent Colaiuta, (Sat Oct 13, 1:36 pm)
Re: [PATCH] Color support added to git-add--interactive., Dan Z, (Sat Oct 13, 2:50 pm)
Re: [PATCH] Color support added to git-add--interactive., Jean-Luc Herren, (Sat Oct 13, 3:23 pm)
Re: [PATCH] Color support added to git-add--interactive., Jeff King, (Sun Oct 14, 8:43 pm)
Re: [PATCH] Color support added to git-add--interactive., Jeff King, (Sun Oct 14, 9:12 pm)
Re: revised: [PATCH] Color support added to git-add--inter ..., Dan Zwell, (Tue Oct 16, 5:47 pm)
Re: revised: [PATCH] Color support added to git-add--inter ..., Shawn O. Pearce, (Tue Oct 16, 6:51 pm)
Re: revised: [PATCH] Color support added to git-add--inter ..., Dan Zwell, (Wed Oct 17, 12:57 am)
Re: revised: [PATCH] Color support added to git-add--inter ..., Shawn O. Pearce, (Wed Oct 17, 1:11 am)
[PATCH 1/2] Added basic color support to git add --interactive, Dan Zwell, (Mon Oct 22, 2:32 pm)
[PATCH 2/2] Let git-add--interactive read colors from git- ..., Dan Zwell, (Mon Oct 22, 2:40 pm)
Re: [PATCH] resend of git-add--interactive color patch aga ..., Dan Zwell, (Mon Oct 22, 7:11 pm)
[PATCH] Let git-add--interactive read "git colors" from gi ..., Dan Zwell, (Mon Oct 22, 7:19 pm)
Re: [PATCH 1/2] Added basic color support to git add --int ..., Jeff King, (Mon Oct 22, 9:03 pm)
Re: [PATCH 2/2] Let git-add--interactive read colors from ..., Jeff King, (Mon Oct 22, 9:27 pm)
Re: [PATCH] Let git-add--interactive read "git colors" fro ..., Jeff King, (Mon Oct 22, 9:29 pm)
Re: [PATCH] Let git-add--interactive read "git colors" fro ..., Shawn O. Pearce, (Mon Oct 22, 9:40 pm)
Re: [PATCH 1/2] Added basic color support to git add --int ..., Wincent Colaiuta, (Mon Oct 22, 11:28 pm)
Re: [PATCH 1/2] Added basic color support to git add --int ..., Jeff King, (Mon Oct 22, 11:41 pm)
Re: [PATCH 1/2] Added basic color support to git add --int ..., Wincent Colaiuta, (Tue Oct 23, 12:44 am)
Re: [PATCH 2/2] Let git-add--interactive read colors from ..., Dan Zwell, (Tue Oct 23, 1:52 am)
[PATCH 1/2] Added basic color support to git add --interactive, Dan Zwell, (Fri Nov 2, 8:41 pm)
[PATCH 2/2] Let git-add--interactive read colors from .git ..., Dan Zwell, (Fri Nov 2, 8:41 pm)
Re: *[PATCH 2/2] Let git-add--interactive read colors from ..., Junio C Hamano, (Fri Nov 2, 10:06 pm)
Re: *[PATCH 2/2] Let git-add--interactive read colors from ..., Dan Zwell, (Sat Nov 3, 12:26 am)
Re: *[PATCH 2/2] Let git-add--interactive read colors from ..., Junio C Hamano, (Sat Nov 3, 11:11 am)
Re: [PATCH 1/2] Added basic color support to git add --int ..., Jeff King, (Sat Nov 3, 9:57 pm)
Re: [PATCH 1/2] Added basic color support to git add --int ..., Junio C Hamano, (Sat Nov 3, 10:36 pm)
Re: [PATCH 1/2] Added basic color support to git add --int ..., Jeff King, (Sat Nov 3, 10:43 pm)
[PATCH 0/3] Adding colors to git-add--interactive, Dan Zwell, (Sat Nov 10, 5:01 pm)
[PATCH 1/3] Added basic color support to git add --interactive, Dan Zwell, (Sat Nov 10, 5:01 pm)
[PATCH 2/3] Let git-add--interactive read colors from .git ..., Dan Zwell, (Sat Nov 10, 5:02 pm)
[PATCH 3/3] Added diff hunk coloring to git-add--interactive, Dan Zwell, (Sat Nov 10, 5:03 pm)
[PATCH 0/3] Adding colors to git-add--interactive, Dan Zwell, (Sat Nov 10, 7:21 pm)
Subject: [PATCH 1/3] Added basic color support to git add ..., Dan Zwell, (Sat Nov 10, 7:23 pm)
Subject: [PATCH 2/3] Let git-add--interactive read colors ..., Dan Zwell, (Sat Nov 10, 7:23 pm)
Re: [PATCH 0/3] Adding colors to git-add--interactive, Jeff King, (Sun Nov 11, 12:54 am)
Re: [PATCH 0/3] Adding colors to git-add--interactive, Junio C Hamano, (Sun Nov 11, 1:23 am)
Re: [PATCH 0/3] Adding colors to git-add--interactive, Dan Zwell, (Sun Nov 11, 1:39 am)
Re: Subject: [PATCH 2/3] Let git-add--interactive read col ..., Junio C Hamano, (Sun Nov 11, 2:53 am)
Re: [PATCH 3/3] Added diff hunk coloring to git-add--inter ..., Junio C Hamano, (Sun Nov 11, 3:00 am)
Re: Subject: [PATCH 2/3] Let git-add--interactive read col ..., Junio C Hamano, (Sun Nov 11, 3:34 am)
Re: Subject: [PATCH 2/3] Let git-add--interactive read col ..., Dan Zwell, (Mon Nov 12, 6:39 pm)
Re: Subject: [PATCH 2/3] Let git-add--interactive read col ..., Junio C Hamano, (Mon Nov 12, 7:32 pm)
Re: Subject: [PATCH 2/3] Let git-add--interactive read col ..., Dan Zwell, (Mon Nov 12, 7:55 pm)
Re: Subject: [PATCH 2/3] Let git-add--interactive read col ..., Jeff King, (Tue Nov 13, 12:26 am)
[PATCH 0/5] Colors for git-add--interactive, Dan Zwell, (Thu Nov 22, 3:54 am)
[PATCH 1/5] Added basic color support to git add --interactive, Dan Zwell, (Thu Nov 22, 3:54 am)
[PATCH 2/5] Don't return 'undef' in case called in a vecto ..., Dan Zwell, (Thu Nov 22, 3:55 am)
[PATCH 3/5] Added config_default($key, $default) to Git.pm, Dan Zwell, (Thu Nov 22, 3:55 am)
[PATCH 4/5] Let git-add--interactive read colors from conf ..., Dan Zwell, (Thu Nov 22, 3:56 am)
[PATCH 5/5] Added diff hunk coloring to git-add--interactive, Dan Zwell, (Thu Nov 22, 3:56 am)
Re: [PATCH 0/5] Colors for git-add--interactive, Jeff King, (Thu Nov 22, 4:57 am)
Re: [PATCH 2/5] Don't return 'undef' in case called in a v ..., Jeff King, (Thu Nov 22, 5:06 am)
Re: [PATCH 3/5] Added config_default($key, $default) to Git.pm, Jeff King, (Thu Nov 22, 5:14 am)
Re: [PATCH 4/5] Let git-add--interactive read colors from ..., Jeff King, (Thu Nov 22, 5:18 am)
Re: [PATCH 5/5] Added diff hunk coloring to git-add--inter ..., Jeff King, (Thu Nov 22, 5:25 am)
Re: [PATCH 0/5] Colors for git-add--interactive, Junio C Hamano, (Thu Nov 22, 12:20 pm)
Re: [PATCH 2/5] Don't return 'undef' in case called in a v ..., Junio C Hamano, (Thu Nov 22, 2:17 pm)
Re: [PATCH 4/5] Let git-add--interactive read colors from ..., Junio C Hamano, (Thu Nov 22, 2:28 pm)
Re: [PATCH 5/5] Added diff hunk coloring to git-add--inter ..., Junio C Hamano, (Thu Nov 22, 2:37 pm)
Re: [PATCH 4/5] Let git-add--interactive read colors from ..., Jeff King, (Thu Nov 22, 3:30 pm)
Re: [PATCH 5/5] Added diff hunk coloring to git-add--inter ..., Junio C Hamano, (Thu Nov 22, 3:35 pm)
Re: [PATCH 2/5] Don't return 'undef' in case called in a v ..., Dan Zwell, (Thu Nov 22, 9:15 pm)
Re: [PATCH 4/5] Let git-add--interactive read colors from ..., Dan Zwell, (Thu Nov 22, 10:32 pm)
Re: [PATCH 4/5] Let git-add--interactive read colors from ..., Jeff King, (Fri Nov 23, 2:09 am)
Re: [PATCH 4/5] Let git-add--interactive read colors from ..., Junio C Hamano, (Fri Nov 23, 2:17 am)
Re: [PATCH 5/5] Added diff hunk coloring to git-add--inter ..., Jeff King, (Fri Nov 23, 3:21 am)