Home » Mailing list archives » git » 2007 » October » 13

[bug] gitk can not read history if diff color is enabled

Previous thread: [RFC] CLI option parsing and usage generation for porcelains by Pierre Habouzit on Saturday, October 13, 2007 - 9:29 am. (50 messages)

Next thread: [PATCH] gitk: Added support for OS X mouse wheel by Jonathan del Strother on Saturday, October 13, 2007 - 1:33 pm. (1 message)
[view original message]
From: Mike Sharov <msharov@...>
To: <git@...>
Subject: [bug] gitk can not read history if diff color is enabled
Date: Saturday, October 13, 2007 - 10:18 am

Reproduced in git version 1.5.3.4.217.gbfc1, although it's been this way

for a while. To see the bug, enable color diff with


[diff]

color


and launch gitk on any repository (like the Linux kernel tree). The

result is a dialog box "Can't parse git log output '\x1b[33mcommit" etc.

qgit can still view the history without errors, so I guess it must be

possible to somehow turn off color for a specific query.

--

Mike

msharov@users.sourceforge.net

-
[view original message]
From: Michele Ballabio <barra_cuda@...>
To: <msharov@...>, <git@...>
Subject: Re: [bug] gitk can not read history if diff color is enabled
Date: Saturday, October 13, 2007 - 10:49 am

A patch was posted, and is queued here:


	http://hjemli.net/git/git/commit/?h=q/mb/gitk/log--no-color

-
[view original message]
From: Johannes Schindelin <Johannes.Schindelin@...>
To: <msharov@...>
Cc: <git@...>
Subject: Re: [bug] gitk can not read history if diff color is enabled
Date: Saturday, October 13, 2007 - 10:43 am

Hi,


Thanks for the bug report.


This is fixed in http://hjemli.net/git/git/log/?h=q/mb/gitk/log--no-color

(which will be applied without any doubt once our king penguin comes

back).


Ciao,

Dscho


-
Previous thread: [RFC] CLI option parsing and usage generation for porcelains by Pierre Habouzit on Saturday, October 13, 2007 - 9:29 am. (50 messages)

Next thread: [PATCH] gitk: Added support for OS X mouse wheel by Jonathan del Strother on Saturday, October 13, 2007 - 1:33 pm. (1 message)