login
Header Space

 
 

git mailing list

FromSubjectsort iconDate
Alexy Khrabrov
building git in a separate directory
Tried to build git 1.4.4.1 away from the source directory -- said make configure -- which made a configure, switched to a separate build/ directory, invoked that/../configure -- which ran fine, except produced no Makefile! What's the way to build git outside from the source directory? Cheers, Alexy -
Jan 8, 11:30 pm 2007
Horst H. von Brand
Re: building git in a separate directory
This is just the bare minimum required to use some of the autoconfiscating machinery, it is far from working. And IIUC, the git hackers won't ever go that route. It isn't set up for that currently. -- Dr. Horst H. von Brand User #22616 counter.li.org Departamento de Informatica Fono: +56 32 2654431 Universidad Tecnica Federico Santa Maria +56 32 2654239 Casilla 110-V, Valparaiso, Chile Fax: +56 32 2797513 -
Jan 8, 11:40 pm 2007
Shawn O. Pearce
Re: building git in a separate directory
I'm no sure that's supported right now. Someone tried to submit patches for it but I don't think they were applied. The configure script is really just a way to create a personal config.mak, which is the "real" way to configure Git prior to compiling it with Makefile. -- Shawn. -
Jan 8, 11:37 pm 2007
Martin Langhoff
[PATCH] cvsserver: fix revision number during file adds
With this patch, cvs add / cvs commit echoes back to the client the correct file version (1.1) so that the file in the checkout is recognised as up-to-date. Signed-off-by: Martin Langhoff <martin@catalyst.net.nz> --- git-cvsserver.perl | 5 ++++- 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/git-cvsserver.perl b/git-cvsserver.perl index 0b75f9c..81d478d 100755 --- a/git-cvsserver.perl +++ b/git-cvsserver.perl @@ -1181,12 +1181,15 @@ sub req_ci $filename = f...
Jan 8, 10:10 pm 2007
Martin Langhoff
[PATCH] cvsserver: detect early of we are up to date and avo...
if the SHA1 of our head matches the last SHA1 seen in the DB, avoid further processing. Signed-off-by: Martin Langhoff <martin@catalyst.net.nz> --- git-cvsserver.perl | 9 ++++++++- 1 files changed, 8 insertions(+), 1 deletions(-) diff --git a/git-cvsserver.perl b/git-cvsserver.perl index df39512..0b75f9c 100755 --- a/git-cvsserver.perl +++ b/git-cvsserver.perl @@ -2184,7 +2184,10 @@ sub update # first lets get the commit list $ENV{GIT_DIR} = $self->{git_path}; - ...
Jan 8, 10:10 pm 2007
Martin Langhoff
Re: [PATCH] cvsserver: detect early of we are up to date and...
Actually, that generates a warning on the initial checkout. The fix is to run the if as if (defined $lastcommit && $lastcommit eq $commitsha1) { # up-to-date Junio -- is it easy for you to fixup when you apply the patch? Otherwise, I'll be happy to repost it patch. cheers m -
Jan 8, 10:39 pm 2007
Junio C Hamano
Re: Pushing into a repository with working directory?
Push does not do any working tree operation, so you _could_ detach the HEAD to point at the commit that used to be at the tip of the branch and advance the tip of the branch as the push instructs. The user could start a new branch out of the detached HEAD (which is behind the tip of the original branch), make necessary commits and then merge that branch locally to the branch the push advanced if s/he wants to. However, I am not sure if that is easy to understand for the users. It would be sane...
Jan 8, 8:57 pm 2007
Shawn O. Pearce
Re: Pushing into a repository with working directory?
But from the working directory management tools' perspective HEAD *is* about the current index and the current working directory. If HEAD doesn't match the index and working directory closely enough then the user is going to do something stupid, like commit a negative delta by accident. Pushing into the current branch of a repository with a working directory probably shouldn't be allowed by default as users probably don't want to do that. But if --force is used then detaching the HEAD is probab...
Jan 8, 11:32 pm 2007
Junio C Hamano
[PATCH] --prune is now default for 'pack-refs'
There is no reason not to, really. Signed-off-by: Junio C Hamano <junkio@cox.net> --- diff --git a/Documentation/git-pack-refs.txt b/Documentation/git-pack-refs.txt index 5da5105..464269f 100644 --- a/Documentation/git-pack-refs.txt +++ b/Documentation/git-pack-refs.txt @@ -7,7 +7,7 @@ git-pack-refs - Pack heads and tags for efficient repository access SYNOPSIS -------- -'git-pack-refs' [--all] [--prune] +'git-pack-refs' [--all] [--no-prune] DESCRIPTION ----------- @@ -40,1...
Jan 8, 8:44 pm 2007
Jakub Narebski
Re: [PATCH 1/2] Sanitize for_each_reflog_ent()
I think that Junio was talking about the fact, that if you for example do need only refname and sha1, there is no need to parse object at all. If you don't need to, don't parse. -- Jakub Narebski Warsaw, Poland ShadeHawk on #git -
Jan 8, 8:15 pm 2007
Yann Dirson
[PATCH] Add contrib/stg-gitk: helper script to run gitk
Signed-off-by: Yann Dirson <ydirson@altern.org> --- Here is a small helper script implementing the display of current/named/all stgit stacks (or standard branches) in gitk. As noted earlier, that does not allow to see new refs by requesting an update from gitk, but it will still be useful to me at least :) contrib/stg-gitk | 59 ++++++++++++++++++++++++++++++++++++++++++++++++++++++ 1 files changed, 59 insertions(+), 0 deletions(-) diff --git a/contrib/stg-gitk b/contrib/stg-gi...
Jan 8, 6:12 pm 2007
Junio C Hamano
[PATCH] --utf8 is now default for 'git-am'
Since we are talking about allowing potentially incompatible UI changes in v1.5.0 iff the change improves the general situation, I would say why not. There is --no-utf8 flag to avoid re-coding from botching the log message just in case, but we may not even need it. Signed-off-by: Junio C Hamano <junkio@cox.net> --- Documentation/git-am.txt | 19 ++++++++++++++++--- git-am.sh | 8 +++++--- 2 files changed, 21 insertions(+), 6 deletions(-) diff --git a/Documentation/...
Jan 8, 5:59 pm 2007
Junio C Hamano
Re: a few remaining issues...
Updates to the previous "remaining issues" list before 1.5.0. * Bare repository. I think what I have in 'next' to add 'core.bare' configuration to make the bare repository detection safer is ready to be used to port the RFC patch from Shawn to forbid working-tree operations in a bare repository to prevent accidents from happening. It would be nice if we can cook it for a few days in 'next' and push it out to 'master' before v1.5.0-rc1. Volunteers? * Packed refs. 'git-pack-refs' should...
Jan 8, 5:59 pm 2007
Junio C Hamano
Re: a few remaining issues...
Bzzzzzt. Sorry, it is not. Although it is in 'next' and I am hoping we can straighten potential wrinkles out before -rc1. -
Jan 8, 6:14 pm 2007
Yann Dirson
Getting gitk to display all refs but stgit logs
Since v0.11, StGIT creates references to keep a hand on patch logs. This has the unfortunate side-effect that "gitk --all" suddenly shows all those very annoying, and soon becomes unusable on repositories for which was very convenient. I guess it would be acceptable to have stgit itself launch gitk with the correct options. The only way I could find to suppress these refs from the display is to find the refs ourselves and pipe them to gitk using --stdin: find .git/refs/ -type f -not -name '*....
Jan 8, 5:32 pm 2007
David Tweed
[ANNOUNCE] simple chronological versioning script
This is just to announce the release of a simple chronological versioning script using git as a back end. I wrote this basically for my personal use, and its a very simple script that I don't expect any more development on it (except minor bugfixes). I'm just making this generally available in case anyone else finds what is does useful. (I _believe_ it now deals with cases of vanishing and reappearing files correctly in all cases, but I may have missed some cases.) From the man-page: chronovers...
Jan 8, 4:48 pm 2007
Junio C Hamano Jan 8, 4:13 pm 2007
Junio C Hamano
Re: [PATCH] use xread where we are not checking for EAGAIN/E...
Thanks. Will queue in 'next' to cook for a few days with the intent to have it in v1.5.0-rc1. -
Jan 8, 4:13 pm 2007
Junio C Hamano
Re: [PATCH 1/2] Suggest use of "git add file1 file2" when th...
I think it is Ok to give hints for untracked files -- with experience eyes will learn to ignore them but by then they do not need hints. Please send in a correction as appropriate. -
Jan 8, 4:13 pm 2007
Michael Loeffler
[PATCH] git-commit: do not fail to print the diffstat even i...
Signed-off-by: Michael Loeffler <zvpunry@zvpunry.de> --- git-commit.sh | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/git-commit.sh b/git-commit.sh index 04aad5e..c2beb76 100755 --- a/git-commit.sh +++ b/git-commit.sh @@ -628,7 +628,7 @@ then if test -z "$quiet" then echo "Created${initial_commit:+ initial} commit $commit" - git-diff-tree --shortstat --summary --root --no-commit-id HEAD + git-diff-tree --shortstat --summary --root --no-commit-id HEAD ...
Jan 8, 3:23 pm 2007
Andy Whitcroft
[PATCH 4/4] short i/o: fix config updates to use write_in_full
We need to check that the writes we perform during the update of the users configuration work. Convert to using write_in_full(). Signed-off-by: Andy Whitcroft <apw@shadowen.org> --- diff --git a/config.c b/config.c index 5cbd130..2c9d07c 100644 --- a/config.c +++ b/config.c @@ -464,7 +464,15 @@ static int store_aux(const char* key, const char* value) return 0; } -static void store_write_section(int fd, const char* key) +static int write_error() +{ + fprintf(stderr, "Failed to ...
Jan 8, 11:58 am 2007
Andy Whitcroft
[PATCH 3/4] short i/o: fix calls to write to use xwrite or w...
We have a number of badly checked write() calls. Often we are expecting write() to write exactly the size we requested or fail, this fails to handle interrupts or short writes. Switch to using the new write_in_full(). Otherwise we at a minimum need to check for EINTR and EAGAIN, where this is appropriate use xwrite(). Note, the changes to config handling are much larger and handled in the next patch in the sequence. Signed-off-by: Andy Whitcroft <apw@shadowen.org> --- diff --git a/bu...
Jan 8, 11:58 am 2007
Andy Whitcroft
[PATCH 2/4] short i/o: fix calls to read to use xread or rea...
We have a number of badly checked read() calls. Often we are expecting read() to read exactly the size we requested or fail, this fails to handle interrupts or short reads. Add a read_in_full() providing those semantics. Otherwise we at a minimum need to check for EINTR and EAGAIN, where this is appropriate use xread(). Signed-off-by: Andy Whitcroft <apw@shadowen.org> --- diff --git a/builtin-grep.c b/builtin-grep.c index 3b1b1cb..2bfbdb7 100644 --- a/builtin-grep.c +++ b/builtin-grep...
Jan 8, 11:58 am 2007
Andy Whitcroft
[PATCH 1/4] short i/o: clean up the naming for the write_{in...
We recently introduced a write_in_full() which would either write the specified object or emit an error message and fail. In order to fix the read side we now want to introduce a read_in_full() but without an error emit. This patch cleans up the naming of this family of calls: 1) convert the existing write_or_whine() to write_or_whine_pipe() to better indicate its pipe specific nature, 2) convert the existing write_in_full() calls to write_or_whine() to better indicate its nature, 3) in...
Jan 8, 11:57 am 2007
Theodore Ts'o
I just pulled and built 'next'...
I just pulled and built 'next' and it reported a version number of 1.4.4.4.g71bb6 -- and not one v1.5.0-rc0.g71bb6. I can understand why, since it found the changes pulled in from the maint branch before it found the v1.5.0-rc0 tag --- but it could be more than a little misleading. Is this something that can be fixed in any way, short of finding all of the tags reachable from HEAD and then doing a sort? That seems like a gross kludge, but I can't think of any other way of fixing it. - Ted...
Jan 8, 9:32 am 2007
Junio C Hamano
Re: I just pulled and built 'next'...
One question is how you would sort the result. If you sort them by taggerdate, you would get v1.4.4.4 anyway ;-). If we go with topology, we do not necessarily have to find all the tags. When we hit a commit that is tagged, we can stop the traversal (so after finding v1.5.0-rc0, we do not have to go back along the 'master' lineage to find v1.4.4 tag). Traversing from the tip of 'master' (or 'next') this way we will notice that v1.5.0-rc0 and v1.4.4.4 are the candidates without going any furth...
Jan 8, 4:11 pm 2007
Theodore Tso
Re: I just pulled and built 'next'...
I was assuming either lexigraphically, or via some really complicated Yeah, that is the question. If we're willing to look at the tag name, it's pretty clear that if both v1.5.0-rc0 and v1.4.4.4 is reachable from the head, it should be based on the "newer" version, i.e., v1.5.0-rc0. A human can figure this out easily, but algorithimically we end up having to use something like the rpm or dpkg version comparison algorithm, both of which are hueristics that will sometimes get thigns wrong. ...
Jan 8, 5:00 pm 2007
Shawn O. Pearce
Re: I just pulled and built 'next'...
$ git rev-list v1.5.0-rc0..next | wc -l 687 $ git rev-list v1.4.4.4..next | wc -l 1051 So what about doing Junio's suggestion of going by topology and coming up with the possible set of tags (v1.5.0-rc0 and v1.4.4.4 right now), and if more than one is found compute the number of commits between each tag and the requested revision, and take the tag that has a smallest number of commits? I think it would come up right more often than not and avoids any sort of tag name parsing algorith...
Jan 8, 11:21 pm 2007
davidk
Re: [1/2 PATCH] git-svn: make multi-init less confusing
I tried set-tree now, and all I got was a perl crash: morpheus% git svn set-tree master.. diff-tree 8dba2b29df78184fef96bbbf9521387846b140b3 b5561ab7309e9b7b3acfacaa786358e7d90665c6 A .gitignore ... more files Use of uninitialized value in concatenation (.) or string at /usr/lib/perl5/SVN/Core.pm line 579. Malformed file: at /usr/local/bin/git-svn line 459 This is git f4bf2184ae8b79f95b9f56c1ea5455d04e559299 from Jan 1. Perl is v5.8.8 (Ubunty edgy) -- David Kågedal - ...
Jan 8, 9:11 am 2007
davidk
Re: [DRAFT] Branching and merging with git
I think this should be considered more peripheral, since it is really an independent piece, and nobody needs to read it to learn how git -- David Kågedal -
Jan 8, 9:04 am 2007
davidk
Re: [1/2 PATCH] git-svn: make multi-init less confusing
So if I want to commit a different subset, is that possible? In my case, I have a "master" branch with a few changes on top of git-svn that I never want to commit to svn. So what I want is to commit "master..HEAD". Can I do that with dcommit? It seems that "git svn set-tree master..HEAD" might do the trick. -- David Kågedal -
Jan 8, 8:58 am 2007
davidk
Re: [1/2 PATCH] git-svn: make multi-init less confusing
Ok, so I tried rewriting the documentation. But I'm still not sure I understand fully how it works. diff --git a/Documentation/git-svn.txt b/Documentation/git-svn.txt index f5f57e8..8c91e78 100644 --- a/Documentation/git-svn.txt +++ b/Documentation/git-svn.txt @@ -57,15 +57,18 @@ See '<<fetch-args,Additional Fetch Arguments>>' if you are interested in manually joining branches on commit. 'dcommit':: - Commit all diffs from a specified head directly to the SVN - repository, an...
Jan 8, 8:56 am 2007
Josef Sipek
[ANNOUNCE] Guilt 0.17
Guilt v0.17 is available for download. Guilt (Git Quilt) is a series of bash scripts which add a Mercurial queues-like functionality and interface to git. Tarballs: http://www.kernel.org/pub/linux/kernel/people/jsipek/guilt/ Git repo: git://git.kernel.org/pub/scm/linux/kernel/git/jsipek/guilt.git Overall, a lot of good changes that make the whole porcelain more robust. The most notable one is the format of the status file (lists pushed patches) which now also includes the hash of the comm...
Jan 8, 5:47 am 2007
Martin Langhoff
[PATCH] cvsimport: document -S and -L options
Signed-off-by: Martin Langhoff <martin@catalyst.net.nz> --- I was surprised to find that I seem to have added those myself. So, correct the bad manners of not documenting them earlier. --- Documentation/git-cvsimport.txt | 8 ++++++++ 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/Documentation/git-cvsimport.txt b/Documentation/git-cvsimport.txt index 6deee94..7c0e6b9 100644 --- a/Documentation/git-cvsimport.txt +++ b/Documentation/git-cvsimport.txt @@ -104,6 +104,1...
Jan 8, 2:53 am 2007
Martin Langhoff
[PATCH] cvsimport: skip commits that are too recent
With this patch, cvsimport will skip commits made in the last 10 minutes. The recent-ness test is of 5 minutes + cvsps fuzz window (5 minutes default). To force recent commits to be imported, pass the -a(ll) flag. When working with a CVS repository that is in use, importing commits that are too recent can lead to partially incorrect trees. This is mainly due to - Commits that are within the cvsps fuzz window may later be found to have affected more files. - When performing incremental...
Jan 8, 2:43 am 2007
Martin Langhoff
Re: [PATCH] cvsimport: skip commits that are too recent
Here is the repost with appropriate doco and an override ;-) In related news, I am trying to debug an import that consistently skips over remote commits... which is bad, bad news. The culprit seems to be cvsps -- it skips commits it clearly knows about, and I'm not sure why. I do think those were commits that cvsps saw half-baked in the first place. Passing -x to cvsps does bring those commits back, cvsps with -x can afford to rewrite history a little bit. As long as the history being rewritte...
Jan 8, 3:17 am 2007
Martin Langhoff
Re: [PATCH] cvsimport: skip commits that are too recent
Correction: it is -p ' -x ' that you need to pass. Things _are_ saner here with it. YMMV. cheers, martin -
Jan 8, 4:24 am 2007
Horst H. von Brand
Re: [ANNOUNCE] GIT 1.4.4.4
I get git version 1.4.4.4.g9a5e4 (used to be 1.5.0.rc0.gXXXX) on the msater branch now? -- Dr. Horst H. von Brand User #22616 counter.li.org Departamento de Informatica Fono: +56 32 2654431 Universidad Tecnica Federico Santa Maria +56 32 2654239 Casilla 110-V, Valparaiso, Chile Fax: +56 32 2797513 -
Jan 8, 9:30 am 2007
Johannes Schindelin
Re: [PATCH 1/2] Sanitize for_each_reflog_ent()
Hi, My reasoning is that invalid entries should rather be ignored than be taken into account. So, to verify that you are not walking invalid data, you have to parse it anyway. Ciao, Dscho -
Jan 8, 8:18 am 2007
Theodore Tso
Re: How git affects kernel.org performance
The fastest and probably most important thing to add is some readahead smarts to directories --- both to the htree and non-htree cases. If you're using some kind of b-tree structure, such as XFS does for directories, preallocation doesn't help you much. Delayed allocation can save you if your delayed allocator knows how to structure disk blocks so that a btree-traversal is efficient, but I'm guessing the biggest reason why we are losing is because we don't have sufficient readahead. This also ha...
Jan 8, 8:58 am 2007
Jeff Garzik
Re: How git affects kernel.org performance
Something I just thought of: ATA and SCSI hard disks do their own read-ahead. Seeking all over the place to pick up bits of directory will hurt even more with the disk reading and throwing away data (albeit in its internal elevator and cache). Jeff -
Jan 8, 9:43 am 2007
Paul Jackson
Re: How git affects kernel.org performance
Probably this is wishful thinking on my part, but I would have hoped that most of the read-ahead they did was for stuff that happened to be on the cylinder they were reading anyway. So long as their read-ahead doesn't cause much extra or delayed disk head motion, what does it matter? -- I won't rest till it's the best ... Programmer, Linux Scalability Paul Jackson <pj@sgi.com> 1.925.600.0401 -
Jan 8, 9:09 pm 2007
Jeremy Higdon
Re: How git affects kernel.org performance
And they usually won't readahead if there is another command to process, though they can be set up to read unrequested data in spite of outstanding commands. When they are reading ahead, they'll only fetch LBAs beyond the last request until a buffer fills or the readahead gets interrupted. jeremy -
Jan 8, 10:18 pm 2007
Johannes Stezenbach
Re: How git affects kernel.org performance
Would e2fsck -D help? What kind of optimization does it perform? Thanks, Johannes -
Jan 8, 9:41 am 2007
Theodore Tso
Re: How git affects kernel.org performance
It will help a little; e2fsck -D compresses the logical view of the directory, but it doesn't optimize the physical layout on disk at all, and of course, it won't help with the lack of readahead logic. It's possible to improve how e2fsck -D works, at the moment, it's not trying to make the directory be contiguous on disk. What it should probably do is to pull a list of all of the blocks used by the directory, sort them, and then try to see if it can improve on the list by allocating some new bloc...
Jan 8, 9:56 am 2007
Pavel Machek Jan 8, 9:59 am 2007
Theodore Tso
Re: How git affects kernel.org performance
I wasn't proposing to move other data blocks around in order make the directory be contiguous, but just a "quick and dirty" try to make things better. But yes, in order to really fix layout issues you would have to do a full defrag, and it's probably more important that we try to fix things so that defragmentation runs aren't necessary in the first place.... - Ted -
Jan 8, 10:17 am 2007
Nicolas Pitre
Re: How git affects kernel.org performance
No. There are no thin packs for pushes. And IMHO it should stay that way exactly to avoid this little inconvenience on servers. The fetch case is a different story of course. Nicolas -
Jan 8, 10:46 am 2007
Andy Whitcroft
Re: [PATCH] git-reset --hard: use quotes when we tell the us...
Heh, well perhaps I should use the original for a while longer and see if I get used to it. Of course I mostly use git on git and linux which both tend to have "error" in their titles :). -apw -
Jan 8, 4:33 am 2007
Stefan-W. Hahn
Re: [PATCH] Test for failing pread() on cygwin.
Just, because the length of the strings plays a role. With the strings defined in test_lib there were no errors. Stefan -- Stefan-W. Hahn It is easy to make things. / mailto:stefan.hahn@s-hahn.de / It is hard to make things simple. -
Jan 8, 1:09 pm 2007
previous daytodaynext day
January 7, 2007January 8, 2007January 9, 2007
speck-geostationary