Basically, this boils down to the same old issue: if you have a fixed
access pattern (like SHA1_Update() over the whole buffer), you're actually
likely to perform better with a loop of read() calls than with mmap.
So if we ONLY did the SHA1 thing, we shouldn't do mmap, we should just
chunk things up into 16kB buffers or something, and read them.
But the mmap in pack-check _also_ ends up being for the subsequent object
checking (with unpacking etc), so the mmap here actually is probably the
right thing to do. I really wouldn't worry, unless we get people who
report real problems (and I think the problems with svn-import of the huge
KDE repos are all elsewhere, notably in teh SVN import itself, not in any
pack handling ;)
Linus
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
