Re: More precise tag following

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Linus Torvalds
Date: Saturday, January 27, 2007 - 3:54 pm

On Sat, 27 Jan 2007, Junio C Hamano wrote:

I looked at using "emit_porcelain()" directly, but that format doesn't 
seem to actually be usable for incremental blame.

For example: the porcelain depends on things like the MORE_THAN_ONE_PATH 
flag having been computed, which simply isn't known incrementally.

Also, for the incremental blame, it makes no sense to actually print out 
the actual blame buffer: anybody who uses the incremental blame thing 
really needs to get the original buffer separately set up anyway.

So one one hand, I agree: the output really should probably share a lot of 
the ideas with --porcelain. At the same time, the porcelain output as it 
is now is actually very non-sensible for the incremental case.

(The "METAINFO_SHOWN" kind of logic works fine for --incremental, though. 
It's only the MORE_THAN_ONE_PATH things that don't really make sense until 
the end, since they are part of the discovery logic rather than part of 
the actual print-out logic. I guess it _works_, but still).

I think the people who will care are the people who actually write some 
nice gui around it..

		Linus
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Re: More precise tag following, Junio C Hamano, (Sat Jan 27, 3:00 pm)
Re: More precise tag following, Linus Torvalds, (Sat Jan 27, 3:54 pm)
Re: More precise tag following, Junio C Hamano, (Sun Jan 28, 2:27 am)
[PATCH] git-blame --incremental: don't use pager, rene.scharfe, (Sun Jan 28, 7:25 am)
Re: More precise tag following, Linus Torvalds, (Sun Jan 28, 12:08 pm)
Re: More precise tag following, Junio C Hamano, (Sun Jan 28, 12:18 pm)
Re: More precise tag following, Linus Torvalds, (Sun Jan 28, 12:57 pm)
Re: More precise tag following, Junio C Hamano, (Sun Jan 28, 12:58 pm)
Re: More precise tag following, Junio C Hamano, (Sun Jan 28, 1:01 pm)
[PATCH] document 'blame --incremental', Junio C Hamano, (Sun Jan 28, 1:20 pm)
Re: More precise tag following, Junio C Hamano, (Sun Jan 28, 2:06 pm)
Re: More precise tag following, Jeff King, (Sun Jan 28, 4:01 pm)
Re: More precise tag following, Shawn O. Pearce, (Sun Jan 28, 11:18 pm)
Re: More precise tag following, Junio C Hamano, (Mon Jan 29, 3:17 am)
Re: More precise tag following, Shawn O. Pearce, (Mon Jan 29, 3:31 am)
Re: More precise tag following, Linus Torvalds, (Mon Jan 29, 9:24 am)
Re: More precise tag following, Simon 'corecode' Sch ..., (Mon Jan 29, 11:07 am)
Re: More precise tag following, Theodore Tso, (Mon Jan 29, 12:29 pm)
Re: More precise tag following, Linus Torvalds, (Mon Jan 29, 12:45 pm)
Re: More precise tag following, Junio C Hamano, (Tue Jan 30, 2:22 am)
Re: More precise tag following, Shawn O. Pearce, (Tue Jan 30, 8:31 am)
Re: More precise tag following, Linus Torvalds, (Tue Jan 30, 10:02 am)
Re: More precise tag following, Shawn O. Pearce, (Fri Feb 9, 12:41 am)