git mailing list

FromSubjectsort iconDate
Shawn O. Pearce
git.or.cz version number way out of date
Quote from http://git.or.cz/: The latest stable Git release is v1.4.4.1. Uh, no, its not. Its v1.4.4.4. :-) -- Shawn. -
Jan 20, 2:44 pm 2007
Johannes Schindelin
[PATCH] --walk-reflogs: honour --relative-date
Now, if you say git log --walk-reflogs --relative-date next@{yesterday} it shows the reflog date as a relative date expression. Signed-off-by: Johannes Schindelin <Johannes.Schindelin@gmx.de> --- log-tree.c | 3 ++- reflog-walk.c | 6 +++--- reflog-walk.h | 3 ++- 3 files changed, 7 insertions(+), 5 deletions(-) diff --git a/log-tree.c b/log-tree.c index f043ad3..843a7c5 100644 --- a/log-tree.c +++ b/log-tree.c @@ -225,7 +225,8 @@ void show_log(struct rev_info *opt, ...
Jan 20, 2:39 pm 2007
Johannes Schindelin
[PATCH] --walk-reflogs: do not crash with cyclic reflog ...
Since you can reset --hard to any revision you already had, when traversing the reflog ancestry, we may not free() the commit buffer. Signed-off-by: Johannes Schindelin <Johannes.Schindelin@gmx.de> --- builtin-log.c | 7 +++++-- 1 files changed, 5 insertions(+), 2 deletions(-) diff --git a/builtin-log.c b/builtin-log.c index f3cff13..13a3f9b 100644 --- a/builtin-log.c +++ b/builtin-log.c @@ -50,8 +50,11 @@ static int cmd_log_walk(struct rev_info *rev) prepare_revision_walk(rev); ...
Jan 20, 2:28 pm 2007
Junio C Hamano
Re: [PATCH] show_date(): fix relative dates
Exactly. You are absolutely right. I should have done that when I did the show-branch --reflog workaround to pass 0. -
Jan 20, 7:48 pm 2007
Junio C Hamano
Re: [PATCH] show_date(): fix relative dates
I noticed this and have a different solution in the show-branch --reflog code (it does not pass tz). I haven't thought about which solution is the correct one (and do not have time to think about it now while writing this message, sorry -- will do the thinking later unless you beat me to it). -
Jan 20, 5:59 pm 2007
Johannes Schindelin
[PATCH] show_date(): fix relative dates
We pass a timestamp (i.e. number of seconds elapsed since Jan 1 1970, 00:00:00 GMT) to the function. So there is no need to "fix" the timestamp according to the timezone. Signed-off-by: Johannes Schindelin <Johannes.Schindelin@gmx.de> --- Just compile & run this little test program to see what I mean: #include "cache.h" int main(int argc, char **argv) { time_t t = time(NULL); printf("%s\n", show_rfc2822_date(t, 100)); printf("%s\n", show_date(t, 100, 0)); printf("%s\n", ...
Jan 20, 2:21 pm 2007
Johannes Schindelin
Re: [PATCH] show_date(): fix relative dates
Hi, Actually, you do pass tz, but with a fixed value of 0. But this is only a workaround. The thing is, if you pass the same timestamp with a different timezone, absolute (non-relative) date will show the same time, i.e. 22:24 +0000 is the same as 23:24 +0100. Now I expect the same of relative mode, only that the timezone does not matter for relative mode _at all_. As you can see in my patch for --walk-reflogs (to honour --relative-date), it can make sense to pass make the choice ...
Jan 20, 6:34 pm 2007
Jakub Narebski
Re: Meaning of "fatal: protocol error: bad line length c ...
The latest is git 1.4.4.4. Available for example from http://kernel.org/pub/software/scm/git/ -- Jakub Narebski Warsaw, Poland ShadeHawk on #git -
Jan 20, 1:07 pm 2007
Simon 'corecode' Sch ...
Re: [PATCH] Lose perl dependency. (fwd)
I like this. However, rev_info.reverse needs some documentation. Or the= block in get_revision does: /* * rev_info.reverse is used to note the fact that we want to output the l= ist * of revisions in reverse order. To accomplish this goal, reverse can h= ave * different values: * 0 do nothing * 1 reverse the list * 2 internal use: we have already obtained and reversed the list, * now we only need to yield its items. */ cheers simon --=20 Serve - BSD ...
Jan 20, 7:56 pm 2007
Robin Rosenberg Jan 20, 5:37 pm 2007
Johannes Schindelin
Re: [PATCH] Lose perl dependency. (fwd)
Hi, On Sun, 21 Jan 2007, Robin Rosenberg wrote: > l
Jan 20, 6:39 pm 2007
Junio C Hamano
Re: [PATCH] Lose perl dependency. (fwd)
I think you are talking about the second semantics; I was talking about the first one. In other words, the one whose semantics of: $ git log --max-count=10 --skip=5 --reverse HEAD is to first internally run $ git log --max-count=10 --skip=5 HEAD then reverse the resulting 10 commits and spit them out. Now, "git log --max-count=10 --skip=5" does not need to call limit_list(). It needs to traverse the usual date-sorted revs->commits for fifteen rounds. Looking at your patch ...
Jan 20, 11:31 am 2007
Bill Lear
Re: [PATCH] Lose perl dependency. (fwd)
How about a '--order' switch? --order=chrono[logical] --order=rev[erse][-chrono[logical]] (default) The switches "--reverse" and "--noreverse" are certainly confusing in the context of a default that is "reverse chronological order". BTW, my mailer is defaulting to sending mail to the original poster, CCing others, including the mailing list. I'm used to simply replying to the list. Is this the proper convention here, to reply directly to humans and CC the list? Bill >> l
Jan 20, 7:32 pm 2007
Junio C Hamano
Re: [PATCH] Lose perl dependency. (fwd)
I think --reverse is just fine. It is "reverse" from usual, and people already know (or they should learn) what the usual order I only speak for myself, but I always prefer to address my message's To: header to the person I am primarily talking to, while leaving other people on Cc: line (which usually includes the list address). -
Jan 20, 8:17 pm 2007
Johannes Schindelin
Re: [PATCH] Lose perl dependency. (fwd)
Hi, Yes. But I have to traverse this _first_, before even returning a commit from get_revision(). I had the impression that limit_list() traversed all commits. But I am Okay, I thought that limit_list() honours --skip and --max-count. Looking But that would not work, would it? Example: A - B - C - D D is the HEAD. Now, when we do not limit_list(), when we get into get_revision() for the first time, revs->commits contains _only_ D (we do the ancestry walk on-the-fly). So, ...
Jan 20, 3:04 pm 2007
Yann Dirson
[PATCH] Add new 'rebase' command.
Signed-off-by: Yann Dirson <ydirson@altern.org> --- Take two: I had forgotten to add "rebase" to the list of stack commands for the purpose of help. stgit/commands/rebase.py | 69 ++++++++++++++++++++++++++++++++++++++++++++++ stgit/main.py | 2 + t/t2200-rebase.sh | 33 ++++++++++++++++++++++ 3 files changed, 104 insertions(+), 0 deletions(-) diff --git a/stgit/commands/rebase.py b/stgit/commands/rebase.py new file mode 100644 index 0000000..79d67a7 --- ...
Jan 20, 11:04 am 2007
Yann Dirson
[PATCH] Add new 'rebase' command.
Signed-off-by: Yann Dirson <ydirson@altern.org> --- This patch uses the "rebase --to <target>" syntax, which leaves room for the feature suggeted by Jakub to use "rebase <stack>" to rebase a stack onto current branch. stgit/commands/rebase.py | 69 ++++++++++++++++++++++++++++++++++++++++++++++ stgit/main.py | 1 + t/t2200-rebase.sh | 33 ++++++++++++++++++++++ 3 files changed, 103 insertions(+), 0 deletions(-) diff --git a/stgit/commands/rebase.py ...
Jan 20, 8:46 am 2007
Yann Dirson Jan 20, 8:09 am 2007
Yann Dirson
[BUG] Problem with "stgit push" causing data loss
Well, "data loss" is a bit strong, since the data is still available to find using git-lost-found. I first tried to reproduce with a simple test-case, but could not, so here is my way to reproduce it, on a clone of the stgit official workspace. stgit$ stg branch --create test origin Branch "test" created. The test patch is my previous work on "pull --to", now superceded by "rebase". Patch to reproduce attached to this mail - I just use "pick" since it's easier for me: stgit$ ./stg ...
Jan 20, 8:01 am 2007
Bill Lear
Meaning of "fatal: protocol error: bad line length character"?
[Many thanks to Junio for explaining in generous detail how to think properly about branches in git's distributed model.] We are making progress in our conversion to git, but one of our developers, on pushing into our company repo, has encountered this error: % git push updating 'refs/heads/master' from 6b421066e842203e383e1dc466c1cdef10de56b1 to 2a8e554ae0c99d44988690c9fce693b3f5f128fa Generating pack... Done counting 61 objects. Result has 32 objects. Deltifying 32 objects. ...
Jan 20, 5:04 am 2007
Junio C Hamano
Re: Meaning of "fatal: protocol error: bad line length c ...
I've seen this "bad line length character" mentioned in #git and on this list but nobody seems to have hunted down what this is. http://www.gelato.unsw.edu.au/archives/git/0603/17807.html is another (Google finds some others for the error message on xcb list but that is about fetch-pack which is totally different codepath). Your report and the above one both mention there was no harm, which is somewhat of consolation but it definitely is not a good sign. I've tried to reproduce it, ...
Jan 20, 12:24 pm 2007
Shawn O. Pearce
Re: Meaning of "fatal: protocol error: bad line length c ...
Don't tell us tcsh is doing something ugly like opening the tty for stdout/stderr instead of using the ones it inherited from its parent. 'cause that's just useless! -- Shawn. -
Jan 20, 2:37 pm 2007
Junio C Hamano
Re: Meaning of "fatal: protocol error: bad line length c ...
Heh, you'll never know what you would get until you ask. I temporarily run chsh on myself to use tcsh as my login shell, and sure enough I am getting the error. fatal: protocol error: bad line length character: 75 70 64 61 It reads "u p d a"; most likely the command name we are running, which is "update". I think it is spitting out an error message or something silly like that saying "update hook is not executable". Let me dig a bit further and report later. This is with my previous ...
Jan 20, 1:20 pm 2007
Junio C Hamano
Re: Meaning of "fatal: protocol error: bad line length c ...
That was output to stdout made from the update hook in my case. I do not know your setup, but if you make sure your update hook does not spit out anything to its stdout (diag can go to stderr), you should be able to work it around. Funny thing is, at least in recent enough git, I think we set up redirection to force output from hook scripts to stderr, but I do not remember when it happened. Let's see... ...goes and looks... That was supposed to have been fixed with commit cd83c74c ...
Jan 20, 1:42 pm 2007
Junio C Hamano
Re: Meaning of "fatal: protocol error: bad line length c ...
By the way, I can see from the pack-objects output above that you seem to be using git before commit 67c08ce1 (Nov 29, 2006); most likely you are using the official 1.4.4.4? Is it possible for you to try git built from the tip of 'master' to see if it reproduces? -
Jan 20, 12:33 pm 2007
Bill Lear
Re: Meaning of "fatal: protocol error: bad line length c ...
We are using git 1.4.4.1, the latest I thought available, not 1.4.4.4 (perhaps you mis-typed?). In any case, I personally would love to try the latest build of git, but I don't think I can convince the rest of the company to do so. I just got an email from one of the developers. He seems to think this is alleviated by using bash instead of tcsh. He said he is debugging his environment to see if he can isolate the problem. I have asked for more details and if I can find out more, I ...
Jan 20, 12:54 pm 2007
Johannes Schindelin
Re: [PATCH] --walk-reflogs: actually find the right comm ...
Hi, I tried to reproduce this effect, but so far no luck. I even let the function get_reflog_recno_by_time() output what it does, and it picks exactly the right commit. Do you have a time skew? Ciao, Dscho -
Jan 20, 2:36 pm 2007
Johannes Schindelin
Re: [PATCH] --walk-reflogs: actually find the right comm ...
Hi, BTW this fixes your "git-log --walk-reflogs -1 --pretty=s master@{1.day}" bug. Ciao, Dscho -
Jan 20, 2:52 am 2007
Johannes Schindelin
[PATCH] --walk-reflogs: actually find the right commit b ...
Embarassing thinko. Signed-off-by: Johannes Schindelin <Johannes.Schindelin@gmx.de> --- reflog-walk.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/reflog-walk.c b/reflog-walk.c index d4b49c7..d58ff9b 100644 --- a/reflog-walk.c +++ b/reflog-walk.c @@ -70,7 +70,7 @@ static int get_reflog_recno_by_time(struct complete_reflogs *array, unsigned long timestamp) { int i; - for (i = array->nr - 1; i >= 0; i++) + for (i = array->nr - 1; i >= 0; i--) if ...
Jan 20, 2:49 am 2007
Junio C Hamano
Re: [PATCH] --walk-reflogs: actually find the right comm ...
Aha, progress ;-). But it still seems to pick up entry that is less than specified number of hours if I do: $ git log --walk-reflogs -4 master@{1.hour} | head -2 commit 33dd19c2a9c0b114436f53d86fc1c2c5e00c26bb Reflog: master@{Sat, 20 Jan 2007 00:01:35 -0800} (Junio C Ham It is Jan 20th 02:10 now and the master was not pointing at that commit 1 hour ago. Anyway, I am done for the night -- I haven't finished testing the updated 'master' and 'next', so I'll push out the ...
Jan 20, 3:11 am 2007
Martin Waitz
Re: SEGV in git-apply
hoi :) patch was this one: ------------------ 8< ------------------------------- --- src/callbacks.cc 2006-11-02 10:16:50.000000000 +0100 +++ src/callbacks.cc 2007-01-17 20:47:00.000000000 +0100 @@ -12890,12 +12890,11 @@ void on_unknown_edit_optionmenu_sign_cha } } =20 -gboolean on_key_press_event(GtkWidget*, GdkEventKey *event, gpointer) { +gboolean on_key_press_event(GtkWidget *o, GdkEventKey *event, gpointer) { if(!GTK_WIDGET_HAS_FOCUS(expression) && (event->keyval > GDK_Hyper_R ...
Jan 20, 11:36 am 2007
Johannes Schindelin
[PATCH] apply --cached: fix crash in subdirectory
The static variable "prefix" was shadowed by an unused parameter of the same name. In case of execution in a subdirectory, the static variable was accessed, leading to a crash. Signed-off-by: Knoppix User <knoppix@zweitrechner.(none)> --- On Sat, 20 Jan 2007, Martin Waitz wrote: > git-apply inside the "src" directory segfaulted. Well, that was not the complete truth now, was it? Cannily, you avoided mentioning the use of the "--cached" argument... But as you see, your evil ...
Jan 20, 6:17 pm 2007
Johannes Schindelin
Re: [PATCH] --walk-reflogs: disallow uninteresting commits
Hi, ;-) I sort of waited for comments on this behaviour. Maybe it would be better to always show the number, _and_ a relative time? I.e. Not yet. Will look into it. Ciao, Dscho -
Jan 20, 2:32 am 2007
Junio C Hamano
Re: [PATCH] --walk-reflogs: disallow uninteresting commits
Here is what I have at the top of the topic (after a few fixups, so it might not apply directly). -- >8 -- [PATCH] Fix --walk-reflog with --pretty=oneline Now, "git log --abbrev-commit --pretty=o --walk-reflogs HEAD" is reasonably pleasant to use. Signed-off-by: Junio C Hamano <junkio@cox.net> --- Documentation/git-rev-list.txt | 4 +++- log-tree.c | 3 ++- reflog-walk.c | 33 ++++++++++++++++++++++----------- reflog-walk.h ...
Jan 20, 2:39 am 2007
Junio C Hamano
Re: [PATCH] --walk-reflogs: disallow uninteresting commits
Thanks. This certainly needs a better documentation -- the attached is my try. By the way, I haven't looked into it, but does this ring a bell? $ git-log --walk-reflogs -1 --pretty=s master@{1.day} commit 72fe6a59890870ed9c3e9e1e6381fc0d7ba75fe4 Reflog: master@{Thu, 1 Jan 1970 00:00:00 +0000} ((null)) Reflog message: (null)Author: Junio C Hamano <junkio@cox.net> Documentation: Generate command lists. --- diff --git a/Documentation/git-rev-list.txt ...
Jan 20, 12:21 am 2007
Andy Parkins
Re: [PATCH] New files in git weren't being downloaded du ...
I'm sure you're right; I don't know enough about CVS to comment. The real fix would seem to be to completely remove the special case for added files and let it drop through to the normal update code. However, I'm not confident about that either. Andy -- Dr Andrew Parkins, M Eng (Hons), AMIEE andyparkins@gmail.com -
Jan 20, 3:25 am 2007
Simon 'corecode' Sch ...
Re: [PATCH] New files in git weren't being downloaded du ...
yes, that's what I ment. cheers simon --=20 Serve - BSD +++ RENT this banner advert +++ ASCII Ribbon /"\ Work - Mac +++ space for low =E2=82=AC=E2=82=AC=E2=82=AC NOW!1 +++= Campaign \ / Party Enjoy Relax | http://dragonflybsd.org Against HTML \ Dude 2c 2 the max ! http://golden-apple.biz Mail + News / \
Jan 20, 3:41 am 2007
Johannes Schindelin
Re: MinGW port - initial work uploaded
Hi, Blame me, not Johannes ;-) As for the #ifdef stuff, I'd rather have a look if it can't be done cleanly by conditional compiling, like we do for NO_MMAP, for example. Ciao, Dscho -
Jan 20, 2:24 am 2007
Christian MICHON
Re: MinGW port - initial work uploaded
Hi Johannes(s) and list, I managed a compilation, and some commands work, some don't. Up to the first git commit, all is find. I need to invoke the commit through the git-commit actually, "git commit" says it's not a valid git command. so bash is a true need in this case, might not even work in pure win32 cmd.exe approach. Furthermore, once the commit is in, "git log" and git-log do not work. Same for git-whatchanged and git-diff. I need to try with the specific versions you mentionned, ...
Jan 20, 1:21 pm 2007
Johannes Sixt
Re: MinGW port - initial work uploaded
I consider this branch only the sandbox for the MinGW port. Although I've tried to make the branch as clean as possible, it is still a bit messy, and not everything is #ifdef'd that should be. For this reason I will not try to convince Junio to pull this topic directly. The goal is rather to work towards a complete port, then later factor out patches that bring 'master' or 'next' closer to this branch so that finally only at most a I like this idea. -- Hannes -
Jan 20, 1:05 pm 2007
Simon 'corecode' Sch ...
Re: [PATCH] Don't call fstat() on stdin in index-pack.
It better be :) My OS of choice has 64bit off_t and ino_t since a long t= ime now... cheers simon --=20 Serve - BSD +++ RENT this banner advert +++ ASCII Ribbon /"\ Work - Mac +++ space for low =E2=82=AC=E2=82=AC=E2=82=AC NOW!1 +++= Campaign \ / Party Enjoy Relax | http://dragonflybsd.org Against HTML \ Dude 2c 2 the max ! http://golden-apple.biz Mail + News / \
Jan 20, 11:00 am 2007
Sergey Vlasov
Re: [PATCH] Don't call fstat() on stdin in index-pack.
Most likely it is the st_ino field - the kernel assigns unique inode numbers for pipes from an "unsigned long" counter, which is 64-bit in this case, and *stat() calls must fail with EOVERFLOW if the inode number does not fit into ino_t, which is 32-bit here. This problem is known for some time, and there is even a kernel patch proposed as a workaround (which makes the counter 32-bit): http://permalink.gmane.org/gmane.linux.file-systems/12526 AFAIK, that patch is not upstream yet - so ...
Jan 20, 8:35 am 2007
Matthias Lederhofer
Re: [PATCH] prune: --expire=time
Perhaps we could also use 'none' or 'all, e.g. --retain=none or --expire=all. -
Jan 20, 4:18 am 2007
Simon 'corecode' Sch ...
Re: [PATCH] prune: --expire=time
Not that I want to sabotage this discussion, but you have a very valid po= int. A timeout can always be crossed, and then bad things[tm] happen. My idea is to create a marker file when creating (yet) unconnected loose = objects, i.e. on commit/push/fetch. After the ref was updated or on abor= t, this marker would be removed. Prune then can simply search for the ol= dest marker and only remove objects older than this marker. Of course this also can mean that a marker file somehow stays and ...
Jan 20, 5:06 am 2007
Johannes Schindelin
Re: [PATCH] Lose perl dependency. (fwd)
Hi, Evidently, I did not even think about the latter. And I guess that most people expect the former, too. (Maybe we should make it a flipflop, so Why? To see the last commit (which should be output first), I _have_ to traverse them first, before reversing the order. I thought revs->limited does exactly that -- traverse all commits first. Am I mistaken? Ciao, Dscho -
Jan 20, 2:28 am 2007
Yann Dirson
Re: Rebasing stgit stacks
So this what we typically currently get by using "stg pull . branchname", when HEAD is the stack branch. I can easily see that called as "stg rebase", with --to argument defaulting to parent branch (as given by branch.<name>.merge) when the HEAD is the stack branch. That would be a neat replacement for "stg pull . <name>". Calling 'stg rebase' from the branch to rebase onto, however, can't guess which stack to rebase - there are possibly many stacks forked off your branch. In that case, ...
Jan 20, 1:07 pm 2007
Jakub Narebski
Re: Rebasing stgit stacks
Well, I haven't thought this through. I was thinking about situation where there are no applied patches, and some commits were done without StGIT (pure git), i.e. we had ..1...2...3 <-- unapplied (deck) [ branch ] / a---b---c---d <-- HEAD [ branch ] There were some git commits (for example fetch, or cherry-pick, or ...) ..1...2...3 <-- unapplied (deck) [ branch ] / a---b---c---d---e---f <-- HEAD [ ...
Jan 20, 12:16 pm 2007
Yann Dirson
Re: Rebasing stgit stacks
I'm not sure I understand. Since the "current StGIT stack" is the one pointed to by HEAD, how do you specify, when HEAD points to the target Hm, the operation is not just about moving the stack base, it also has to reapply patches, so, whereas the central concept is about moving the base, the whole operation is indeed about the rebaseing the whole stack. I'm not sure we need to expose the "stack base" to the user as an object she could manipulate all alone, I'd rather think it should ...
Jan 20, 6:17 am 2007
Jakub Narebski
[PATCH] Documentation/config.txt: Document config file s ...
Separate part of Documentation/config.txt which deals with git config file syntax into "Syntax" subsection, and expand it. Add information about subsections, boolean values, escaping and escape sequences in string values, and continuing variable value on the next line. Add also proxy settings to config file example to show example of partially enclosed in double quotes string value. Parts based on comments by Junio C Hamano, Johannes Schindelin, and the smb.conf(5) man ...
Jan 20, 7:03 am 2007
previous daytodaynext day
January 19, 2007January 20, 2007January 19, 2007